summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCharles Manning <cdhmanning@gmail.com>2011-01-20 11:35:08 +1300
committerCharles Manning <cdhmanning@gmail.com>2011-01-20 11:35:08 +1300
commit2621bcf7c81e3add56dc18c49177c5572d358f4a (patch)
tree5b779acb88f328873a98a0567fda550e801346c6
parent371b2eaad7d9c4947ec1e5c5f0576b7e118df617 (diff)
yaffs: Fix NULL check sequence.
Potential NULL dreference before check. Picked up by Coverity check. Signed-off-by: Charles Manning <cdhmanning@gmail.com>
-rw-r--r--yaffs_guts.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/yaffs_guts.c b/yaffs_guts.c
index a579eee..496cf5f 100644
--- a/yaffs_guts.c
+++ b/yaffs_guts.c
@@ -1640,15 +1640,15 @@ static void yaffs_unhash_obj(struct yaffs_obj *obj)
/* FreeObject frees up a Object and puts it back on the free list */
static void yaffs_free_obj(struct yaffs_obj *obj)
{
- struct yaffs_dev *dev = obj->my_dev;
-
- yaffs_trace(YAFFS_TRACE_OS, "FreeObject %p inode %p",
- obj, obj->my_inode);
+ struct yaffs_dev *dev;
if (!obj) {
YBUG();
return;
}
+ dev = obj->my_dev;
+ yaffs_trace(YAFFS_TRACE_OS, "FreeObject %p inode %p",
+ obj, obj->my_inode);
if (obj->parent)
YBUG();
if (!list_empty(&obj->siblings))