diff options
| author | charles <charles> | 2006-09-14 22:02:46 +0000 |
|---|---|---|
| committer | charles <charles> | 2006-09-14 22:02:46 +0000 |
| commit | 20488750f4e5df4cec34f2bd4db39ab7e075d0a9 (patch) | |
| tree | 3d2dfb3500dfb83ea084aa97dc95913a9e3a7b73 | |
| parent | 9153cc25d65e676ac9ef0ed4a557be2778a40c70 (diff) | |
Bounds check on ecc correction
| -rw-r--r-- | yaffs_ecc.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/yaffs_ecc.c b/yaffs_ecc.c index 59f3ed9..813ce6d 100644 --- a/yaffs_ecc.c +++ b/yaffs_ecc.c @@ -31,7 +31,7 @@ */ const char *yaffs_ecc_c_version = - "$Id: yaffs_ecc.c,v 1.6 2005-08-11 02:51:49 charles Exp $"; + "$Id: yaffs_ecc.c,v 1.7 2006-09-14 22:02:46 charles Exp $"; #include "yportenv.h" @@ -295,7 +295,8 @@ int yaffs_ECCCorrectOther(unsigned char *data, unsigned nBytes, if ((cDelta | lDelta | lDeltaPrime) == 0) return 0; /* no error */ - if (lDelta == ~lDeltaPrime && (((cDelta ^ (cDelta >> 1)) & 0x15) == 0x15)) + if (lDelta == ~lDeltaPrime && + (((cDelta ^ (cDelta >> 1)) & 0x15) == 0x15)) { /* Single bit (recoverable) error in data */ @@ -308,6 +309,9 @@ int yaffs_ECCCorrectOther(unsigned char *data, unsigned nBytes, if (cDelta & 0x02) bit |= 0x01; + if(lDelta >= nBytes) + return -1; + data[lDelta] ^= (1 << bit); return 1; /* corrected */ |