diff options
| author | Aun-Ali Zaidi <admin@kodeit.net> | 2015-12-23 14:44:02 -0600 |
|---|---|---|
| committer | Joel Sherrill <joel.sherrill@oarcorp.com> | 2015-12-24 16:52:34 -0600 |
| commit | d5154d0f6a04f3b7ed59d9a09038576fe2640756 (patch) | |
| tree | 4b6dcf6e9b116223903afbc1b1141d28fb751848 /testsuites/tmtests/tmoverhd | |
| parent | score: Fix watchdog removal (diff) | |
| download | rtems-d5154d0f6a04f3b7ed59d9a09038576fe2640756.tar.bz2 | |
api: Remove deprecated Notepads
Notepads where a feature of RTEMS' tasks that simply functioned in
the same way as POSIX keys or threaded local storage (TLS). They were
introduced well before per task variables, which are also deprecated,
and were barely used in favor of their POSIX alternatives.
In addition to their scarce usage, Notepads took up unnecessary memory.
For each task:
- 16 32-bit integers were allocated.
- A total of 64 bytes per task per thread.
This is especially critical in low memory and safety-critical applications.
They are also defined as uint32_t, and therefore are not guaranteed to
hold a pointer.
Lastly, they are not portable solutions for SMP and uniprocessor systems,
like POSIX keys and TLS.
updates #2493.
Diffstat (limited to 'testsuites/tmtests/tmoverhd')
| -rw-r--r-- | testsuites/tmtests/tmoverhd/dumrtems.h | 6 | ||||
| -rw-r--r-- | testsuites/tmtests/tmoverhd/testtask.c | 32 | ||||
| -rw-r--r-- | testsuites/tmtests/tmoverhd/tmoverhd.doc | 2 |
3 files changed, 0 insertions, 40 deletions
diff --git a/testsuites/tmtests/tmoverhd/dumrtems.h b/testsuites/tmtests/tmoverhd/dumrtems.h index 535d6a1faf..eeefb75d39 100644 --- a/testsuites/tmtests/tmoverhd/dumrtems.h +++ b/testsuites/tmtests/tmoverhd/dumrtems.h @@ -59,12 +59,10 @@ #undef rtems_semaphore_release #undef rtems_task_create #undef rtems_task_delete -#undef rtems_task_get_note #undef rtems_task_ident #undef rtems_task_mode #undef rtems_task_restart #undef rtems_task_resume -#undef rtems_task_set_note #undef rtems_task_set_priority #undef rtems_task_start #undef rtems_task_suspend @@ -184,8 +182,6 @@ Empty_directive() #define rtems_task_delete( tid ) \ Empty_directive() -#define rtems_task_get_note( tid, notepad, note ) \ - Empty_directive() #define rtems_task_ident( name, node, tid ) \ Empty_directive() #define rtems_task_mode( mode, mask, pmode ) \ @@ -194,8 +190,6 @@ Empty_directive() #define rtems_task_resume( tid ) \ Empty_directive() -#define rtems_task_set_note( tid, notepad, note ) \ - Empty_directive() #define rtems_task_set_priority( tid, priority, ppriority ) \ Empty_directive() #define rtems_task_start( tid, saddr, arg ) \ diff --git a/testsuites/tmtests/tmoverhd/testtask.c b/testsuites/tmtests/tmoverhd/testtask.c index d14fd8951b..76f4e157b1 100644 --- a/testsuites/tmtests/tmoverhd/testtask.c +++ b/testsuites/tmtests/tmoverhd/testtask.c @@ -68,7 +68,6 @@ rtems_task Task_1( rtems_mode in_mode RTEMS_GCC_NOWARN_UNUSED; rtems_mode mask RTEMS_GCC_NOWARN_UNUSED; rtems_mode out_mode RTEMS_GCC_NOWARN_UNUSED; - uint32_t note RTEMS_GCC_NOWARN_UNUSED; rtems_time_of_day time RTEMS_GCC_NOWARN_UNUSED; rtems_interval timeout RTEMS_GCC_NOWARN_UNUSED; rtems_signal_set signals RTEMS_GCC_NOWARN_UNUSED; @@ -86,7 +85,6 @@ rtems_task Task_1( in_priority = 250; in_mode = RTEMS_NO_PREEMPT; mask = RTEMS_PREEMPT_MASK; - note = 8; timeout = 100; signals = RTEMS_SIGNAL_1 | RTEMS_SIGNAL_3; major = 10; @@ -251,36 +249,6 @@ rtems_task Task_1( 0 ); -/* rtems_task_get_note */ - - benchmark_timer_initialize(); - for ( index = 1 ; index <= OPERATION_COUNT ; index ++ ) - (void) rtems_task_get_note( id, 1, note ); - end_time = benchmark_timer_read(); - - put_time( - "overhead: rtems_task_get_note", - end_time, - OPERATION_COUNT, - overhead, - 0 - ); - -/* rtems_task_set_note */ - - benchmark_timer_initialize(); - for ( index = 1 ; index <= OPERATION_COUNT ; index ++ ) - (void) rtems_task_set_note( id, 1, note ); - end_time = benchmark_timer_read(); - - put_time( - "overhead: rtems_task_set_note", - end_time, - OPERATION_COUNT, - overhead, - 0 - ); - /* rtems_task_wake_when */ benchmark_timer_initialize(); diff --git a/testsuites/tmtests/tmoverhd/tmoverhd.doc b/testsuites/tmtests/tmoverhd/tmoverhd.doc index dc326c2c32..8c1d97ed28 100644 --- a/testsuites/tmtests/tmoverhd/tmoverhd.doc +++ b/testsuites/tmtests/tmoverhd/tmoverhd.doc @@ -18,8 +18,6 @@ directives: + rtems task resume + rtems task set priority + rtems task mode -+ rtems task get note -+ rtems task set note + rtems task wake when + rtems task wake after + rtems interrupt catch |