api: Remove deprecated Notepads

Notepads where a feature of RTEMS' tasks that simply functioned in
the same way as POSIX keys or threaded local storage (TLS). They were
introduced well before per task variables, which are also deprecated,
and were barely used in favor of their POSIX alternatives.

In addition to their scarce usage, Notepads took up unnecessary memory.
For each task:

 - 16 32-bit integers were allocated.
 - A total of 64 bytes per task per thread.

This is especially critical in low memory and safety-critical applications.

They are also defined as uint32_t, and therefore are not guaranteed to
hold a pointer.

Lastly, they are not portable solutions for SMP and uniprocessor systems,
like POSIX keys and TLS.

updates #2493.

7 files changed, 1 insertions, 94 deletions

diff --git a/testsuites/tmtests/tm08/system.h b/testsuites/tmtests/tm08/system.h
index 6e2df2f846..3610fe954d 100644
--- a/testsuites/tmtests/tm08/system.h
+++ b/testsuites/tmtests/tm08/system.h
@@ -27,8 +27,6 @@ rtems_task Init(
 #define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
 #define CONFIGURE_APPLICATION_NEEDS_TIMER_DRIVER
 
-#define CONFIGURE_ENABLE_CLASSIC_API_NOTEPADS
-
 #define CONFIGURE_MAXIMUM_TASKS              3
 #define CONFIGURE_TICKS_PER_TIMESLICE        0
 
diff --git a/testsuites/tmtests/tm08/task1.c b/testsuites/tmtests/tm08/task1.c
index 6d42de9900..a86322c61f 100644
--- a/testsuites/tmtests/tm08/task1.c
+++ b/testsuites/tmtests/tm08/task1.c
@@ -81,7 +81,6 @@ rtems_task test_task(
   uint32_t      index;
   rtems_task_priority old_priority;
   rtems_time_of_day   time;
-  uint32_t      old_note;
   uint32_t      old_mode;
 
   benchmark_timer_initialize();
@@ -186,44 +185,6 @@ rtems_task test_task(
   benchmark_timer_initialize();
     (void)  rtems_task_mode( RTEMS_PREEMPT, RTEMS_PREEMPT_MASK, &old_mode );
 
-  /** START OF NOTEPAD TESTS **/
-
-  /*
-   * We know this is deprecated and don't want a warning on every BSP built.
-   */
-  #pragma GCC diagnostic push
-  #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-
-    benchmark_timer_initialize();
-      for ( index=1 ; index <= OPERATION_COUNT ; index++ )
-        (void) rtems_task_set_note( Test_task_id, 8, 10 );
-    end_time = benchmark_timer_read();
-
-    put_time(
-      "rtems_task_set_note: only case",
-      end_time,
-      OPERATION_COUNT,
-      overhead,
-      CALLING_OVERHEAD_TASK_SET_NOTE
-    );
-
-    benchmark_timer_initialize();
-      for ( index=1 ; index <= OPERATION_COUNT ; index++ )
-        (void) rtems_task_get_note( Test_task_id, 8, &old_note );
-    end_time = benchmark_timer_read();
-
-    put_time(
-      "rtems_task_get_note: only case",
-      end_time,
-      OPERATION_COUNT,
-      overhead,
-      CALLING_OVERHEAD_TASK_GET_NOTE
-    );
-
-  #pragma GCC diagnostic pop
-
-  /** END OF NOTEPAD TESTS **/
-
   build_time( &time, 1, 1, 1988, 0, 0, 0, 0 );
 
   benchmark_timer_initialize();
diff --git a/testsuites/tmtests/tm08/tm08.doc b/testsuites/tmtests/tm08/tm08.doc
index dcc7a7f247..e364a58dc3 100644
--- a/testsuites/tmtests/tm08/tm08.doc
+++ b/testsuites/tmtests/tm08/tm08.doc
@@ -11,10 +11,8 @@ This test benchmarks the following operations:
   + rtems_clock_get_tod
   + rtems_clock_set
   + rtems_task_mode
-  + rtems_task_get_note
-  + rtems_task_set_note
   + rtems_task_set_priority
 
 For more information
 1. tmtests/include/timesys.h
-2. tmtests/README
\ No newline at end of file
+2. tmtests/README
diff --git a/testsuites/tmtests/tmoverhd/dumrtems.h b/testsuites/tmtests/tmoverhd/dumrtems.h
index 535d6a1faf..eeefb75d39 100644
--- a/testsuites/tmtests/tmoverhd/dumrtems.h
+++ b/testsuites/tmtests/tmoverhd/dumrtems.h
@@ -59,12 +59,10 @@
 #undef rtems_semaphore_release
 #undef rtems_task_create
 #undef rtems_task_delete
-#undef rtems_task_get_note
 #undef rtems_task_ident
 #undef rtems_task_mode
 #undef rtems_task_restart
 #undef rtems_task_resume
-#undef rtems_task_set_note
 #undef rtems_task_set_priority
 #undef rtems_task_start
 #undef rtems_task_suspend
@@ -184,8 +182,6 @@
            Empty_directive()
 #define     rtems_task_delete( tid ) \
            Empty_directive()
-#define     rtems_task_get_note( tid, notepad, note ) \
-           Empty_directive()
 #define     rtems_task_ident( name, node, tid ) \
            Empty_directive()
 #define     rtems_task_mode( mode, mask, pmode ) \
@@ -194,8 +190,6 @@
            Empty_directive()
 #define     rtems_task_resume( tid ) \
            Empty_directive()
-#define     rtems_task_set_note( tid, notepad, note ) \
-           Empty_directive()
 #define     rtems_task_set_priority( tid, priority, ppriority ) \
            Empty_directive()
 #define     rtems_task_start( tid, saddr, arg ) \
diff --git a/testsuites/tmtests/tmoverhd/testtask.c b/testsuites/tmtests/tmoverhd/testtask.c
index d14fd8951b..76f4e157b1 100644
--- a/testsuites/tmtests/tmoverhd/testtask.c
+++ b/testsuites/tmtests/tmoverhd/testtask.c
@@ -68,7 +68,6 @@ rtems_task Task_1(
   rtems_mode                 in_mode RTEMS_GCC_NOWARN_UNUSED;
   rtems_mode                 mask RTEMS_GCC_NOWARN_UNUSED;
   rtems_mode                 out_mode RTEMS_GCC_NOWARN_UNUSED;
-  uint32_t                   note RTEMS_GCC_NOWARN_UNUSED;
   rtems_time_of_day          time RTEMS_GCC_NOWARN_UNUSED;
   rtems_interval             timeout RTEMS_GCC_NOWARN_UNUSED;
   rtems_signal_set           signals RTEMS_GCC_NOWARN_UNUSED;
@@ -86,7 +85,6 @@ rtems_task Task_1(
   in_priority = 250;
   in_mode     = RTEMS_NO_PREEMPT;
   mask        = RTEMS_PREEMPT_MASK;
-  note        = 8;
   timeout     = 100;
   signals     = RTEMS_SIGNAL_1 | RTEMS_SIGNAL_3;
   major       = 10;
@@ -251,36 +249,6 @@ rtems_task Task_1(
          0
       );
 
-/* rtems_task_get_note */
-
-      benchmark_timer_initialize();
-         for ( index = 1 ; index <= OPERATION_COUNT ; index ++ )
-            (void) rtems_task_get_note( id, 1, note );
-      end_time = benchmark_timer_read();
-
-      put_time(
-         "overhead: rtems_task_get_note",
-         end_time,
-         OPERATION_COUNT,
-         overhead,
-         0
-      );
-
-/* rtems_task_set_note */
-
-      benchmark_timer_initialize();
-         for ( index = 1 ; index <= OPERATION_COUNT ; index ++ )
-            (void) rtems_task_set_note( id, 1, note );
-      end_time = benchmark_timer_read();
-
-      put_time(
-         "overhead: rtems_task_set_note",
-         end_time,
-         OPERATION_COUNT,
-         overhead,
-         0
-      );
-
 /* rtems_task_wake_when */
 
       benchmark_timer_initialize();
diff --git a/testsuites/tmtests/tmoverhd/tmoverhd.doc b/testsuites/tmtests/tmoverhd/tmoverhd.doc
index dc326c2c32..8c1d97ed28 100644
--- a/testsuites/tmtests/tmoverhd/tmoverhd.doc
+++ b/testsuites/tmtests/tmoverhd/tmoverhd.doc
@@ -18,8 +18,6 @@ directives:
 + rtems task resume
 + rtems task set priority
 + rtems task mode
-+ rtems task get note
-+ rtems task set note
 + rtems task wake when
 + rtems task wake after
 + rtems interrupt catch
diff --git a/testsuites/tmtests/tmtests_plan.csv b/testsuites/tmtests/tmtests_plan.csv
index de3335b519..326a888a48 100644
--- a/testsuites/tmtests/tmtests_plan.csv
+++ b/testsuites/tmtests/tmtests_plan.csv
@@ -2,8 +2,6 @@
 "rtems_barrier_delete: only case",tm30,NA,Yes
 "rtems_barrier_ident: only case",tm30,NA,Yes
 ,,,
-"rtems_clock_get_tod: only case",tm08,NA,Yes
-"rtems_clock_set: only case",tm08,NA,Yes
 "rtems_clock_tick: only case",tm25,NA,Yes
 ,,,
 "rtems_event_receive: available",tm15,NA,Yes
@@ -124,12 +122,7 @@
 "rtems_task_delete: calling task",tm18,NA,Yes
 "rtems_task_delete: ready task",tm06,NA,Yes
 "rtems_task_delete: suspended task",tm04,NA,Yes
-"rtems_task_get_note: only case",tm08,NA,Yes
 "rtems_task_ident: only case",tm21,NA,Yes
-"rtems_task_mode: no reschedule",tm08,NA,Yes
-"rtems_task_mode: obtain current mode",tm08,NA,Yes
-"rtems_task_mode: reschedule returns to caller",tm08,NA,Yes
-"rtems_task_mode: reschedule",tm08,NA,Yes
 "rtems_task_restart: blocked task preempts caller",tm04,NA,Yes
 "rtems_task_restart: blocked task",tm04,NA,Yes
 "rtems_task_restart: calling task",tm06,NA,Yes
@@ -139,10 +132,7 @@
 "rtems_task_restart: suspended task",tm04,NA,Yes
 "rtems_task_resume: task readied preempts caller",tm05,NA,Yes
 "rtems_task_resume: task readied returns to caller",tm06,NA,Yes
-"rtems_task_set_note: only case",tm08,NA,Yes
-"rtems_task_set_priority: obtain current priority",tm08,NA,Yes
 "rtems_task_set_priority: preempts caller",tm17,NA,Yes
-"rtems_task_set_priority: returns to caller",tm08,NA,Yes
 "rtems_task_start: only case",tm04,NA,Yes
 "rtems_task_suspend: calling task",tm05,NA,Yes
 "rtems_task_suspend: returns to caller",tm06,NA,Yes