diff options
| author | Christian Mauderer <christian.mauderer@embedded-brains.de> | 2020-11-06 09:53:05 +0100 |
|---|---|---|
| committer | Christian Mauderer <christian.mauderer@embedded-brains.de> | 2020-11-20 08:56:40 +0100 |
| commit | 182aac377d7e345847d4dd11387ff549d27bd55d (patch) | |
| tree | f10300319a5a60c78be71c549ac88111a7186ae6 | |
| parent | 5cb414662757a0877784ad8882afd6968968334f (diff) | |
if_ffec: Fix cache handling on tx
With the previous fix, it could happen that the end of the packet hasn't
been flushed. For example assume the following addresses:
ds_addr: 0x81c804A
ds_len: 0x57
In that case the data ends at 0x81c80a1. But due to the rounding the
area from 0x81c8040 to 0x81c80a0 would have been flushed.
This fix now first calculates the start and end address, aligns these
addresses and then recalculates the len that has to be flushed.
Update #4180
| -rw-r--r-- | freebsd/sys/dev/ffec/if_ffec.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/freebsd/sys/dev/ffec/if_ffec.c b/freebsd/sys/dev/ffec/if_ffec.c index e8287ed2..47c0f770 100644 --- a/freebsd/sys/dev/ffec/if_ffec.c +++ b/freebsd/sys/dev/ffec/if_ffec.c @@ -714,15 +714,16 @@ ffec_encap(struct ifnet *ifp, struct ffec_softc *sc, struct mbuf *m0, tx_desc->buf_paddr = segs[i].ds_addr; tx_desc->flags2 = flags2; #ifdef __rtems__ - uintptr_t addr_flush = (uintptr_t)segs[i].ds_addr; + uintptr_t first_flush = (uintptr_t)segs[i].ds_addr; size_t len_flush = segs[i].ds_len; #ifdef CPU_CACHE_LINE_BYTES + uintptr_t last_flush = first_flush + len_flush; /* mbufs should be cache line aligned. So we can just round. */ - addr_flush = addr_flush & ~(CPU_CACHE_LINE_BYTES - 1); - len_flush = (len_flush + (CPU_CACHE_LINE_BYTES - 1)) & - ~(CPU_CACHE_LINE_BYTES - 1); + first_flush = rounddown2(first_flush, CPU_CACHE_LINE_BYTES); + last_flush = roundup2(last_flush, CPU_CACHE_LINE_BYTES); + len_flush = last_flush - first_flush; #endif - rtems_cache_flush_multiple_data_lines((void*)addr_flush, + rtems_cache_flush_multiple_data_lines((void*)first_flush, len_flush); #endif /* __rtems__ */ |