summaryrefslogtreecommitdiffstats
path: root/cpukit/libmisc/shell (follow)
Commit message (Collapse)AuthorAgeFilesLines
* main_edit.c: get rid of malloc warningRyan Long2021-06-091-8/+8
| | | | | | A warning was present when building RTEMS that stated that the argument for malloc() exceeded the maximum object size. To get rid of this, I changed many places where 'int' was being used to 'size_t'.
* main_help.c: Do not care what char is returned by getchar()Ryan Long2021-05-281-1/+1
| | | | | | CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291
* main_cp.c: Ignore return value from stat()Ryan Long2021-05-281-0/+6
| | | | | | CID 26051: Unchecked return value from library in main_cp(). Closes #4365
* main_rtrace.c: Add error return when malloc failsRyan Long2021-04-291-0/+1
| | | | | | | CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save(). Closes #4329
* print-ls.c: Unused value (CID #1255346)Ryan Long2021-04-081-0/+9
| | | | | | CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340
* main_cp.c: Unused value (CID #1255344)Ryan Long2021-04-081-0/+32
| | | | | | CID 1255344: Unused value in copy(). Closes #4339
* cpukit: Remove libnetworkingVijay Kumar Banerjee2021-04-074-2545/+0
| | | | Update #3850
* main_help.c: Unchecked return value from library (CID #1437650)Ryan Long2021-03-081-1/+2
| | | | | | CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291
* main_chmod.c: Fix Unchecked return value from library (CID #1063856)Ryan Long2021-03-081-2/+5
| | | | | | | CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281
* main_edit.c: Fix Unchecked return value (CID #1255318)Ryan Long2021-03-081-1/+1
| | | | | | CID 1255318: Unchecked return value in display_line(). Updates #4257
* shell.c: Fix Dereference before null check (CID #1467420)Ryan Long2021-02-181-1/+4
| | | | | | CID 1467420: Dereference before null check in rtems_shell_line_editor(). Closes #4254
* shell: Add i2c and spi commandsChristian Mauderer2020-12-144-0/+533
| | | | | | | | This adds some commands that are usefull for debugging simple serial interfaces. Even if they are a complete re-implementation, the i2c* commands use a simmilar call like the Linux i2c tools.
* shell: Rename "IO" typedef for better DoxygenSebastian Huber2020-12-023-6/+6
| | | | | An automatic link from every place in the documentation which mentions "IO" to this dd command internal "IO" typedef is not really nice.
* shell/main_edit.c: Fix string truncation warningFrank Kühndel2020-10-151-5/+7
| | | | | | | | | | | | Using strlcpy() instead of strncpy(): 1) Prevents the compiler warnings 2) Ensures, the string is NUL terminated. 3) Avoids that strncpy() unnecessary fills the unused part of the buffer with 0 bytes. (Note that realpath() also returns NULL if the file does not exist - that happens always if someone creates a new file with the editor of the shell.)
* shell/main_edit.c: Fix use of wrong constantFrank Kühndel2020-10-151-1/+2
| | | | | realpath() requires a buffer of size PATH_MAX and not of size FILENAME_MAX according to 'man realpath (3)'.
* shell/shell.c: Fix illegal string copyFrank Kühndel2020-10-151-4/+14
| | | | | | | | | | | | | This is an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The copiler warning was: ../../../cpukit/libmisc/shell/shell.c:626:13: warning: 'strcpy' accessing between 1 and 2147483645 bytes at offsets 0 and [1, 2147483647] may overlap up to 2147483644 bytes at offset [1, 2147483644] [-Wrestrict]
* shell/shell.c: Fix an implicit type castFrank Kühndel2020-10-151-1/+3
| | | | | With some compiler warnings enabled, the implicit cast may trigger a compiler warning. The explicit cast avoids this.
* shell: Remove not functioning fdisk mount/unmountFrank Kühndel2020-10-121-31/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix. The 'fdisk' command itself is not removed. The reasons for removing the sub-commands (instead of fixing the issue) are: 1) The bug has been introduced on 2010-May-31 with commit 29e92b090c8bc35745aa5c89231ce806bcb11e57. Since ten years no one can use this feature, nor has anybody complained about it. 2) Besides of the 'fdisk' 'mount' sub-command, the shell has the usual 'mount' and 'unmount' commands which can serve as substitutes. 3) There are additional minor issues (see further down) which needed to be addressed when the file will be kept. What follows below is the precise bug description. The bug is in function rtems_bdpart_mount() which is only be used by the 'fdisk' shell command to mount all partitions of a disk with a single command: > fdisk DISK_NAME mount > mounts the file system of each partition of the disk > > fdisk DISK_NAME unmount > unmounts the file system of each partition of the disk The whole command does not work because in file cpukit/libblock/src/bdpart-mount.c line 103 specifies the file system type of each partition to be "msdos". Yet, "msdos" does not exist. The name must be "dosfs". Beside of this fundamental problem, there are more issues with the code in bdpart-mount.c: 1) The function returns RTEMS_SUCCESSFUL despite the mount always fails. 2) The reason for errors is not written to the terminal. 3) The directory '/mnt' is created but not deleted later on (failure or not). 3) There is no documentation about this special 'fdisk' feature in the RTEMS Shell Guide ('fdisk' is mentioned but its documentation is a bit short): https://docs.rtems.org/branches/master/shell/ file_and_directory.html#fdisk-format-disk 4) Only "msdos" formatted partitions can be mounted and all partitions are mounted read-only. This is hard coded and cannot be changed by options. Moreover, there is no information about this to the user of the shell (i.e. using 'fdisk' mount requires insider knowledge). How to reproduce: 1) For testing, I use the 'testsuites/samples/fileio.exe' sample with qemu: > cd rtems > env QEMU_AUDIO_DRV="none" qemu-system-arm -net none -nographic \ > -M realview-pbx-a9 -m 256M -kernel \ > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe 2) Type any key to stop the timer and enter the sample tool. Type 's' to enter the shell, login as 'root' with the password shown in the terminal. 3) Type the following shell commands (they create a RAM disk, partition it, register it, format it and try to mount it): > mkrd > fdisk /dev/rda fat32 16 write mbr > fdisk /dev/rda register > mkdos /dev/rda1 > fdisk /dev/rda mount 4) The last line above is the command which fails - without an error message. There exists a '/mnt' directory but no '/mnt/rda1' directory as it should be: > ls -la /mnt 5) If you change line 103 of 'cpukit/libblock/src/bdpart-mount.c' from "msdos" to "dosfs", compile and build the executable and re-run the above test, '/mnt/rda1' exists (but the file system is mounted read-only). Close #4131
* Fixing bug in line editing of the shell with CTRL-U.Frank Kühndel2020-09-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes a tiny bug in the command line editing of the RTEMS shell. Typing CTRL-U in the shell should remove all characters left of the cursor. After pressing CTRL-U, the current implementation does wrongly place the cursor at the end of the line instead at its beginning. To reproduce the bug, start the shell and type 'abc123' (no <RETURN>): > ~/src/rtems $ qemu-system-arm -net none -nographic -M realview-pbx-a9 \ -m 256M -kernel build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl10.exe > *** BEGIN OF TEST libdl (RTL) 10 *** > *** TEST VERSION: 6.0.0.d9bdf166644f612dd628fe4951c12c6f8e94ba5f > *** TEST STATE: USER_INPUT > *** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API RTEMS_SMP > *** TEST TOOLS: 10.2.1 20200904 \ (RTEMS 6, RSB 31f936a7b74d60bda609a9960c6e1a705ba54974, Newlib a0d7982) > RTL (libdl) commands: dl, rtl > > RTEMS Shell on /dev/foobar. Use 'help' to list commands. > SHLL [/] # abc123 Then move the cursor onto the '1' by hitting three times the <ARROW-LEFT> key. Next type <CTRL>-U: > SHLL [/] # 123 Note that the cursor is at the end of the line (after '3') instead of correctly at the beginning (on the '1'), now. Continuing typing 'echo ' incorrectly results in the output: > SHLL [/] # 123echo 123 The patch changes this behavior so that the cursor in the second last step will be on the '1' and typing 'echo ' will then correctly reflected as: > SHLL [/] # echo 123 Close #4097.
* dd(1): Use a local swapbytes() function.eadler2020-08-201-1/+16
| | | | | | | swab(3) has restrict qualifiers for src and dst. Avoid relying on undefined overlapping swab behavior. Obtained From: OpenBSD
* shell: Only clear std handles when the shell task exitsChris Johns2020-08-081-4/+22
| | | | | Clearing the std file handles when the main loop exited crashes telnetd as it reuses its session threads.
* rtems: Add rtems_get_copyright_notice()Sebastian Huber2020-05-061-2/+12
| | | | Update #3973.
* Use rtems_get_version_string()Sebastian Huber2020-05-061-3/+3
| | | | Update #3970.
* doxygen: Switch @brief and @ingroupSebastian Huber2020-04-281-1/+2
| | | | This order change fixes the Latex documentation build via Doxygen.
* Canonicalize config.h includeSebastian Huber2020-04-169-16/+16
| | | | | | | | Use the following variant which was already used by most source files: #ifdef HAVE_CONFIG_H #include "config.h" #endif
* libmisc/shell: Fix the handling of joel scripts in telnetChris Johns2020-04-151-101/+268
| | | | | | | | | | | | - Fix the passing of std[in/out] to child threads - Fix deleting of managed memory in the key destructor - Only set the key in the main loop thread - Only allocate a shell env outside of the main loop - Fix memory leak if the task start fails - Remove error level from shell env, it cannot be returned this way. Add exit_code but the API is broken so it cannot be returned. Closes #3859
* Move feature macro before "config.h" includeSebastian Huber2019-11-194-9/+12
| | | | | | | This allows to use header includes in "config.h" to reduce the build configuration checks. Update #3818.
* shell: Avoid rtems_error()Sebastian Huber2019-05-141-9/+0
| | | | | | | Do not use the rtems_error() function since this function pulls in exit() and abort(). The abort() function pulls in raise() which pulls in the whole POSIX signals support. This change saves about 16KiB of text/rodata on ARM Thumb-2 systems.
* main_edit.c: Use strncpy() to eliminate potential buffer overflow.Joel Sherrill2019-03-141-4/+5
|
* Remove superfluous <rtems/system.h> includesSebastian Huber2019-03-144-4/+0
|
* shell: Correct argument order of `mfill`Jonathan Brandmeyer2019-03-081-1/+1
| | | | Close #3720.
* Fix format warnings due to ino_t changesSebastian Huber2019-01-102-4/+8
|
* Fix format warningsSebastian Huber2019-01-071-5/+9
|
* drvmgr: Improve LP64 compatibilitySebastian Huber2018-12-271-1/+2
|
* rtems: Deprecate region_information_blockSebastian Huber2018-11-091-1/+1
| | | | | | | The region_information_block typedef as no corresponding API. It has no proper namespace prefix. A user can do nothing with it. Close #3591.
* shell: Use #include "..." for local header filesSebastian Huber2018-10-0929-36/+36
| | | | Update #3375.
* Use rtems_task_exit()Sebastian Huber2018-10-021-1/+1
| | | | | Update #3530. Update #3533.
* shell: Fix rtems_shell_init_env()Sebastian Huber2018-03-121-1/+1
| | | | Do not discard a user provided task name in rtems_shell_init_env().
* Remove make preinstallChris Johns2018-01-252-939/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A speciality of the RTEMS build system was the make preinstall step. It copied header files from arbitrary locations into the build tree. The header files were included via the -Bsome/build/tree/path GCC command line option. This has at least seven problems: * The make preinstall step itself needs time and disk space. * Errors in header files show up in the build tree copy. This makes it hard for editors to open the right file to fix the error. * There is no clear relationship between source and build tree header files. This makes an audit of the build process difficult. * The visibility of all header files in the build tree makes it difficult to enforce API barriers. For example it is discouraged to use BSP-specifics in the cpukit. * An introduction of a new build system is difficult. * Include paths specified by the -B option are system headers. This may suppress warnings. * The parallel build had sporadic failures on some hosts. This patch removes the make preinstall step. All installed header files are moved to dedicated include directories in the source tree. Let @RTEMS_CPU@ be the target architecture, e.g. arm, powerpc, sparc, etc. Let @RTEMS_BSP_FAMILIY@ be a BSP family base directory, e.g. erc32, imx, qoriq, etc. The new cpukit include directories are: * cpukit/include * cpukit/score/cpu/@RTEMS_CPU@/include * cpukit/libnetworking The new BSP include directories are: * bsps/include * bsps/@RTEMS_CPU@/include * bsps/@RTEMS_CPU@/@RTEMS_BSP_FAMILIY@/include There are build tree include directories for generated files. The include directory order favours the most general header file, e.g. it is not possible to override general header files via the include path order. The "bootstrap -p" option was removed. The new "bootstrap -H" option should be used to regenerate the "headers.am" files. Update #3254.
* sparc: Remove <bsp.h> from PCI shell commandSebastian Huber2018-01-021-1/+0
| | | | | Update #3254. Update #3260.
* shell: Include <rtems/shell.h>Sebastian Huber2017-12-131-1/+1
| | | | | | Prepare for header file move to common include directory. Update #3254.
* shell: Fix missing prototype warningSebastian Huber2017-09-281-0/+1
|
* Include missing <limits.h>Sebastian Huber2017-08-253-0/+3
| | | | Update #2132.
* Include missing <string.h>Sebastian Huber2017-08-252-0/+2
| | | | Update #2133.
* heap: Fix integer typesSebastian Huber2017-08-221-3/+3
| | | | Update #3082.
* libmisc/shell: Make some internal shell functions public.Chris Johns2017-08-143-19/+35
| | | | | | | | | | - Add 'rtems_shell_init_environment()' so a user can create the shell environment without needing to run a shell. - Move 'rtems_shell_lookup_topic', 'rtems_shell_can_see_cmd', and 'rtems_shell_execute_cmd' from the internal interface to the public interface. Closes #3096.
* Do not include <sys/ioctl.h> in kernel-spaceSebastian Huber2017-06-071-0/+1
| | | | Update #2833.
* shell: Fix format specifiersSebastian Huber2017-05-021-3/+3
|
* rtems/inttypes.h: New file. Uses contents from cpukitJoel Sherrill2017-04-181-9/+1
| | | | | | | | Provide extentions to <inttpes.h> PRIxxx constants for more POSIX types. Start with existing definitions found in RTEMS Project owned code in cpukit/. updates #2983.
* shell: Fix warningsSebastian Huber2017-02-152-4/+8
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-23 18:41:24 +0000