summaryrefslogtreecommitdiffstats
path: root/cpukit/libmisc/shell (follow)
Commit message (Collapse)AuthorAgeFilesLines
* libmisc/shell: Work around tmux bug in row and columnChris Johns2023-12-131-25/+125
| | | | | | | | | - Extend the timeout to 150 msec for long remote sessions - Improve the performance of the detection Closes #4975 Closes #4977
* Update company nameSebastian Huber2023-05-2015-15/+15
| | | | | The embedded brains GmbH & Co. KG is the legal successor of embedded brains GmbH.
* libmisc/shell: Fix file pointer leak and improved input data sanitation.Aaron Nyholm2023-05-171-17/+10
| | | | | Coverity #1530126 Coverity #1530125
* libmisc/shell: Add flashdev commandAaron Nyholm2023-05-161-0/+591
|
* libmisc/shell/main_edit.c: User cannot cut using ctrl e and xzack2023-02-151-2/+1
| | | | Closes #4557
* shell/main_pci.c: Address Dereference after null error checkJoel Sherrill2023-02-101-1/+1
| | | | | | Coverity CID 1399716 Closes #431.
* libmisc/shell/edit: Return if no memory in move_gapChris Johns2023-01-311-0/+3
| | | | Closes #4835
* libmisc/shell/edit: Fix closing the editorChris Johns2023-01-311-11/+4
| | | | Closes #4834
* rtems_shell_main_chmod: Correct argument indexingzack leung2022-12-261-1/+1
| | | | Closes #4751
* rtems_shell_main_mmove problemzack leung2022-12-231-1/+1
| | | | | | | --0000000000006acec205efd38cd6 Content-Type: text/plain; charset="UTF-8" Closes #4556
* libmisc/shell: Fix edit Coverity errorChris Johns2022-11-251-1/+1
| | | | Coverity Id: CID 1517029, CID 1517030, CID 1517031
* libmisc/shell: Support terminal size as env variablesChris Johns2022-11-233-39/+155
| | | | Closes #4763
* cpukit: Change license to BSD-2 for files with Gaisler copyrightDaniel Cederman2022-11-142-6/+44
| | | | | | | | | This patch changes the license to BSD-2 for all source files where the copyright is held by Aeroflex Gaisler, Cobham Gaisler, or Gaisler Research. Some files also includes copyright right statements from OAR and/or embedded Brains in addition to Gaisler. Updates #3053.
* libmisc/shell: Add an 'rtems' command to report a running buildChris Johns2022-08-031-0/+156
| | | | - Report version, cpu, bsp, tools and options.
* cpukit: Fixes for GCC 12 warningsChris Johns2022-06-152-0/+6
| | | | Updates #6442
* cpukit/libmisc: Add file headers and licensesRyan Long2022-05-043-3/+90
| | | | | These files had no file header, copyright, or license. Based on git history, added appropriate copyright and license.
* shell: Add rtems_shell_run_main_loop()Sebastian Huber2022-04-061-0/+25
| | | | | | | In contrast to rtems_shell_main_loop(), this new function does not perform all sorts of initialization based on environment settings. For example, due to the use of isatty() in rtems_shell_main_loop() it is impossible to run an interactive shell through a socket connection.
* shell: Move rtems_shell_init_environment() callSebastian Huber2022-04-061-2/+2
| | | | | Move rtems_shell_init_environment() call to rtems_shell_set_shell_env() since this function uses the POSIX key.
* shell: Add and use SHELL_MAGICSebastian Huber2022-04-061-3/+5
|
* shell: Simplify rtems_shell_dup_current_env()Sebastian Huber2022-04-061-10/+7
| | | | Do not assign members already provided by the global environment.
* shell: Refactor rtems_shell_main_loop()Sebastian Huber2022-04-061-134/+150
| | | | | Disentangle the shell main loop from setup and teardown code. Move main loop into shell_main_loop().
* shell: Move line editor output checkSebastian Huber2022-04-061-44/+38
| | | | | Move call to isatty() to caller of rtems_shell_line_editor(). This avoids a dependency on isatty() in rtems_shell_line_editor().
* Update email address of Fernando Ruiz Casas to <fruizcasas@gmail.com>Joel Sherrill2022-04-0531-158/+211
| | | | This was requested to be executed prior to relicensing to BSD-2.
* shell: Avoid potential stack corruptionSebastian Huber2022-03-161-7/+1
| | | | | | | | | | | The rtems_shell_init() passed the address of a stack variable (exit_code) to rtems_shell_run(). If wait == false, then the stack variable goes out of scope but may be accessed by the created shell thread. The rtems_shell_script() was affected by the same problem. Close #4629.
* cpukit/: Scripted embedded brains header file clean upJoel Sherrill2022-03-1012-70/+1
| | | | Updates #4625.
* libmisc/shell: Check the shell command pointers when adding a commandChris Johns2021-08-211-0/+5
|
* main_edit.c: get rid of malloc warningRyan Long2021-06-091-8/+8
| | | | | | A warning was present when building RTEMS that stated that the argument for malloc() exceeded the maximum object size. To get rid of this, I changed many places where 'int' was being used to 'size_t'.
* main_help.c: Do not care what char is returned by getchar()Ryan Long2021-05-281-1/+1
| | | | | | CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291
* main_cp.c: Ignore return value from stat()Ryan Long2021-05-281-0/+6
| | | | | | CID 26051: Unchecked return value from library in main_cp(). Closes #4365
* main_rtrace.c: Add error return when malloc failsRyan Long2021-04-291-0/+1
| | | | | | | CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save(). Closes #4329
* print-ls.c: Unused value (CID #1255346)Ryan Long2021-04-081-0/+9
| | | | | | CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340
* main_cp.c: Unused value (CID #1255344)Ryan Long2021-04-081-0/+32
| | | | | | CID 1255344: Unused value in copy(). Closes #4339
* cpukit: Remove libnetworkingVijay Kumar Banerjee2021-04-074-2545/+0
| | | | Update #3850
* main_help.c: Unchecked return value from library (CID #1437650)Ryan Long2021-03-081-1/+2
| | | | | | CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291
* main_chmod.c: Fix Unchecked return value from library (CID #1063856)Ryan Long2021-03-081-2/+5
| | | | | | | CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281
* main_edit.c: Fix Unchecked return value (CID #1255318)Ryan Long2021-03-081-1/+1
| | | | | | CID 1255318: Unchecked return value in display_line(). Updates #4257
* shell.c: Fix Dereference before null check (CID #1467420)Ryan Long2021-02-181-1/+4
| | | | | | CID 1467420: Dereference before null check in rtems_shell_line_editor(). Closes #4254
* shell: Add i2c and spi commandsChristian Mauderer2020-12-144-0/+533
| | | | | | | | This adds some commands that are usefull for debugging simple serial interfaces. Even if they are a complete re-implementation, the i2c* commands use a simmilar call like the Linux i2c tools.
* shell: Rename "IO" typedef for better DoxygenSebastian Huber2020-12-023-6/+6
| | | | | An automatic link from every place in the documentation which mentions "IO" to this dd command internal "IO" typedef is not really nice.
* shell/main_edit.c: Fix string truncation warningFrank Kühndel2020-10-151-5/+7
| | | | | | | | | | | | Using strlcpy() instead of strncpy(): 1) Prevents the compiler warnings 2) Ensures, the string is NUL terminated. 3) Avoids that strncpy() unnecessary fills the unused part of the buffer with 0 bytes. (Note that realpath() also returns NULL if the file does not exist - that happens always if someone creates a new file with the editor of the shell.)
* shell/main_edit.c: Fix use of wrong constantFrank Kühndel2020-10-151-1/+2
| | | | | realpath() requires a buffer of size PATH_MAX and not of size FILENAME_MAX according to 'man realpath (3)'.
* shell/shell.c: Fix illegal string copyFrank Kühndel2020-10-151-4/+14
| | | | | | | | | | | | | This is an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The copiler warning was: ../../../cpukit/libmisc/shell/shell.c:626:13: warning: 'strcpy' accessing between 1 and 2147483645 bytes at offsets 0 and [1, 2147483647] may overlap up to 2147483644 bytes at offset [1, 2147483644] [-Wrestrict]
* shell/shell.c: Fix an implicit type castFrank Kühndel2020-10-151-1/+3
| | | | | With some compiler warnings enabled, the implicit cast may trigger a compiler warning. The explicit cast avoids this.
* shell: Remove not functioning fdisk mount/unmountFrank Kühndel2020-10-121-31/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix. The 'fdisk' command itself is not removed. The reasons for removing the sub-commands (instead of fixing the issue) are: 1) The bug has been introduced on 2010-May-31 with commit 29e92b090c8bc35745aa5c89231ce806bcb11e57. Since ten years no one can use this feature, nor has anybody complained about it. 2) Besides of the 'fdisk' 'mount' sub-command, the shell has the usual 'mount' and 'unmount' commands which can serve as substitutes. 3) There are additional minor issues (see further down) which needed to be addressed when the file will be kept. What follows below is the precise bug description. The bug is in function rtems_bdpart_mount() which is only be used by the 'fdisk' shell command to mount all partitions of a disk with a single command: > fdisk DISK_NAME mount > mounts the file system of each partition of the disk > > fdisk DISK_NAME unmount > unmounts the file system of each partition of the disk The whole command does not work because in file cpukit/libblock/src/bdpart-mount.c line 103 specifies the file system type of each partition to be "msdos". Yet, "msdos" does not exist. The name must be "dosfs". Beside of this fundamental problem, there are more issues with the code in bdpart-mount.c: 1) The function returns RTEMS_SUCCESSFUL despite the mount always fails. 2) The reason for errors is not written to the terminal. 3) The directory '/mnt' is created but not deleted later on (failure or not). 3) There is no documentation about this special 'fdisk' feature in the RTEMS Shell Guide ('fdisk' is mentioned but its documentation is a bit short): https://docs.rtems.org/branches/master/shell/ file_and_directory.html#fdisk-format-disk 4) Only "msdos" formatted partitions can be mounted and all partitions are mounted read-only. This is hard coded and cannot be changed by options. Moreover, there is no information about this to the user of the shell (i.e. using 'fdisk' mount requires insider knowledge). How to reproduce: 1) For testing, I use the 'testsuites/samples/fileio.exe' sample with qemu: > cd rtems > env QEMU_AUDIO_DRV="none" qemu-system-arm -net none -nographic \ > -M realview-pbx-a9 -m 256M -kernel \ > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe 2) Type any key to stop the timer and enter the sample tool. Type 's' to enter the shell, login as 'root' with the password shown in the terminal. 3) Type the following shell commands (they create a RAM disk, partition it, register it, format it and try to mount it): > mkrd > fdisk /dev/rda fat32 16 write mbr > fdisk /dev/rda register > mkdos /dev/rda1 > fdisk /dev/rda mount 4) The last line above is the command which fails - without an error message. There exists a '/mnt' directory but no '/mnt/rda1' directory as it should be: > ls -la /mnt 5) If you change line 103 of 'cpukit/libblock/src/bdpart-mount.c' from "msdos" to "dosfs", compile and build the executable and re-run the above test, '/mnt/rda1' exists (but the file system is mounted read-only). Close #4131
* Fixing bug in line editing of the shell with CTRL-U.Frank Kühndel2020-09-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes a tiny bug in the command line editing of the RTEMS shell. Typing CTRL-U in the shell should remove all characters left of the cursor. After pressing CTRL-U, the current implementation does wrongly place the cursor at the end of the line instead at its beginning. To reproduce the bug, start the shell and type 'abc123' (no <RETURN>): > ~/src/rtems $ qemu-system-arm -net none -nographic -M realview-pbx-a9 \ -m 256M -kernel build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl10.exe > *** BEGIN OF TEST libdl (RTL) 10 *** > *** TEST VERSION: 6.0.0.d9bdf166644f612dd628fe4951c12c6f8e94ba5f > *** TEST STATE: USER_INPUT > *** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API RTEMS_SMP > *** TEST TOOLS: 10.2.1 20200904 \ (RTEMS 6, RSB 31f936a7b74d60bda609a9960c6e1a705ba54974, Newlib a0d7982) > RTL (libdl) commands: dl, rtl > > RTEMS Shell on /dev/foobar. Use 'help' to list commands. > SHLL [/] # abc123 Then move the cursor onto the '1' by hitting three times the <ARROW-LEFT> key. Next type <CTRL>-U: > SHLL [/] # 123 Note that the cursor is at the end of the line (after '3') instead of correctly at the beginning (on the '1'), now. Continuing typing 'echo ' incorrectly results in the output: > SHLL [/] # 123echo 123 The patch changes this behavior so that the cursor in the second last step will be on the '1' and typing 'echo ' will then correctly reflected as: > SHLL [/] # echo 123 Close #4097.
* dd(1): Use a local swapbytes() function.eadler2020-08-201-1/+16
| | | | | | | swab(3) has restrict qualifiers for src and dst. Avoid relying on undefined overlapping swab behavior. Obtained From: OpenBSD
* shell: Only clear std handles when the shell task exitsChris Johns2020-08-081-4/+22
| | | | | Clearing the std file handles when the main loop exited crashes telnetd as it reuses its session threads.
* rtems: Add rtems_get_copyright_notice()Sebastian Huber2020-05-061-2/+12
| | | | Update #3973.
* Use rtems_get_version_string()Sebastian Huber2020-05-061-3/+3
| | | | Update #3970.
* doxygen: Switch @brief and @ingroupSebastian Huber2020-04-281-1/+2
| | | | This order change fixes the Latex documentation build via Doxygen.
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-25 13:49:32 +0000