summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* shell/main_edit.c: Fix use of wrong constantFrank Kühndel2020-10-151-1/+2
| | | | | realpath() requires a buffer of size PATH_MAX and not of size FILENAME_MAX according to 'man realpath (3)'.
* shell/shell.c: Fix illegal string copyFrank Kühndel2020-10-151-4/+14
| | | | | | | | | | | | | This is an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The copiler warning was: ../../../cpukit/libmisc/shell/shell.c:626:13: warning: 'strcpy' accessing between 1 and 2147483645 bytes at offsets 0 and [1, 2147483647] may overlap up to 2147483644 bytes at offset [1, 2147483644] [-Wrestrict]
* shell/shell.c: Fix an implicit type castFrank Kühndel2020-10-151-1/+3
| | | | | With some compiler warnings enabled, the implicit cast may trigger a compiler warning. The explicit cast avoids this.
* fsdosfsname01: Fix string truncation warningFrank Kühndel2020-10-151-6/+7
| | | | | | | | | | | | | | | This patch fixes a compiler warning: ../../../testsuites/fstests/fsdosfsname01/init.c:430:19: warning: '%s' directive output may be truncated writing up to 6424 bytes into a region of size 257 [-Wformat-truncation=] The buffer 'dirname' is exactly large enough so that no truncation can ever occur. Using the return value of snprintf() is an official supported way to suppress the warning. I considered the comment of Joel Sherrill about not replacing snprintf(): https://lists.rtems.org/pipermail/devel/2020-September/062113.html
* Remove *_Is_null() inline functionsSebastian Huber2020-10-1412-72/+16
| | | | Simply compare the values against NULL.
* rtems: Remove superfluous includeSebastian Huber2020-10-141-2/+0
|
* lpc32xx_mzx_stage_1-testsuite.tcfg: Add ttest01Joel Sherrill2020-10-121-0/+1
|
* lpc2362-testsuite.tcfg: Add monitor and psxmsgq01Joel Sherrill2020-10-121-0/+2
|
* lm3s3749-testsuite.tcfg: Add spcxx01Joel Sherrill2020-10-121-0/+1
|
* build: Move drivers without SMP supportSebastian Huber2020-10-122-15/+33
| | | | | | | | This fixes warnings like this: warning: implicit declaration of function 'rtems_interrupt_disable' warning: implicit declaration of function 'rtems_interrupt_enable' warning: implicit declaration of function 'rtems_interrupt_flash'
* build: Fix formatSebastian Huber2020-10-1210-16/+18
|
* testsuites/samples/fileio - Increase of stack sizeFrank Kühndel2020-10-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | When I use the 'shell' from the fileio sample with the command below: env QEMU_AUDIO_DRV="none" \ qemu-system-arm -no-reboot -net none -nographic -M realview-pbx-a9 \ -m 256M \ -kernel build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe The executable crashes with an "BLOWN STACK!!!" as soon as I try to login as 'root' with password. (The logins without password work fine.) Increasing the stack size of the affected thread a bit solves the issue. Hence, I suggest this patch. My config.ini was [arm/realview_pbx_a9_qemu] RTEMS_DEBUG = True RTEMS_NETWORKING = True RTEMS_POSIX_API = True RTEMS_SMP = True BUILD_TESTS = True RTEMS origin.master at a479686c112144119866391ceb21c48be6a3eca9 Close #4143
* shell: Remove not functioning fdisk mount/unmountFrank Kühndel2020-10-125-255/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix. The 'fdisk' command itself is not removed. The reasons for removing the sub-commands (instead of fixing the issue) are: 1) The bug has been introduced on 2010-May-31 with commit 29e92b090c8bc35745aa5c89231ce806bcb11e57. Since ten years no one can use this feature, nor has anybody complained about it. 2) Besides of the 'fdisk' 'mount' sub-command, the shell has the usual 'mount' and 'unmount' commands which can serve as substitutes. 3) There are additional minor issues (see further down) which needed to be addressed when the file will be kept. What follows below is the precise bug description. The bug is in function rtems_bdpart_mount() which is only be used by the 'fdisk' shell command to mount all partitions of a disk with a single command: > fdisk DISK_NAME mount > mounts the file system of each partition of the disk > > fdisk DISK_NAME unmount > unmounts the file system of each partition of the disk The whole command does not work because in file cpukit/libblock/src/bdpart-mount.c line 103 specifies the file system type of each partition to be "msdos". Yet, "msdos" does not exist. The name must be "dosfs". Beside of this fundamental problem, there are more issues with the code in bdpart-mount.c: 1) The function returns RTEMS_SUCCESSFUL despite the mount always fails. 2) The reason for errors is not written to the terminal. 3) The directory '/mnt' is created but not deleted later on (failure or not). 3) There is no documentation about this special 'fdisk' feature in the RTEMS Shell Guide ('fdisk' is mentioned but its documentation is a bit short): https://docs.rtems.org/branches/master/shell/ file_and_directory.html#fdisk-format-disk 4) Only "msdos" formatted partitions can be mounted and all partitions are mounted read-only. This is hard coded and cannot be changed by options. Moreover, there is no information about this to the user of the shell (i.e. using 'fdisk' mount requires insider knowledge). How to reproduce: 1) For testing, I use the 'testsuites/samples/fileio.exe' sample with qemu: > cd rtems > env QEMU_AUDIO_DRV="none" qemu-system-arm -net none -nographic \ > -M realview-pbx-a9 -m 256M -kernel \ > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe 2) Type any key to stop the timer and enter the sample tool. Type 's' to enter the shell, login as 'root' with the password shown in the terminal. 3) Type the following shell commands (they create a RAM disk, partition it, register it, format it and try to mount it): > mkrd > fdisk /dev/rda fat32 16 write mbr > fdisk /dev/rda register > mkdos /dev/rda1 > fdisk /dev/rda mount 4) The last line above is the command which fails - without an error message. There exists a '/mnt' directory but no '/mnt/rda1' directory as it should be: > ls -la /mnt 5) If you change line 103 of 'cpukit/libblock/src/bdpart-mount.c' from "msdos" to "dosfs", compile and build the executable and re-run the above test, '/mnt/rda1' exists (but the file system is mounted read-only). Close #4131
* cpukit/libmisc/monitor: Fix an illegal string copyFrank Kühndel2020-10-121-1/+2
| | | | | | | | | | | | This is actually an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The compiler warning was: ../../../cpukit/libmisc/monitor/mon-editor.c:342:15: warning: 'strcpy' accessing 1 byte at offsets [0, 75] and [0, 75] overlaps 1 byte at offset [0, 74] [-Wrestrict]
* psxndbm01 - Fixing string truncation warningFrank Kühndel2020-10-121-8/+3
| | | | | | | | | | | | | | | | | | | This fixes the following compiler warning: testsuites/psxtests/psxndbm01/init.c:221:3: warning: 'strncpy' output truncated before terminating nul copying 5 bytes from a string of the same length 221 | strncpy( test_strings, "Hello", 5 ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In addition, the comments from Sebastian Huber on an old version of such a patch have been taken into account: 1) The use of `sizeof()` in `key.dsize = sizeof( test_strings );` is wrong. 2) There is no need to allocate the string. One can simply use a string constant. (See https://lists.rtems.org/pipermail/devel/2020-August/061418.html)
* libblock: Fix sparse diskSebastian Huber2020-10-121-34/+35
| | | | | | | The qsort() in sparse_disk_get_new_block() may move the appended key which invalidates the pointer. Close #4142.
* rtems: Generate <rtems/io.h>Sebastian Huber2020-10-111-114/+369
| | | | | | | | | | | | | The manager documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. This header file was generated from the items by a script. Change license to BSD-2-Clause according to file histories and documentation re-licensing agreement. Update #3899. Update #3993.
* libblock: Add commentSebastian Huber2020-10-111-0/+2
|
* mghttpd/mongoose: Fix string truncation warningFrank Kühndel2020-10-101-2/+2
| | | | | | | | This fixes the compiler warning below. ../../../cpukit/mghttpd/mongoose.c:1919:45: warning: '.gz' directive output may be truncated writing 3 bytes into a region of size between 1 and 255 [-Wformat-truncation=]
* libblock: Fix string truncation warningFrank Kühndel2020-10-101-1/+1
| | | | | | | | | | | This patch does not only fix the compiler warning below. memcpy() is the better function at this place as the terminating NUL character is never copied here. Instead more characters will be appended to the 'logical_disk_name' later on. ../../../cpukit/libblock/src/bdpart-register.c:41:5: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
* disp_hcms29xx: Fix string truncation warningFrank Kühndel2020-10-101-4/+3
| | | | | | The strlcpy() function ensures there is always a NUL character at the end of the string. Hence it is safer as strncpy() and it avoids the compiler warning
* testsuits/dl10 : Prototype missingFrank Kühndel2020-10-101-0/+1
| | | | | | | | | | | | | Fix a compiler warning about a missing prototype. If you wonder why the function name is not `static`: The code in the file only serves a test where the dynamic object loader (aka dlopen()) should handle duplicated symbols in an archive. testsuites/libtests/dl10/dl10-o6.c:14:5: warning: no previous prototype for 'rtems_main_o5' [-Wmissing-prototypes] 14 | int rtems_main_o5 (void) | ^~~~~~~~~~~~~
* capture: Fix unaligned pointer value warningFrank Kühndel2020-10-101-4/+4
| | | | | | | | | | | | | | rtems_name is a four byte integer. Giving an rtems_name as value instead of a pointer to ctrace_task_name_add() fixes not only the compiler warning but it is also a bit more safe For those who have asked for the warning: ../../../cpukit/libmisc/capture/capture_support.c:352:49: warning: taking address of packed member of 'struct rtems_capture_task_record' may result in an unaligned pointer value [-Waddress-of-packed-member] 352 | ctrace_task_name_add (rec_out->task_id, &task_rec.name); | ^~~~~~~~~~~~~~
* build: Add test excludes for RTEMS_PROFILINGSebastian Huber2020-10-105-0/+9
|
* build: Add test excludes for rcxx01Sebastian Huber2020-10-109-0/+9
|
* rtems: Improve RTEMS_NO_RETURN attributeSebastian Huber2020-10-1031-92/+52
| | | | | | | | | | | Provide RTEMS_NO_RETURN also in case RTEMS_DEBUG is defined to prevent errors like this: error: no return statement in function returning non-void [-Werror=return-type] Use C11 and C++11 standard means to declare a no-return function. Close #4122.
* grlib: Add and use irqmp_has_timestamp()Sebastian Huber2020-10-106-12/+14
| | | | | | | Replace leon3_irqmp_has_timestamp() with irqmp_has_timestamp() and move it to grlib.h. Close #4128.
* build: Fix legacy Makefile supportSebastian Huber2020-10-102-4/+3
| | | | Close #4140.
* testsuite/rcxx01: Add examples for use in the User manualChris Johns2020-10-096-5/+248
|
* librtemscxx: Fix white space to match the coding standardChris Johns2020-10-094-208/+208
|
* librtemscxx: Add join() and detach() to the threadChris Johns2020-10-093-14/+43
| | | | - Do not start threads detached
* bsps/include/bsp/fatal.h: Add GRLIB specific fatal errorJoel Sherrill2020-10-081-1/+4
| | | | updates #4028.
* librtemscxx: Fix installSebastian Huber2020-10-081-3/+3
|
* validation: Improve file header commentSebastian Huber2020-10-083-15/+29
|
* doxygen: Add "Generated from ..." commentsSebastian Huber2020-10-081-4/+339
| | | | | | Improve file header comment. Update #3994.
* rtems: Add "Generated from ..." commentsSebastian Huber2020-10-081-4/+13
| | | | | | Improve file header comment. Update #3993.
* build: Disable RTEMS_NETWORKING for some arch/bspSebastian Huber2020-10-081-1/+12
| | | | The old network stack is not supported on 64-bit targets.
* cpukit/librcxx: Add a C++ thread interface with attributesChris Johns2020-10-0812-0/+1312
|
* Misc: Correct spelling of occurredJoel Sherrill2020-10-073-3/+3
|
* rtems: Add RTEMS_PARTITION_ALIGNMENTSebastian Huber2020-10-073-9/+19
| | | | Update #4105.
* build: Fix BSP nameSebastian Huber2020-10-071-1/+1
| | | | Update #3818.
* build: Remove raspberrypi from RTEMS_SMPSebastian Huber2020-10-071-1/+0
| | | | Close #4116.
* build: Add test excludes for RTEMS_DEBUGSebastian Huber2020-10-062-0/+2
|
* bsps: Add Cortex-A53 ILP32 BSP variantKinsey Moore2020-10-054-1/+112
| | | | | | This adds an AArch64 ILP32 BSP variant based on Qemu's Cortex-A53 emulation with interrupt support using GICv3 and clock support using the ARM GPT.
* bsps: Add Cortex-A53 LP64 basic BSPKinsey Moore2020-10-0525-0/+2478
| | | | | This adds an AArch64 basic BSP based on Qemu's Cortex-A53 emulation with interrupt support using GICv3 and clock support using the ARM GPT.
* score: Add AArch64 portKinsey Moore2020-10-0519-1/+2794
| | | | | This adds a CPU port for AArch64(ARMv8) with support for exceptions and interrupts.
* spmsgq_err01: Use correct max values and fix 64bitKinsey Moore2020-10-051-3/+3
| | | | | Fix spmsgq_err01 on systems with 64-bit pointers and correct max value mismatches and inaccuracies that are more noticable on 64-bit systems.
* bsps/shared: Add PSCI-based bspreset implementationKinsey Moore2020-10-051-0/+56
| | | | | This adds a bsp_reset implementation based on the ARM PSCI specification often present in ARMv8 systems.
* bsps: Break out AArch32 GICv3 supportKinsey Moore2020-10-0523-73/+183
| | | | | This breaks out AArch32-specific code so that the shared GICv3 code can be reused by other architectures.
* bsps: Break out AArch32 portions of GPT driverKinsey Moore2020-10-0518-52/+189
| | | | | | This breaks AArch32-specific portions of the ARM GPT driver into their own file so that the generic code can be moved for reuse by other architectures.
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-22 02:54:30 +0000