Rename is_internal to always_set_to_false

Update #2825.

23 files changed, 51 insertions, 47 deletions

diff --git a/testsuites/libtests/exit01/init.c b/testsuites/libtests/exit01/init.c
index b677c3aab9..0fd8d356f0 100644
--- a/testsuites/libtests/exit01/init.c
+++ b/testsuites/libtests/exit01/init.c
@@ -52,13 +52,13 @@ static void atexit_2(void)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
   if (
     source == RTEMS_FATAL_SOURCE_EXIT
-      && !is_internal
+      && !always_set_to_false
       && error == EXIT_STATUS
       && counter == 3
   ) {
diff --git a/testsuites/libtests/exit02/init.c b/testsuites/libtests/exit02/init.c
index f185d0f72e..48248a569a 100644
--- a/testsuites/libtests/exit02/init.c
+++ b/testsuites/libtests/exit02/init.c
@@ -37,13 +37,13 @@ static void atexit_not_reached(void)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
   if (
     source == RTEMS_FATAL_SOURCE_EXIT
-      && !is_internal
+      && !always_set_to_false
       && error == EXIT_STATUS
   ) {
     TEST_END();
diff --git a/testsuites/libtests/stackchk/init.c b/testsuites/libtests/stackchk/init.c
index 4e1e41cdfb..72e3c23731 100644
--- a/testsuites/libtests/stackchk/init.c
+++ b/testsuites/libtests/stackchk/init.c
@@ -90,13 +90,13 @@ rtems_task Init(
 
 void Fatal_extension(
   rtems_fatal_source source,
-  bool               is_internal,
+  bool               always_set_to_false,
   rtems_fatal_code   error
 )
 {
   if ( source != RTEMS_FATAL_SOURCE_STACK_CHECKER ) {
     printk( "unexpected fatal source\n" );
-  } else if ( is_internal ) {
+  } else if ( always_set_to_false ) {
     printk( "unexpected fatal is internal\n" );
   } else if ( error != rtems_build_name( 'T', 'A', '1', ' ' ) ) {
     printk( "unexpected fatal error\n" );
diff --git a/testsuites/libtests/stackchk/system.h b/testsuites/libtests/stackchk/system.h
index 96f56fb22d..225a5d3155 100644
--- a/testsuites/libtests/stackchk/system.h
+++ b/testsuites/libtests/stackchk/system.h
@@ -44,7 +44,7 @@ void blow_stack( void );
 
 void Fatal_extension(
   rtems_fatal_source source,
-  bool               is_internal,
+  bool               always_set_to_false,
   rtems_fatal_code   error
 );
 
diff --git a/testsuites/psxtests/psxfatal_support/init.c b/testsuites/psxtests/psxfatal_support/init.c
index bc48b95cb0..d639d17d3d 100644
--- a/testsuites/psxtests/psxfatal_support/init.c
+++ b/testsuites/psxtests/psxfatal_support/init.c
@@ -62,7 +62,7 @@ void Put_Source( rtems_fatal_source source )
 
 void Fatal_extension(
   rtems_fatal_source source,
-  bool               is_internal,
+  bool               always_set_to_false,
   rtems_fatal_code   error
 )
 {
@@ -77,7 +77,7 @@ void Fatal_extension(
     printk( ")\n" );
   }
 
-  if ( is_internal )
+  if ( always_set_to_false )
     printk( "ERROR==> Fatal Extension is internal set to true expected false\n" );
 
   if ( error !=  FATAL_ERROR_EXPECTED_ERROR ) {
@@ -90,7 +90,7 @@ void Fatal_extension(
 
   if (
     source == FATAL_ERROR_EXPECTED_SOURCE
-      && !is_internal
+      && !always_set_to_false
       && error == FATAL_ERROR_EXPECTED_ERROR
   ) {
     TEST_END();
diff --git a/testsuites/psxtests/psxfatal_support/system.h b/testsuites/psxtests/psxfatal_support/system.h
index 4a6e5d9d9c..c825a4a252 100644
--- a/testsuites/psxtests/psxfatal_support/system.h
+++ b/testsuites/psxtests/psxfatal_support/system.h
@@ -36,7 +36,7 @@ void *POSIX_Init(
 
 void Fatal_extension(
   rtems_fatal_source source,
-  bool               is_internal,
+  bool               always_set_to_false,
   rtems_fatal_code   error
 );
 
diff --git a/testsuites/smptests/smpfatal01/init.c b/testsuites/smptests/smpfatal01/init.c
index e7f15973c5..457469f1b2 100644
--- a/testsuites/smptests/smpfatal01/init.c
+++ b/testsuites/smptests/smpfatal01/init.c
@@ -42,7 +42,7 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -51,7 +51,7 @@ static void fatal_extension(
   if (source == RTEMS_FATAL_SOURCE_SMP) {
     uint32_t self = rtems_get_current_processor();
 
-    assert(!is_internal);
+    assert(!always_set_to_false);
     assert(code == SMP_FATAL_SHUTDOWN);
 
     if (self == main_cpu) {
diff --git a/testsuites/smptests/smpfatal02/init.c b/testsuites/smptests/smpfatal02/init.c
index ae075ec694..3aa20e3dcf 100644
--- a/testsuites/smptests/smpfatal02/init.c
+++ b/testsuites/smptests/smpfatal02/init.c
@@ -42,14 +42,14 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
   SMP_barrier_State barrier_state = SMP_BARRIER_STATE_INITIALIZER;
   uint32_t self = rtems_get_current_processor();
 
-  assert(!is_internal);
+  assert(!always_set_to_false);
 
   if ( source == RTEMS_FATAL_SOURCE_APPLICATION ) {
     uint32_t cpu;
diff --git a/testsuites/smptests/smpfatal03/init.c b/testsuites/smptests/smpfatal03/init.c
index 9f7c6824ed..47f8598387 100644
--- a/testsuites/smptests/smpfatal03/init.c
+++ b/testsuites/smptests/smpfatal03/init.c
@@ -67,13 +67,13 @@ static void Init( rtems_task_argument arg )
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
   if (
     source == INTERNAL_ERROR_CORE
-      && !is_internal
+      && !always_set_to_false
       && code == INTERNAL_ERROR_THREAD_QUEUE_ENQUEUE_STICKY_FROM_BAD_STATE
   ) {
     TEST_END();
diff --git a/testsuites/smptests/smpfatal04/init.c b/testsuites/smptests/smpfatal04/init.c
index ebfa849dbd..e8b43d7d52 100644
--- a/testsuites/smptests/smpfatal04/init.c
+++ b/testsuites/smptests/smpfatal04/init.c
@@ -34,7 +34,7 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -42,7 +42,7 @@ static void fatal_extension(
 
   if (
     source == RTEMS_FATAL_SOURCE_SMP
-      && !is_internal
+      && !always_set_to_false
       && code == SMP_FATAL_BOOT_PROCESSOR_NOT_ASSIGNED_TO_SCHEDULER
   ) {
     TEST_END();
diff --git a/testsuites/smptests/smpfatal05/init.c b/testsuites/smptests/smpfatal05/init.c
index 1e1e535863..506a62e99b 100644
--- a/testsuites/smptests/smpfatal05/init.c
+++ b/testsuites/smptests/smpfatal05/init.c
@@ -34,7 +34,7 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -42,7 +42,7 @@ static void fatal_extension(
 
   if (
     source == RTEMS_FATAL_SOURCE_SMP
-      && !is_internal
+      && !always_set_to_false
       && code == SMP_FATAL_MANDATORY_PROCESSOR_NOT_PRESENT
   ) {
     TEST_END();
diff --git a/testsuites/smptests/smpfatal06/init.c b/testsuites/smptests/smpfatal06/init.c
index f871112b1a..0e363d1f5f 100644
--- a/testsuites/smptests/smpfatal06/init.c
+++ b/testsuites/smptests/smpfatal06/init.c
@@ -36,13 +36,13 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
   if (
     source == INTERNAL_ERROR_CORE
-      && !is_internal
+      && !always_set_to_false
       && code == INTERNAL_ERROR_BAD_THREAD_DISPATCH_ENVIRONMENT
   ) {
     TEST_END();
diff --git a/testsuites/smptests/smpfatal08/init.c b/testsuites/smptests/smpfatal08/init.c
index 4b7aaf5156..ee1f94c51e 100644
--- a/testsuites/smptests/smpfatal08/init.c
+++ b/testsuites/smptests/smpfatal08/init.c
@@ -91,7 +91,7 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -99,7 +99,7 @@ static void fatal_extension(
 
   if (
     source == RTEMS_FATAL_SOURCE_SMP
-      && !is_internal
+      && !always_set_to_false
       && code == SMP_FATAL_START_OF_MANDATORY_PROCESSOR_FAILED
   ) {
     TEST_END();
diff --git a/testsuites/sptests/sperror01/init.c b/testsuites/sptests/sperror01/init.c
index a84eaf9293..fe3f304e1d 100644
--- a/testsuites/sptests/sperror01/init.c
+++ b/testsuites/sptests/sperror01/init.c
@@ -25,13 +25,13 @@ rtems_task Init(rtems_task_argument argument);
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
   if (
     source == RTEMS_FATAL_SOURCE_EXIT
-      && !is_internal
+      && !always_set_to_false
       && error == ENOMEM
   ) {
     TEST_END();
diff --git a/testsuites/sptests/sperror02/init.c b/testsuites/sptests/sperror02/init.c
index 0bb7ceaf34..67fc56da40 100644
--- a/testsuites/sptests/sperror02/init.c
+++ b/testsuites/sptests/sperror02/init.c
@@ -25,13 +25,13 @@ rtems_task Init(rtems_task_argument argument);
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
   if (
     source == RTEMS_FATAL_SOURCE_EXIT
-      && !is_internal
+      && !always_set_to_false
       && error == 1
   ) {
     TEST_END();
diff --git a/testsuites/sptests/sperror03/init.c b/testsuites/sptests/sperror03/init.c
index aecdb79288..448848da08 100644
--- a/testsuites/sptests/sperror03/init.c
+++ b/testsuites/sptests/sperror03/init.c
@@ -22,13 +22,13 @@ rtems_task Init(rtems_task_argument argument);
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
   if (
     source == RTEMS_FATAL_SOURCE_EXIT
-      && !is_internal
+      && !always_set_to_false
       && error == 0
   ) {
     TEST_END();
diff --git a/testsuites/sptests/spextensions01/init.c b/testsuites/sptests/spextensions01/init.c
index 1d682557c7..ceb9f60527 100644
--- a/testsuites/sptests/spextensions01/init.c
+++ b/testsuites/sptests/spextensions01/init.c
@@ -142,7 +142,7 @@ static void zero_thread_exitted(rtems_tcb *a)
 
 static void zero_fatal(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -201,7 +201,7 @@ static void one_thread_exitted(rtems_tcb *a)
 
 static void one_fatal(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -260,7 +260,7 @@ static void two_thread_exitted(rtems_tcb *a)
 
 static void two_fatal(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
@@ -321,7 +321,7 @@ static void three_thread_exitted(rtems_tcb *a)
 
 static void three_fatal(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
diff --git a/testsuites/sptests/spfatal26/init.c b/testsuites/sptests/spfatal26/init.c
index 4013b948fc..7d204389b8 100644
--- a/testsuites/sptests/spfatal26/init.c
+++ b/testsuites/sptests/spfatal26/init.c
@@ -61,12 +61,12 @@ static void Init( rtems_task_argument arg )
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code code
 )
 {
   rtems_test_assert( source == RTEMS_FATAL_SOURCE_EXCEPTION );
-  rtems_test_assert( !is_internal );
+  rtems_test_assert( !always_set_to_false );
 
   rtems_exception_frame_print( (const rtems_exception_frame *) code );
 
diff --git a/testsuites/sptests/spfatal_support/init.c b/testsuites/sptests/spfatal_support/init.c
index aa49a301ee..f9b2ed37c1 100644
--- a/testsuites/sptests/spfatal_support/init.c
+++ b/testsuites/sptests/spfatal_support/init.c
@@ -65,7 +65,7 @@ static bool is_expected_error( rtems_fatal_code error )
 
 void Fatal_extension(
   rtems_fatal_source source,
-  bool               is_internal,
+  bool               always_set_to_false,
   rtems_fatal_code   error
 )
 {
@@ -80,7 +80,7 @@ void Fatal_extension(
     printk( ")\n" );
   }
 
-  if ( is_internal )
+  if ( always_set_to_false )
     printk(
       "ERROR==> Fatal Extension is internal set to true expected false\n"
     );
@@ -97,7 +97,7 @@ void Fatal_extension(
 
   if (
     source == FATAL_ERROR_EXPECTED_SOURCE
-      && !is_internal
+      && !always_set_to_false
       && is_expected_error( error )
   ) {
     TEST_END();
diff --git a/testsuites/sptests/spfatal_support/system.h b/testsuites/sptests/spfatal_support/system.h
index 0a01e21d70..ee32428352 100644
--- a/testsuites/sptests/spfatal_support/system.h
+++ b/testsuites/sptests/spfatal_support/system.h
@@ -28,7 +28,7 @@ rtems_task Init(
 
 void Fatal_extension(
   rtems_fatal_source source,
-  bool               is_internal,
+  bool               always_set_to_false,
   rtems_fatal_code   error
 );
 
diff --git a/testsuites/sptests/spinternalerror01/init.c b/testsuites/sptests/spinternalerror01/init.c
index 6201aff566..21e42e358b 100644
--- a/testsuites/sptests/spinternalerror01/init.c
+++ b/testsuites/sptests/spinternalerror01/init.c
@@ -35,13 +35,17 @@ void boot_card( const char *cmdline )
 
 static void fatal_extension(
   Internal_errors_Source source,
-  bool is_internal,
+  bool always_set_to_false,
   Internal_errors_t error
 )
 {
   TEST_BEGIN();
 
-  if ( source == FATAL_SOURCE && !is_internal && error == FATAL_ERROR ) {
+  if (
+    source == FATAL_SOURCE
+      && !always_set_to_false
+      && error == FATAL_ERROR
+  ) {
     TEST_END();
   }
 }
diff --git a/testsuites/sptests/spmutex01/init.c b/testsuites/sptests/spmutex01/init.c
index 72e458f167..0c216a3901 100644
--- a/testsuites/sptests/spmutex01/init.c
+++ b/testsuites/sptests/spmutex01/init.c
@@ -689,14 +689,14 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
 
   if (
     source == INTERNAL_ERROR_CORE
-      && !is_internal
+      && !always_set_to_false
       && error == INTERNAL_ERROR_THREAD_QUEUE_DEADLOCK
   ) {
     test_context *ctx = &test_instance;
diff --git a/testsuites/sptests/spsyslock01/init.c b/testsuites/sptests/spsyslock01/init.c
index 1e0d481873..815579a0d9 100644
--- a/testsuites/sptests/spsyslock01/init.c
+++ b/testsuites/sptests/spsyslock01/init.c
@@ -686,14 +686,14 @@ static void Init(rtems_task_argument arg)
 
 static void fatal_extension(
   rtems_fatal_source source,
-  bool is_internal,
+  bool always_set_to_false,
   rtems_fatal_code error
 )
 {
 
   if (
     source == INTERNAL_ERROR_CORE
-      && !is_internal
+      && !always_set_to_false
       && error == INTERNAL_ERROR_THREAD_QUEUE_DEADLOCK
   ) {
     test_context *ctx = &test_instance;