summaryrefslogtreecommitdiffstats
path: root/testsuites/sptests/sp07
diff options
context:
space:
mode:
authorAun-Ali Zaidi <admin@kodeit.net>2015-12-23 14:44:02 -0600
committerJoel Sherrill <joel.sherrill@oarcorp.com>2015-12-24 16:52:34 -0600
commitd5154d0f6a04f3b7ed59d9a09038576fe2640756 (patch)
tree4b6dcf6e9b116223903afbc1b1141d28fb751848 /testsuites/sptests/sp07
parentscore: Fix watchdog removal (diff)
downloadrtems-d5154d0f6a04f3b7ed59d9a09038576fe2640756.tar.bz2
api: Remove deprecated Notepads
Notepads where a feature of RTEMS' tasks that simply functioned in the same way as POSIX keys or threaded local storage (TLS). They were introduced well before per task variables, which are also deprecated, and were barely used in favor of their POSIX alternatives. In addition to their scarce usage, Notepads took up unnecessary memory. For each task: - 16 32-bit integers were allocated. - A total of 64 bytes per task per thread. This is especially critical in low memory and safety-critical applications. They are also defined as uint32_t, and therefore are not guaranteed to hold a pointer. Lastly, they are not portable solutions for SMP and uniprocessor systems, like POSIX keys and TLS. updates #2493.
Diffstat (limited to 'testsuites/sptests/sp07')
-rw-r--r--testsuites/sptests/sp07/init.c18
-rw-r--r--testsuites/sptests/sp07/sp07.scn9
-rw-r--r--testsuites/sptests/sp07/system.h2
-rw-r--r--testsuites/sptests/sp07/task1.c16
-rw-r--r--testsuites/sptests/sp07/task2.c17
5 files changed, 0 insertions, 62 deletions
diff --git a/testsuites/sptests/sp07/init.c b/testsuites/sptests/sp07/init.c
index 0211a94e3a..d5b606d12a 100644
--- a/testsuites/sptests/sp07/init.c
+++ b/testsuites/sptests/sp07/init.c
@@ -210,24 +210,6 @@ rtems_task Init(
directive_failed( status, "rtems_task_restart of TA3" );
assert_extension_counts( &Task_restarted[ 0 ], 0x0 );
- /*
- * We know this is deprecated and don't want a warning on every BSP built.
- */
- #pragma GCC diagnostic push
- #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-
- status = rtems_task_set_note( Task_id[ 1 ], RTEMS_NOTEPAD_8, 4 );
- directive_failed( status, "task_set_node of TA1" );
- printf( "INIT - rtems_task_set_note - set TA1's RTEMS_NOTEPAD_8 " );
- puts ( "to TA1's priority: 04" );
-
- status = rtems_task_set_note( Task_id[ 2 ], RTEMS_NOTEPAD_8, 4 );
- directive_failed( status, "task_set_node of TA2" );
- printf( "INIT - rtems_task_set_note - set TA2's RTEMS_NOTEPAD_8 " );
- puts ( "to TA2's priority: 04");
-
- #pragma GCC diagnostic pop
-
status = rtems_task_delete( RTEMS_SELF );
directive_failed( status, "rtems_task_delete of RTEMS_SELF" );
}
diff --git a/testsuites/sptests/sp07/sp07.scn b/testsuites/sptests/sp07/sp07.scn
index 77a9b24521..414b46754e 100644
--- a/testsuites/sptests/sp07/sp07.scn
+++ b/testsuites/sptests/sp07/sp07.scn
@@ -10,20 +10,11 @@ rtems_extension_ident -- OK
rtems_extension_ident - bad name -- RTEMS_INVALID_NAME
rtems_extension_ident - bad name -- RTEMS_INVALID_ADDRESS
rtems_extension_create - harmless -- OK
-INIT - rtems_task_set_note - set TA1's RTEMS_NOTEPAD_8 to TA1's priority: 04
-INIT - rtems_task_set_note - set TA2's RTEMS_NOTEPAD_8 to TA2's priority: 04
<pause>
TA1 - rtems_task_set_priority - get initial priority of self: 04
-TA1 - rtems_task_get_note - get RTEMS_NOTEPAD_8 - current priority: 04
-TA1 - rtems_task_set_note - set TA2's RTEMS_NOTEPAD_8: 03
TA1 - rtems_task_set_priority - set TA2's priority: 03
-TA2 - rtems_task_get_note - get RTEMS_NOTEPAD_8 - current priority: 03
-TA2 - rtems_task_set_note - set TA1's RTEMS_NOTEPAD_8: 02
TA2 - rtems_task_set_priority - set TA1's priority: 02
-TA1 - rtems_task_get_note - get RTEMS_NOTEPAD_8 - current priority: 02
-TA1 - rtems_task_set_note - set TA2's RTEMS_NOTEPAD_8: 01
TA1 - rtems_task_set_priority - set TA2's priority: 01
-TA2 - rtems_task_get_note - get RTEMS_NOTEPAD_8 - current priority: 01
TA2 - rtems_task_suspend - suspend TA1
TA2 - rtems_task_set_priority - set priority of TA1 ( blocked )
TA4 - exitting task
diff --git a/testsuites/sptests/sp07/system.h b/testsuites/sptests/sp07/system.h
index c5374553d5..8bea0fb7f5 100644
--- a/testsuites/sptests/sp07/system.h
+++ b/testsuites/sptests/sp07/system.h
@@ -64,8 +64,6 @@ void Task_exit_extension(
#define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
#define CONFIGURE_APPLICATION_NEEDS_CLOCK_DRIVER
-#define CONFIGURE_ENABLE_CLASSIC_API_NOTEPADS
-
#define CONFIGURE_MAXIMUM_USER_EXTENSIONS 2
#define CONFIGURE_TICKS_PER_TIMESLICE 100
diff --git a/testsuites/sptests/sp07/task1.c b/testsuites/sptests/sp07/task1.c
index 18c6375473..c03bea24b4 100644
--- a/testsuites/sptests/sp07/task1.c
+++ b/testsuites/sptests/sp07/task1.c
@@ -44,14 +44,6 @@ rtems_task Task_1(
);
while( FOREVER ) {
- status = rtems_task_get_note( my_id, RTEMS_NOTEPAD_8, &the_priority );
- directive_failed( status, "rtems_task_get_note" );
- printf(
- "TA1 - rtems_task_get_note - get RTEMS_NOTEPAD_8 - "
- "current priority: %02" PRIdrtems_task_priority "\n",
- the_priority
- );
-
if ( --the_priority == 0 ) {
puts( "TA1 - rtems_task_suspend - suspend TA2" );
status = rtems_task_suspend( Task_id[ 2 ] );
@@ -69,14 +61,6 @@ rtems_task Task_1(
}
printf(
- "TA1 - rtems_task_set_note - set TA2's RTEMS_NOTEPAD_8: "
- "%02" PRIdrtems_task_priority "\n",
- the_priority
- );
- status = rtems_task_set_note( Task_id[ 2 ], RTEMS_NOTEPAD_8, the_priority );
- directive_failed( status, "rtems_task_set_note" );
-
- printf(
"TA1 - rtems_task_set_priority - set TA2's priority: "
"%02" PRIdrtems_task_priority "\n",
the_priority
diff --git a/testsuites/sptests/sp07/task2.c b/testsuites/sptests/sp07/task2.c
index 11165ee73b..4254a94710 100644
--- a/testsuites/sptests/sp07/task2.c
+++ b/testsuites/sptests/sp07/task2.c
@@ -27,15 +27,6 @@ rtems_task Task_2(
rtems_task_priority previous_priority;
while( FOREVER ) {
-
- status = rtems_task_get_note( RTEMS_SELF, RTEMS_NOTEPAD_8, &the_priority );
- directive_failed( status, "rtems_task_get_note" );
- printf(
- "TA2 - rtems_task_get_note - get RTEMS_NOTEPAD_8 - "
- "current priority: %02" PRIdrtems_task_priority "\n",
- the_priority
- );
-
if ( --the_priority == 0 ) {
puts( "TA2 - rtems_task_suspend - suspend TA1" );
status = rtems_task_suspend( Task_id[ 1 ] );
@@ -59,14 +50,6 @@ rtems_task Task_2(
} else {
printf(
- "TA2 - rtems_task_set_note - set TA1's RTEMS_NOTEPAD_8: "
- "%02" PRIdrtems_task_priority "\n",
- the_priority
- );
- status = rtems_task_set_note(Task_id[ 1 ], RTEMS_NOTEPAD_8, the_priority);
- directive_failed( status, "rtems_task_set_note" );
-
- printf(
"TA2 - rtems_task_set_priority - set TA1's priority: "
"%02" PRIdrtems_task_priority "\n",
the_priority