2007-11-30 Joel Sherrill <joel.sherrill@OARcorp.com>

	* rtems/src/barrierdelete.c, rtems/src/barrierrelease.c,
	rtems/src/barriertranslatereturncode.c, rtems/src/barrierwait.c,
	rtems/src/clockget.c, rtems/src/dpmemdelete.c,
	rtems/src/dpmemexternal2internal.c,
	rtems/src/dpmeminternal2external.c, rtems/src/eventsend.c,
	rtems/src/eventtimeout.c, rtems/src/msgqbroadcast.c,
	rtems/src/msgqdelete.c, rtems/src/msgqflush.c,
	rtems/src/msgqgetnumberpending.c, rtems/src/msgqreceive.c,
	rtems/src/msgqsend.c, rtems/src/msgqurgent.c, rtems/src/partdelete.c,
	rtems/src/partgetbuffer.c, rtems/src/partreturnbuffer.c,
	rtems/src/ratemoncancel.c, rtems/src/ratemondelete.c,
	rtems/src/ratemongetstatistics.c, rtems/src/ratemongetstatus.c,
	rtems/src/ratemonperiod.c, rtems/src/ratemonresetstatistics.c,
	rtems/src/ratemontimeout.c, rtems/src/semdelete.c,
	rtems/src/semflush.c, rtems/src/semobtain.c, rtems/src/semrelease.c,
	rtems/src/semtranslatereturncode.c, rtems/src/signalsend.c,
	rtems/src/taskdelete.c, rtems/src/taskgetnote.c,
	rtems/src/taskissuspended.c, rtems/src/taskrestart.c,
	rtems/src/taskresume.c, rtems/src/tasksetnote.c,
	rtems/src/tasksetpriority.c, rtems/src/taskstart.c,
	rtems/src/tasksuspend.c, rtems/src/taskvariableadd.c,
	rtems/src/taskvariabledelete.c, rtems/src/taskvariableget.c,
	rtems/src/timercancel.c, rtems/src/timerdelete.c,
	rtems/src/timerfirewhen.c, rtems/src/timergetinfo.c,
	rtems/src/timerreset.c, rtems/src/timerserverfireafter.c,
	rtems/src/timerserverfirewhen.c: Restructured all code with
	the switch (location) pattern so that OBJECTS_LOCAL is first
	and we can fall into it and the OBJECTS_ERROR case breaks
	to a return RTEMS_INVALID_ID.  This eliminates the return
	RTEMS_INTERNAL_ERROR at the bottom of each of these files which
	was unreachable and untestable code.  This resulted in a code
	savings of approximately 20 bytes per file on the SPARC/ERC32.

1 files changed, 35 insertions, 38 deletions

diff --git a/cpukit/rtems/src/taskvariableadd.c b/cpukit/rtems/src/taskvariableadd.c
index a1d7fef19d..080d6eebf1 100644
--- a/cpukit/rtems/src/taskvariableadd.c
+++ b/cpukit/rtems/src/taskvariableadd.c
@@ -41,50 +41,47 @@ rtems_status_code rtems_task_variable_add(
 
   the_thread = _Thread_Get (tid, &location);
   switch (location) {
-#if defined(RTEMS_MULTIPROCESSING)
-  case OBJECTS_REMOTE:
-    _Thread_Dispatch();
-    return RTEMS_ILLEGAL_ON_REMOTE_OBJECT;
-#endif
-
-  case OBJECTS_ERROR:
-  default:
-    return RTEMS_INVALID_ID;
 
-  case OBJECTS_LOCAL:
-
-    /*
-     *  Figure out if the variable is already in this task's list.
-     */
+    case OBJECTS_LOCAL:
+      /*
+       *  Figure out if the variable is already in this task's list.
+       */
+      tvp = the_thread->task_variables;
+      while (tvp) {
+        if (tvp->ptr == ptr) {
+	  tvp->dtor = dtor;
+          _Thread_Enable_dispatch();
+          return RTEMS_SUCCESSFUL;
+        }
+        tvp = (rtems_task_variable_t *)tvp->next;
+      }
 
-    tvp = the_thread->task_variables;
-    while (tvp) {
-      if (tvp->ptr == ptr) {
-	tvp->dtor = dtor;
+      /*
+       *  Now allocate memory for this task variable.
+       */
+      new = (rtems_task_variable_t *)
+         _Workspace_Allocate(sizeof(rtems_task_variable_t));
+      if (new == NULL) {
         _Thread_Enable_dispatch();
-        return RTEMS_SUCCESSFUL;
+        return RTEMS_NO_MEMORY;
       }
-      tvp = (rtems_task_variable_t *)tvp->next;
-    }
+      new->gval = *ptr;
+      new->ptr = ptr;
+      new->dtor = dtor;
 
-    /*
-     *  Now allocate memory for this task variable.
-     */
-
-    new = (rtems_task_variable_t *)
-       _Workspace_Allocate(sizeof(rtems_task_variable_t));
-    if (new == NULL) {
+      new->next = (struct rtems_task_variable_tt *)the_thread->task_variables;
+      the_thread->task_variables = new;
       _Thread_Enable_dispatch();
-      return RTEMS_NO_MEMORY;
-    }
-    new->gval = *ptr;
-    new->ptr = ptr;
-    new->dtor = dtor;
+      return RTEMS_SUCCESSFUL;
+
+#if defined(RTEMS_MULTIPROCESSING)
+    case OBJECTS_REMOTE:
+      _Thread_Dispatch();
+      return RTEMS_ILLEGAL_ON_REMOTE_OBJECT;
+#endif
 
-    new->next = (struct rtems_task_variable_tt *)the_thread->task_variables;
-    the_thread->task_variables = new;
-    _Thread_Enable_dispatch();
-    return RTEMS_SUCCESSFUL;
+    case OBJECTS_ERROR:
+      break;
   }
-  return RTEMS_INTERNAL_ERROR;   /* unreached - only to remove warnings */
+  return RTEMS_INVALID_ID;
 }