diff options
| author | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2021-05-11 17:27:20 +0200 |
|---|---|---|
| committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2021-05-12 21:25:37 +0200 |
| commit | 523867de9d274d2bdc29ce649d764b42a9167c0e (patch) | |
| tree | 88d38e4054d3c24eaa9bbd5327faed8bffe406f8 /cpukit/rtems/src/clocktodvalidate.c | |
| parent | rtems: Document rtems_task_set_scheduler() errors (diff) | |
| download | rtems-523867de9d274d2bdc29ce649d764b42a9167c0e.tar.bz2 | |
rtems: Constify rtems_task_wake_when()
Add a parameter to _TOD_Validate() to disable the validation of the
ticks member.
There are two reasons for this change. Firstly, in
rtems_task_wake_when() was a double check for time_buffer == NULL (one
in rtems_task_wake_when() and one in _TOD_Validate()). Secondly, the
ticks member is ignored by rtems_task_wake_when(). This was done with a
write of zero to the ticks member and thus a modification of the
user-provided structure. Now the structure is no longer modified.
Using a mask parameter is quite efficient. You just have to load an
immediate value and there are no additional branches in _TOD_Validate().
Close #4406.
Diffstat (limited to 'cpukit/rtems/src/clocktodvalidate.c')
| -rw-r--r-- | cpukit/rtems/src/clocktodvalidate.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/cpukit/rtems/src/clocktodvalidate.c b/cpukit/rtems/src/clocktodvalidate.c index 95c8e77c37..41a1167287 100644 --- a/cpukit/rtems/src/clocktodvalidate.c +++ b/cpukit/rtems/src/clocktodvalidate.c @@ -36,7 +36,8 @@ const uint32_t _TOD_Days_per_month[ 2 ][ 13 ] = { }; rtems_status_code _TOD_Validate( - const rtems_time_of_day *the_tod + const rtems_time_of_day *the_tod, + uint32_t ticks_mask ) { uint32_t days_in_month; @@ -48,7 +49,7 @@ rtems_status_code _TOD_Validate( ticks_per_second = rtems_clock_get_ticks_per_second(); - if ((the_tod->ticks >= ticks_per_second) || + if ( ( ( the_tod->ticks & ticks_mask ) >= ticks_per_second ) || (the_tod->second >= TOD_SECONDS_PER_MINUTE) || (the_tod->minute >= TOD_MINUTES_PER_HOUR) || (the_tod->hour >= TOD_HOURS_PER_DAY) || |