2008-02-27 Joel Sherrill <joel.sherrill@oarcorp.com>

	* libmisc/shell/cat_file.c, libmisc/shell/main_alias.c,
	libmisc/shell/main_blksync.c, libmisc/shell/main_cat.c,
	libmisc/shell/main_chdir.c, libmisc/shell/main_chmod.c,
	libmisc/shell/main_chroot.c, libmisc/shell/main_cpuuse.c,
	libmisc/shell/main_date.c, libmisc/shell/main_help.c,
	libmisc/shell/main_id.c, libmisc/shell/main_logoff.c,
	libmisc/shell/main_ls.c, libmisc/shell/main_mallocinfo.c,
	libmisc/shell/main_mdump.c, libmisc/shell/main_medit.c,
	libmisc/shell/main_mfill.c, libmisc/shell/main_mkdir.c,
	libmisc/shell/main_mmove.c, libmisc/shell/main_mount.c,
	libmisc/shell/main_mount_nfs.c, libmisc/shell/main_msdosfmt.c,
	libmisc/shell/main_mwdump.c, libmisc/shell/main_perioduse.c,
	libmisc/shell/main_pwd.c, libmisc/shell/main_rm.c,
	libmisc/shell/main_rmdir.c, libmisc/shell/main_stackuse.c,
	libmisc/shell/main_tty.c, libmisc/shell/main_umask.c,
	libmisc/shell/main_unmount.c, libmisc/shell/main_whoami.c,
	libmisc/shell/shell.h: Clean up done while writing documentation.
	Some command improvements such as date now allows setting of the
	current TOD. Often commands did not use stdout/stderr per
	expectations and did not return -1 on an error.

1 files changed, 17 insertions, 20 deletions

diff --git a/cpukit/libmisc/shell/main_blksync.c b/cpukit/libmisc/shell/main_blksync.c
index c59760c2b6..0089a75adf 100644
--- a/cpukit/libmisc/shell/main_blksync.c
+++ b/cpukit/libmisc/shell/main_blksync.c
@@ -28,45 +28,42 @@
 #include <rtems/blkdev.h>
 #include "internal.h"
 
-int rtems_shell_main_blksync(int argc, char *argv[])
+int rtems_shell_main_blksync(
+  int argc,
+  char *argv[]
+)
 {
   const char* driver = NULL;
   int         arg;
+  int         fd;
   
-  for (arg = 1; arg < argc; arg++)
-  {
-    if (argv[arg][0] == '-')
-    {
-      printf ("error: invalid option: %s\n", argv[arg]);
+  for (arg = 1; arg < argc; arg++) {
+    if (argv[arg][0] == '-') {
+      fprintf( stderr, "%s: invalid option: %s\n", argv[0], argv[arg]);
       return 1;
-    }
-    else
-    {
+    } else {
       if (!driver)
         driver = argv[arg];
-      else
-      {
-        printf ("error: only one driver name allowed: %s\n", argv[arg]);
+      else {
+        fprintf( stderr, "%s: only one driver name allowed: %s\n",
+          argv[0], argv[arg]);
         return 1;
       }
     }
   }
   
-  int fd = open (driver, O_WRONLY, 0);
-  if (fd < 0)
-  {
-    printf ("error: driver open failed: %s\n", strerror (errno));
+  fd = open (driver, O_WRONLY, 0);
+  if (fd < 0) {
+    fprintf( stderr, "%s: driver open failed: %s\n", argv[0], strerror (errno));
     return 1;
   }
   
-  if (ioctl (fd, BLKIO_SYNCDEV) < 0)
-  {
-    printf ("error: driver sync failed: %s\n", strerror (errno));
+  if (ioctl (fd, BLKIO_SYNCDEV) < 0) {
+    fprintf( stderr, "%s: driver sync failed: %s\n", argv[0], strerror (errno));
     return 1;
   }
   
   close (fd);
-  
   return 0;
 }