diff options
| author | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2021-10-12 08:26:39 +0200 |
|---|---|---|
| committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2021-10-25 08:01:02 +0200 |
| commit | 0221da5f56353c9b238ef51d5a24802ba67b8c56 (patch) | |
| tree | 4823b8d298eb678c20db4078c2ec8e1e13fa52e5 /cpukit/libmisc/cpuuse | |
| parent | score: Optimize default idle task stack allocator (diff) | |
| download | rtems-0221da5f56353c9b238ef51d5a24802ba67b8c56.tar.bz2 | |
rtems: Fix rate monotonic statistics
The rate monotonic period statistics were affected by
rtems_cpu_usage_reset(). The logic to detect and work around a CPU
usage reset was broken.
The Thread_Contol::cpu_time_used is changed to contain the processor
time used throughout the entire lifetime of the thread. The new member
Thread_Contol::cpu_time_used_at_last_reset is added to contain the
processor time used at the time of the last reset through
rtems_cpu_usage_reset(). This decouples the resets of the CPU usage and
the rate monotonic period statistics.
Update #4528.
Diffstat (limited to 'cpukit/libmisc/cpuuse')
| -rw-r--r-- | cpukit/libmisc/cpuuse/cpuusagereport.c | 2 | ||||
| -rw-r--r-- | cpukit/libmisc/cpuuse/cpuusagereset.c | 3 | ||||
| -rw-r--r-- | cpukit/libmisc/cpuuse/cpuusagetop.c | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/cpukit/libmisc/cpuuse/cpuusagereport.c b/cpukit/libmisc/cpuuse/cpuusagereport.c index 08bc5bb541..ea21e73dc1 100644 --- a/cpukit/libmisc/cpuuse/cpuusagereport.c +++ b/cpukit/libmisc/cpuuse/cpuusagereport.c @@ -52,7 +52,7 @@ static bool cpu_usage_visitor( Thread_Control *the_thread, void *arg ) ctx = arg; _Thread_Get_name( the_thread, name, sizeof( name ) ); - _Thread_Get_CPU_time_used( the_thread, &used ); + used = _Thread_Get_CPU_time_used_after_last_reset( the_thread ); _TOD_Get_uptime( &uptime ); _Timestamp_Subtract( &ctx->uptime_at_last_reset, &uptime, &ctx->total ); _Timestamp_Divide( &used, &ctx->total, &ival, &fval ); diff --git a/cpukit/libmisc/cpuuse/cpuusagereset.c b/cpukit/libmisc/cpuuse/cpuusagereset.c index 10d8ebec48..d1f0e65180 100644 --- a/cpukit/libmisc/cpuuse/cpuusagereset.c +++ b/cpukit/libmisc/cpuuse/cpuusagereset.c @@ -40,7 +40,8 @@ static bool CPU_usage_Per_thread_handler( scheduler = _Thread_Scheduler_get_home( the_thread ); _Scheduler_Acquire_critical( scheduler, &scheduler_lock_context ); - _Timestamp_Set_to_zero( &the_thread->cpu_time_used ); + the_thread->cpu_time_used_at_last_reset = + _Thread_Get_CPU_time_used_locked( the_thread ); _Scheduler_Release_critical( scheduler, &scheduler_lock_context ); _Thread_State_release( the_thread, &state_lock_context ); diff --git a/cpukit/libmisc/cpuuse/cpuusagetop.c b/cpukit/libmisc/cpuuse/cpuusagetop.c index dad11ad748..51d049257a 100644 --- a/cpukit/libmisc/cpuuse/cpuusagetop.c +++ b/cpukit/libmisc/cpuuse/cpuusagetop.c @@ -178,7 +178,7 @@ task_usage(Thread_Control* thread, void* arg) data->stack_size += thread->Start.Initial_stack.size; - _Thread_Get_CPU_time_used(thread, &usage); + usage = _Thread_Get_CPU_time_used_after_last_reset(thread); for (j = 0; j < data->last_task_count; j++) { |