diff options
| author | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2020-03-10 17:07:19 +0100 |
|---|---|---|
| committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2020-03-13 09:57:04 +0100 |
| commit | c2287ba2cff59a50848151833404bce0e3cf0a70 (patch) | |
| tree | 24fbd290baf4722b2dd56df731f44b41b6765c45 /cpukit/libcsupport/src/open.c | |
| parent | 2ff83634668c56598c9505809bb016c8697ed24e (diff) | |
libio: Robust file descriptor reference counting
There was a race conditon in the reference counting of file descriptors
during a close() operation. After the call to the close handler, the
rtems_libio_free() function cleared the flags to zero. However, at this
point in time there may still exist some holders of the file descriptor.
With RTEMS_DEBUG enabled this could lead to failed assertions in
rtems_libio_iop_drop().
Change the code to use only atomic read-modify-write operations on the
rtems_libio_iop::flags.
Diffstat (limited to 'cpukit/libcsupport/src/open.c')
| -rw-r--r-- | cpukit/libcsupport/src/open.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/cpukit/libcsupport/src/open.c b/cpukit/libcsupport/src/open.c index 86d0bbeab9..b21dcb1876 100644 --- a/cpukit/libcsupport/src/open.c +++ b/cpukit/libcsupport/src/open.c @@ -115,11 +115,7 @@ static int do_open( rtems_filesystem_eval_path_extract_currentloc( &ctx, &iop->pathinfo ); rtems_filesystem_eval_path_cleanup( &ctx ); - _Atomic_Store_uint( - &iop->flags, - rtems_libio_fcntl_flags( oflag ), - ATOMIC_ORDER_RELAXED - ); + rtems_libio_iop_flags_set( iop, rtems_libio_fcntl_flags( oflag ) ); rv = (*iop->pathinfo.handlers->open_h)( iop, path, oflag, mode ); |