diff options
| author | Chris Johns <chrisj@rtems.org> | 2012-12-29 10:20:22 +1100 |
|---|---|---|
| committer | Chris Johns <chrisj@rtems.org> | 2012-12-29 10:20:22 +1100 |
| commit | cc54579b0b54bd349f1d69f40aa89607e32bf614 (patch) | |
| tree | 8d5fef66763090ebab459497d7302d0111b8e988 /rld-resolver.h | |
| parent | 0123e92cdeb732ae20c3a69047c7d05877cb0318 (diff) | |
Fix managing weak symbols.
Weak symbols where not being managed correctly. The symbols table
is now a class with externals and weaks as separate symtabs so
the externals can be searched first then the weaks and if not
found an unresolved error is raised. This was found creating
a libbsdport RAP file where the drivers in the all driver table
resolved to the weak symbols and so linking in nothing.
Fixing the weak symbols as found in the libbsdport library
triggered a new resolver bug. The object files now contain the
resolver state and this is used to determine if an object file
has been resolved or is currently being resolved avoiding
rescursive loops with dependent object files.
The resolver trace output is a little easier to read.
Diffstat (limited to 'rld-resolver.h')
| -rw-r--r-- | rld-resolver.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/rld-resolver.h b/rld-resolver.h index 0385bda..3771f18 100644 --- a/rld-resolver.h +++ b/rld-resolver.h @@ -1,10 +1,10 @@ /* - * Copyright (c) 2011, Chris Johns <chrisj@rtems.org> + * Copyright (c) 2011, Chris Johns <chrisj@rtems.org> * * Permission to use, copy, modify, and/or distribute this software for any * purpose with or without fee is hereby granted, provided that the above * copyright notice and this permission notice appear in all copies. - * + * * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR @@ -43,11 +43,11 @@ namespace rld * @param undefined Extra undefined symbols dependent object files are * added for. */ - void resolve (rld::files::object_list& dependents, - rld::files::cache& cache, - rld::symbols::table& base_symbols, - rld::symbols::table& symbols, - rld::symbols::table& undefined); + void resolve (files::object_list& dependents, + files::cache& cache, + symbols::table& base_symbols, + symbols::table& symbols, + symbols::symtab& undefined); } } |