From 523867de9d274d2bdc29ce649d764b42a9167c0e Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 11 May 2021 17:27:20 +0200 Subject: rtems: Constify rtems_task_wake_when() Add a parameter to _TOD_Validate() to disable the validation of the ticks member. There are two reasons for this change. Firstly, in rtems_task_wake_when() was a double check for time_buffer == NULL (one in rtems_task_wake_when() and one in _TOD_Validate()). Secondly, the ticks member is ignored by rtems_task_wake_when(). This was done with a write of zero to the ticks member and thus a modification of the user-provided structure. Now the structure is no longer modified. Using a mask parameter is quite efficient. You just have to load an immediate value and there are no additional branches in _TOD_Validate(). Close #4406. --- testsuites/sptests/sp2038/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'testsuites') diff --git a/testsuites/sptests/sp2038/init.c b/testsuites/sptests/sp2038/init.c index 035b9a9b9b..dedd66d2c3 100644 --- a/testsuites/sptests/sp2038/init.c +++ b/testsuites/sptests/sp2038/init.c @@ -281,9 +281,9 @@ static void test_leap_year(void) const rtems_time_of_day *problem = &problem_2100; const rtems_time_of_day *problem2 = &problem_2100_2; // 2100 is not a leap year, so it should have 28 days - test_status = _TOD_Validate(problem); + test_status = _TOD_Validate(problem, TOD_ENABLE_TICKS_VALIDATION); rtems_test_assert(test_status == RTEMS_SUCCESSFUL); - test_status = _TOD_Validate(problem2); + test_status = _TOD_Validate(problem2, TOD_ENABLE_TICKS_VALIDATION); rtems_test_assert(test_status == RTEMS_INVALID_CLOCK); } -- cgit v1.2.3