From 6a56fd9340e46766dc5b069f259e4c133c06f39a Mon Sep 17 00:00:00 2001 From: Harrison Edward Gerber Date: Thu, 27 May 2021 17:31:53 -0700 Subject: cpukit/libmisc/monitor: Fix src/dest overlap of strcpy in mon-editor.c See also CID 1399727 Closes #4444 --- cpukit/libmisc/monitor/mon-editor.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'cpukit') diff --git a/cpukit/libmisc/monitor/mon-editor.c b/cpukit/libmisc/monitor/mon-editor.c index dcea9fcc69..6957fee9c8 100644 --- a/cpukit/libmisc/monitor/mon-editor.c +++ b/cpukit/libmisc/monitor/mon-editor.c @@ -360,7 +360,17 @@ rtems_monitor_line_editor ( { int bs; pos--; - strcpy (buffer + pos, buffer + pos + 1); + + /* + * Memory operation used here instead of string + * method due the src and dest of buffer overlapping. + */ + memmove( + buffer + pos, + buffer + pos + 1, + RTEMS_COMMAND_BUFFER_SIZE - pos - 1 + ); + buffer[RTEMS_COMMAND_BUFFER_SIZE - 1] = '\0'; fprintf(stdout,"\b%s \b", buffer + pos); for (bs = 0; bs < ((int) strlen (buffer) - pos); bs++) putchar ('\b'); -- cgit v1.2.3