From 639117fd12781fcb92919e2095fc345f9caa4180 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 22 Jul 2014 14:50:07 +0200 Subject: rbtree: Update maximum node in LIFO order The test sptests/sp35 showed a NULL pointer access due to an invalid maximum node field (e.g. a tree with one element and NULL as the maximum node). --- cpukit/score/src/rbtreeinsert.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cpukit/score/src') diff --git a/cpukit/score/src/rbtreeinsert.c b/cpukit/score/src/rbtreeinsert.c index b31c8e7bb7..afff1ef5f9 100644 --- a/cpukit/score/src/rbtreeinsert.c +++ b/cpukit/score/src/rbtreeinsert.c @@ -96,8 +96,8 @@ RBTree_Node *_RBTree_Insert( ); if ( - ( !dir && _RBTree_Is_lesser( compare_result ) ) - || ( dir && _RBTree_Is_greater( compare_result ) ) + ( dir == RBT_LEFT && _RBTree_Is_lesser( compare_result ) ) + || ( dir == RBT_RIGHT && !_RBTree_Is_lesser( compare_result ) ) ) { the_rbtree->first[ dir ] = the_node; } -- cgit v1.2.3