From 1b1be254e7a3e3d6fe6d55d62010a81a7ef35411 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 25 Mar 2014 10:54:49 +0100 Subject: score: Thread life cycle re-implementation The thread deletion is now supported on SMP. This change fixes the following PRs: PR1814: SMP race condition between stack free and dispatch PR2035: psxcancel reveals NULL pointer access in _Thread_queue_Extract() The POSIX cleanup handler are now called in the right context (should be called in the context of the terminating thread). http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_09.html Add a user extension the reflects a thread termination event. This is used to reclaim the Newlib reentrancy structure (may use file operations), the POSIX cleanup handlers and the POSIX key destructors. --- cpukit/score/src/threadclose.c | 101 ----------------------------------------- 1 file changed, 101 deletions(-) delete mode 100644 cpukit/score/src/threadclose.c (limited to 'cpukit/score/src/threadclose.c') diff --git a/cpukit/score/src/threadclose.c b/cpukit/score/src/threadclose.c deleted file mode 100644 index 12896f5fee..0000000000 --- a/cpukit/score/src/threadclose.c +++ /dev/null @@ -1,101 +0,0 @@ -/** - * @file - * - * @brief Thread Close - * @ingroup ScoreThread - */ - -/* - * COPYRIGHT (c) 1989-2011. - * On-Line Applications Research Corporation (OAR). - * - * The license and distribution terms for this file may be - * found in the file LICENSE in this distribution or at - * http://www.rtems.org/license/LICENSE. - */ - -#if HAVE_CONFIG_H -#include "config.h" -#endif - -#include -#include -#include -#include -#include -#include - -void _Thread_Close( - Objects_Information *information, - Thread_Control *the_thread -) -{ - /* - * Now we are in a dispatching critical section again and we - * can take the thread OUT of the published set. It is invalid - * to use this thread's Id after this call. This will prevent - * any other task from attempting to initiate a call on this task. - */ - _Objects_Invalidate_Id( information, &the_thread->Object ); - - /* - * We assume the Allocator Mutex is locked when we get here. - * This provides sufficient protection to let the user extensions - * run but as soon as we get back, we will make the thread - * disappear and set a transient state on it. So we temporarily - * unnest dispatching. - */ - _Thread_Unnest_dispatch(); - - _User_extensions_Thread_delete( the_thread ); - - _Thread_Disable_dispatch(); - - /* - * Now we are in a dispatching critical section again and we - * can take the thread OUT of the published set. It is invalid - * to use this thread's Id OR name after this call. - */ - _Objects_Close( information, &the_thread->Object ); - - /* - * By setting the dormant state, the thread will not be considered - * for scheduling when we remove any blocking states. - */ - _Thread_Set_state( the_thread, STATES_DORMANT ); - - if ( !_Thread_queue_Extract_with_proxy( the_thread ) ) { - if ( _Watchdog_Is_active( &the_thread->Timer ) ) - (void) _Watchdog_Remove( &the_thread->Timer ); - } - - /* - * Free the per-thread scheduling information. - */ - _Scheduler_Free( the_thread ); - - /* - * The thread might have been FP. So deal with that. - */ -#if ( CPU_HARDWARE_FP == TRUE ) || ( CPU_SOFTWARE_FP == TRUE ) -#if ( CPU_USE_DEFERRED_FP_SWITCH == TRUE ) - if ( _Thread_Is_allocated_fp( the_thread ) ) - _Thread_Deallocate_fp(); -#endif - the_thread->fp_context = NULL; - - _Workspace_Free( the_thread->Start.fp_context ); -#endif - - /* - * Free the rest of the memory associated with this task - * and set the associated pointers to NULL for safety. - */ - _Thread_Stack_Free( the_thread ); - the_thread->Start.stack = NULL; - - _Workspace_Free( the_thread->extensions ); - the_thread->extensions = NULL; - - _Workspace_Free( the_thread->Start.tls_area ); -} -- cgit v1.2.3