From 701dd96f598bd58a41884795ba5bf0b5da337d78 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Thu, 12 Jun 2014 14:37:57 +0200 Subject: score: PR2181: Add _Thread_Yield() The _Scheduler_Yield() was called by the executing thread with thread dispatching disabled and interrupts enabled. The rtems_task_suspend() is explicitly allowed in ISRs: http://rtems.org/onlinedocs/doc-current/share/rtems/html/c_user/Interrupt-Manager-Directives-Allowed-from-an-ISR.html#Interrupt-Manager-Directives-Allowed-from-an-ISR Unlike the other scheduler operations the locking was performed inside the operation. This lead to the following race condition. Suppose a ISR suspends the executing thread right before the yield scheduler operation. Now the executing thread is not longer in the set of ready threads. The typical scheduler operations did not check the thread state and will now extract the thread again and enqueue it. This corrupted data structures. Add _Thread_Yield() and do the scheduler yield operation with interrupts disabled. This has a negligible effect on the interrupt latency. --- cpukit/score/src/schedulersimplesmp.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'cpukit/score/src/schedulersimplesmp.c') diff --git a/cpukit/score/src/schedulersimplesmp.c b/cpukit/score/src/schedulersimplesmp.c index eb260efd09..37458d6b6f 100644 --- a/cpukit/score/src/schedulersimplesmp.c +++ b/cpukit/score/src/schedulersimplesmp.c @@ -302,12 +302,12 @@ void _Scheduler_simple_SMP_Yield( ) { Scheduler_Context *context = _Scheduler_Get_context( scheduler ); - ISR_Level level; - _ISR_Disable( level ); - - _Scheduler_SMP_Extract_from_scheduled( thread ); - _Scheduler_simple_SMP_Enqueue_scheduled_fifo( context, thread ); - - _ISR_Enable( level ); + return _Scheduler_SMP_Yield( + context, + thread, + _Scheduler_simple_SMP_Extract_from_ready, + _Scheduler_simple_SMP_Enqueue_fifo, + _Scheduler_simple_SMP_Enqueue_scheduled_fifo + ); } -- cgit v1.2.3