From 523867de9d274d2bdc29ce649d764b42a9167c0e Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 11 May 2021 17:27:20 +0200 Subject: rtems: Constify rtems_task_wake_when() Add a parameter to _TOD_Validate() to disable the validation of the ticks member. There are two reasons for this change. Firstly, in rtems_task_wake_when() was a double check for time_buffer == NULL (one in rtems_task_wake_when() and one in _TOD_Validate()). Secondly, the ticks member is ignored by rtems_task_wake_when(). This was done with a write of zero to the ticks member and thus a modification of the user-provided structure. Now the structure is no longer modified. Using a mask parameter is quite efficient. You just have to load an immediate value and there are no additional branches in _TOD_Validate(). Close #4406. --- cpukit/rtems/src/timercreate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cpukit/rtems/src/timercreate.c') diff --git a/cpukit/rtems/src/timercreate.c b/cpukit/rtems/src/timercreate.c index bd9421c440..59fa353b22 100644 --- a/cpukit/rtems/src/timercreate.c +++ b/cpukit/rtems/src/timercreate.c @@ -141,7 +141,7 @@ rtems_status_code _Timer_Fire_when( if ( !routine ) return RTEMS_INVALID_ADDRESS; - status = _TOD_Validate( wall_time ); + status = _TOD_Validate( wall_time, TOD_ENABLE_TICKS_VALIDATION ); if ( status != RTEMS_SUCCESSFUL ) { return status; -- cgit v1.2.3