From ffd52858449d58111581d5ee82ff1c3ffba585a5 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 18 Nov 2014 11:07:36 +0100 Subject: shell: Inherit UID and GID if no login check Use the UID and GID of the executing user for the real and effective UID and GID of the shell task in case no login check is present. This prevents privilege escalation via shell scripts. --- cpukit/libmisc/shell/shell.c | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'cpukit/libmisc/shell/shell.c') diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 5b742575e9..14d4b5f674 100644 --- a/cpukit/libmisc/shell/shell.c +++ b/cpukit/libmisc/shell/shell.c @@ -838,6 +838,12 @@ bool rtems_shell_main_loop( if (shell_env->login_check != NULL) { result = rtems_shell_login(shell_env, stdin,stdout); } else { + setuid(shell_env->uid); + setgid(shell_env->gid); + seteuid(shell_env->uid); + setegid(shell_env->gid); + rtems_current_user_env_getgroups(); + result = true; } } @@ -1010,6 +1016,8 @@ static rtems_status_code rtems_shell_run ( shell_env->output_append = output_append; shell_env->wake_on_end = wake_on_end; shell_env->login_check = login_check; + shell_env->uid = getuid(); + shell_env->gid = getgid(); getcwd(shell_env->cwd, sizeof(shell_env->cwd)); -- cgit v1.2.3