From 11eb818e88cf6ac04aa19de411bec151fd11bbdb Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Wed, 13 Mar 2019 10:06:45 -0500 Subject: fifo.c: Eliminate logically dead code (Coverity 1437635) --- cpukit/libfs/src/pipe/fifo.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'cpukit/libfs') diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c index 71d5f8598a..3275e5f1fd 100644 --- a/cpukit/libfs/src/pipe/fifo.c +++ b/cpukit/libfs/src/pipe/fifo.c @@ -149,18 +149,15 @@ static int pipe_new( pipe = *pipep; if (pipe == NULL) { err = pipe_alloc(&pipe); - if (err) - goto out; + if (err) { + pipe_unlock(); + return err; + } } PIPE_LOCK(pipe); - if (*pipep == NULL) { - if (err) - pipe_free(pipe); - else - *pipep = pipe; - } + *pipep = pipe; out: pipe_unlock(); -- cgit v1.2.3