From c257429f6101e31077c83a2213229a4976d82b31 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Fri, 12 Nov 1999 21:15:12 +0000 Subject: + Moved error checks to before the dispatch disable where possible. + Modified correct return path to call _ITRON_return_errorno( E_OK ) instead of enabling dispatching and returning E_OK. --- cpukit/itron/src/cre_tsk.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) (limited to 'cpukit/itron') diff --git a/cpukit/itron/src/cre_tsk.c b/cpukit/itron/src/cre_tsk.c index 70ae6a2e81..d49f013a73 100644 --- a/cpukit/itron/src/cre_tsk.c +++ b/cpukit/itron/src/cre_tsk.c @@ -31,18 +31,12 @@ ER cre_tsk( boolean status; Priority_Control core_priority; - /* - * Disable dispatching. - */ - - _Thread_Disable_dispatch(); - /* * Validate Parameters. */ if ( pk_ctsk == NULL ) - _ITRON_return_errorno( E_PAR ); + return E_PAR; if ((pk_ctsk->tskatr != TA_ASM ) && (pk_ctsk->tskatr != TA_HLNG) && @@ -54,15 +48,21 @@ ER cre_tsk( (pk_ctsk->tskatr != TA_COP5) && (pk_ctsk->tskatr != TA_COP6) && (pk_ctsk->tskatr != TA_COP7)) - _ITRON_return_errorno( E_RSATR ); + return E_RSATR; if (( pk_ctsk->itskpri <= 0 ) || ( pk_ctsk->itskpri >= 256 )) - _ITRON_return_errorno( E_PAR ); + return E_PAR; if ( pk_ctsk->task == NULL ) - _ITRON_return_errorno( E_PAR ); + return E_PAR; if ( pk_ctsk->stksz < 0 ) - _ITRON_return_errorno( E_PAR ); + return E_PAR; + /* + * Disable dispatching. + */ + + _Thread_Disable_dispatch(); + /* * allocate the thread. */ @@ -106,8 +106,7 @@ ER cre_tsk( the_thread->Start.entry_point = (Thread_Entry) pk_ctsk->task; - _Thread_Enable_dispatch(); - return E_OK; + _ITRON_return_errorno( E_OK ); } -- cgit v1.2.3