From c6810c824c9445fdc44ae5c0092f9ae5355a1420 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Mon, 19 Jun 2017 14:09:28 +0200 Subject: bsps: Improve interrupt vector enable/disable API Change bsp_interrupt_vector_enable() and bsp_interrupt_vector_disable() to not return a status code. Add bsp_interrupt_assert() and use it to validate the vector number in the vector enable/disable implementations. --- c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) (limited to 'c/src/lib/libcpu/powerpc') diff --git a/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c b/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c index 59b2c39c59..789a19a490 100644 --- a/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c +++ b/c/src/lib/libcpu/powerpc/mpc55xx/irq/irq.c @@ -180,20 +180,14 @@ rtems_status_code bsp_interrupt_facility_initialize(void) return RTEMS_SUCCESSFUL; } -rtems_status_code bsp_interrupt_vector_enable( rtems_vector_number vector) +void bsp_interrupt_vector_enable( rtems_vector_number vector) { - if (MPC55XX_IRQ_IS_VALID( vector)) { - return mpc55xx_intc_set_priority( vector, MPC55XX_INTC_DEFAULT_PRIORITY); - } else { - return RTEMS_SUCCESSFUL; - } + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); + mpc55xx_intc_set_priority( vector, MPC55XX_INTC_DEFAULT_PRIORITY); } -rtems_status_code bsp_interrupt_vector_disable( rtems_vector_number vector) +void bsp_interrupt_vector_disable( rtems_vector_number vector) { - if (MPC55XX_IRQ_IS_VALID( vector)) { - return mpc55xx_intc_set_priority( vector, MPC55XX_INTC_DISABLED_PRIORITY); - } else { - return RTEMS_SUCCESSFUL; - } + bsp_interrupt_assert(bsp_interrupt_is_valid_vector(vector)); + mpc55xx_intc_set_priority( vector, MPC55XX_INTC_DISABLED_PRIORITY); } -- cgit v1.2.3