From 00dfdd6b0837a21bd3acaab590d850653f79dfa7 Mon Sep 17 00:00:00 2001 From: Pavel Pisa Date: Sat, 3 Sep 2016 01:30:47 +0200 Subject: bsps/arm: remove lock in arm_cp15_set_translation_table_entries(). Protection by rtems_interrupt_disable() is incompatible with SMP build. Actual page table entries manipulation function does not need locking and disabling cache and can be run concurrently even on multiple CPUs as long as changes do not modify same region. If the function is called from more threads/CPUs to modify same region with different mapping options concurrently then there is problem at another level of virtual address space management and has to be solved by mutex or other locking at that level. Updates #2782 Updates #2783 --- c/src/lib/libbsp/arm/shared/arm-cp15-set-ttb-entries.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'c/src/lib/libbsp/arm/shared') diff --git a/c/src/lib/libbsp/arm/shared/arm-cp15-set-ttb-entries.c b/c/src/lib/libbsp/arm/shared/arm-cp15-set-ttb-entries.c index f65000959e..c2be0f566e 100644 --- a/c/src/lib/libbsp/arm/shared/arm-cp15-set-ttb-entries.c +++ b/c/src/lib/libbsp/arm/shared/arm-cp15-set-ttb-entries.c @@ -85,13 +85,5 @@ uint32_t arm_cp15_set_translation_table_entries( uint32_t section_flags ) { - rtems_interrupt_level level; - uint32_t section_flags_of_first_entry; - - rtems_interrupt_disable(level); - section_flags_of_first_entry = - set_translation_table_entries(begin, end, section_flags); - rtems_interrupt_enable(level); - - return section_flags_of_first_entry; + return set_translation_table_entries(begin, end, section_flags); } -- cgit v1.2.3