From c7b4eca7fa3e311c67d5dd1e62e301b01ed45271 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 27 Jul 2021 09:58:43 +0200 Subject: bsps/irq: bsp_interrupt_facility_initialize() Do not return a status code in bsp_interrupt_facility_initialize() since this leads to unreachable code in bsp_interrupt_initialize(). Use RTEMS_DEBUG assertions in bsp_interrupt_facility_initialize() if necessary. --- bsps/shared/dev/irq/arm-gicv2.c | 3 +-- bsps/shared/dev/irq/arm-gicv3.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'bsps/shared/dev') diff --git a/bsps/shared/dev/irq/arm-gicv2.c b/bsps/shared/dev/irq/arm-gicv2.c index eaae6124e8..9c47a4d47b 100644 --- a/bsps/shared/dev/irq/arm-gicv2.c +++ b/bsps/shared/dev/irq/arm-gicv2.c @@ -208,7 +208,7 @@ static void enable_fiq(void) #endif } -rtems_status_code bsp_interrupt_facility_initialize(void) +void bsp_interrupt_facility_initialize(void) { volatile gic_cpuif *cpuif = GIC_CPUIF; volatile gic_dist *dist = ARM_GIC_DIST; @@ -239,7 +239,6 @@ rtems_status_code bsp_interrupt_facility_initialize(void) dist->icddcr = GIC_DIST_ICDDCR_ENABLE_GRP_1 | GIC_DIST_ICDDCR_ENABLE; enable_fiq(); - return RTEMS_SUCCESSFUL; } #ifdef RTEMS_SMP diff --git a/bsps/shared/dev/irq/arm-gicv3.c b/bsps/shared/dev/irq/arm-gicv3.c index ca282a378d..ea123d325e 100644 --- a/bsps/shared/dev/irq/arm-gicv3.c +++ b/bsps/shared/dev/irq/arm-gicv3.c @@ -388,7 +388,7 @@ static void gicv3_init_cpu_interface(void) WRITE_SR(ICC_CTLR, 0x0); } -rtems_status_code bsp_interrupt_facility_initialize(void) +void bsp_interrupt_facility_initialize(void) { volatile gic_dist *dist = ARM_GIC_DIST; uint32_t id_count = get_id_count(dist); @@ -423,7 +423,6 @@ rtems_status_code bsp_interrupt_facility_initialize(void) } gicv3_init_cpu_interface(); - return RTEMS_SUCCESSFUL; } #ifdef RTEMS_SMP -- cgit v1.2.3