From e9ae74369d8fd4e22998893f276472654b650504 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Thu, 14 Nov 2019 11:15:19 +0100 Subject: bsp/riscv: Fix use of uninitialized integer --- bsps/riscv/riscv/console/console-config.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'bsps/riscv/riscv/console/console-config.c') diff --git a/bsps/riscv/riscv/console/console-config.c b/bsps/riscv/riscv/console/console-config.c index 9a8195dda7..0e8262422a 100644 --- a/bsps/riscv/riscv/console/console-config.c +++ b/bsps/riscv/riscv/console/console-config.c @@ -161,7 +161,6 @@ static void riscv_console_probe(void) ns16550_context *ctx; fdt32_t *val; int len; - int reg_shift; ctx = &ns16550_instances[ns16550_devices]; ctx->initial_baud = BSP_CONSOLE_BAUD; @@ -169,11 +168,7 @@ static void riscv_console_probe(void) /* Get register shift property of the UART device */ val = (fdt32_t *) fdt_getprop(fdt, node, "reg-shift", &len); - if (val) { - reg_shift = fdt32_to_cpu(val[0]); - } - - if (reg_shift == 2) { + if (val != NULL && fdt32_to_cpu(val[0]) == 2) { ctx->get_reg = riscv_console_get_reg_32; ctx->set_reg = riscv_console_set_reg_32; } else { -- cgit v1.2.3