From 9511a0ab236d7ec5fb8b42b83dbea09053d3b36f Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Mon, 21 Jun 2010 16:27:23 +0000 Subject: 2010-06-21 Joel Sherrill PR 1554/cpukit Coverity Id 17 * libi2c/libi2c.c: Fix memory leak on error. --- cpukit/ChangeLog | 6 ++++++ cpukit/libi2c/libi2c.c | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/cpukit/ChangeLog b/cpukit/ChangeLog index bbe7ed8b3a..686ac0cbfb 100644 --- a/cpukit/ChangeLog +++ b/cpukit/ChangeLog @@ -1,3 +1,9 @@ +2010-06-21 Joel Sherrill + + PR 1554/cpukit + Coverity Id 17 + * libi2c/libi2c.c: Fix memory leak on error. + 2010-03-17 Chris Johns * libfs/src/dosfs/msdos_create.c: Fix the date/time call order to diff --git a/cpukit/libi2c/libi2c.c b/cpukit/libi2c/libi2c.c index 64272ef5ae..fdca014754 100644 --- a/cpukit/libi2c/libi2c.c +++ b/cpukit/libi2c/libi2c.c @@ -395,11 +395,13 @@ rtems_libi2c_register_bus (const char *name, rtems_libi2c_bus_t * bus) /* check */ if ('/' != *nmcpy) { safe_printf ( DRVNM "Bad name: must be an absolute path starting with '/'\n"); + free( nmcpy ); return -RTEMS_INVALID_NAME; } /* file must not exist */ if (!stat (nmcpy, &sbuf)) { safe_printf ( DRVNM "Bad name: file exists already\n"); + free( nmcpy ); return -RTEMS_INVALID_NAME; } @@ -412,6 +414,7 @@ rtems_libi2c_register_bus (const char *name, rtems_libi2c_bus_t * bus) if (i) { safe_printf ( DRVNM "Get %s status failed: %s\n", nmcpy, strerror(errno)); + free( nmcpy ); return -RTEMS_INVALID_NAME; } /* should be a directory since name terminates in '/' */ @@ -419,11 +422,13 @@ rtems_libi2c_register_bus (const char *name, rtems_libi2c_bus_t * bus) if (!libmutex) { safe_printf ( DRVNM "Library not initialized\n"); + free( nmcpy ); return -RTEMS_NOT_DEFINED; } if (bus == NULL || bus->size < sizeof (*bus)) { safe_printf ( DRVNM "No bus-ops or size too small -- misconfiguration?\n"); + free( nmcpy ); return -RTEMS_NOT_CONFIGURED; } -- cgit v1.2.3