From 51614c0130cb405ff4cdab8c361ad7d63bf5e6fe Mon Sep 17 00:00:00 2001 From: Amaan Cheval Date: Tue, 13 Mar 2018 21:44:14 +0530 Subject: i386/smp: Have ld use incremental build for appstart.o With HAS_SMP set, we have: libbsp_a_LIBADD += appstart.$(OBJEXT) When trying to build appstart.o, however, we link start.o with appcpustart.o through the linkcmds script, which leaves several symbols unresolved, and without the "-r" (or -i) flag, this throws undefined reference errors. This change requires us to re-run the ./bootstrap script to regenerate Makefile.in, and therefore the Makefile for the particular BSP as well. Complete log of errors available here: https://gist.github.com/AmaanC/d40bd7393dca1f82965938275845b7f9 Updates #3331 --- c/src/lib/libbsp/i386/pc386/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/i386/pc386/Makefile.am b/c/src/lib/libbsp/i386/pc386/Makefile.am index 0acce55c44..a8b469120b 100644 --- a/c/src/lib/libbsp/i386/pc386/Makefile.am +++ b/c/src/lib/libbsp/i386/pc386/Makefile.am @@ -154,7 +154,7 @@ appcpustart.$(OBJEXT): start/start16.S $(CPPASCOMPILE) $(AM_CPPFLAGS) -DSMP_SECONDARY_CORE -o $@ -c $< appstart.$(OBJEXT): appcpustart.$(OBJEXT) - $(LD) -N -T $(top_srcdir)/startup/linkcmds \ + $(LD) -r -N -T $(top_srcdir)/startup/linkcmds \ -Ttext 0x70000 -e app_processor_start -nostdlib \ -o appstart_tmp.exe $< $(OBJCOPY) -O binary appstart_tmp.exe appstart.bin -- cgit v1.2.3