summaryrefslogtreecommitdiffstats
path: root/cpukit (follow)
Commit message (Collapse)AuthorAgeFilesLines
* libtrace: Move _Record_Stream_header_initialize()Sebastian Huber2020-11-093-106/+141
| | | | This fixes the build if no function sections are used.
* sparc: Add SPARC_INTERRUPT_SOURCE_TO_TRAP()Sebastian Huber2020-11-061-0/+12
| | | | Update #4171.
* sparc: Add SPARC_INTERRUPT_TRAP_TO_SOURCE()Sebastian Huber2020-11-061-0/+17
| | | | Update #4171.
* sparc: Add SPARC_IS_INTERRUPT_TRAP()Sebastian Huber2020-11-061-0/+17
| | | | Update #4171.
* sparc: Move SPARC-specific macros to sparc.hSebastian Huber2020-11-062-22/+40
| | | | | | Clarify Doxygen comments. Fix formatting. Update #4171.
* confdefs: Add extern C guards to libpci.hJan Sommer2020-10-301-0/+8
|
* score: Fix unused parameter 'lock' warningSebastian Huber2020-10-281-0/+1
|
* rtems-fdt / shell - Fix string truncation warningFrank Kühndel2020-10-201-21/+19
| | | | | | | | | | | | | | The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument 267 | strncpy(path, name, namelen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ It turns out that the `strncpy()` nor the buffer `path` is needed when one uses `strncmp()` instead of `strcmp()`. This needs some change to the algorithm but has the advantage that `name` is never truncated to the size of the buffer `path`.
* posix: Fix pthread_spin_unlock()Sebastian Huber2020-10-191-1/+1
| | | | | | | Prevent a call to _SMP_lock_Stats_register_or_max_section_time(). This fixes a thread stack corruption in case RTEMS_PROFILING and RTEMS_SMP is enabled. Close #4157.
* libfs/rfs: Check search bit map end on last bitChris Johns2020-10-171-2/+15
| | | | | | | - Do not write past the last location of the search bit map whe nit is being created. Closes #4148
* bsps/arm: Workaround for Errata 845369Sebastian Huber2020-10-161-0/+32
| | | | | | | Add a workaround for Cortex-A9 Errata 845369: Under Very Rare Timing Circumstances Transition into Streaming Mode Might Create Data Corruption. Update #4115.
* Revert "rtems-fdt / shell - Fix string truncation warning"Sebastian Huber2020-10-161-19/+21
| | | | This reverts commit 355bc37ad35a7d67a7209130171febe805c67f62.
* rtems-fdt / shell - Fix string truncation warningFrank Kühndel2020-10-151-21/+19
| | | | | | | | | | | | | | | | | | | | | The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument 267 | strncpy(path, name, namelen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ It turns out that the `strncpy()` nor the buffer `path` is needed when one uses `strncmp()` instead of `strcmp()`. This needs some change to the algorithm but has the advantage that `name` is never truncated to the size of the buffer `path`. Note: rtems-fdt.c, rtems-fdt-shell.c and cpukit/include/rtems/rtems-fdt.h seem to be dead code. They implement a shell command `fdt` but that command is not part of the shell nor of any macro in cpukit/include/rtems/shellconfig.h.
* shell/main_edit.c: Fix string truncation warningFrank Kühndel2020-10-151-5/+7
| | | | | | | | | | | | Using strlcpy() instead of strncpy(): 1) Prevents the compiler warnings 2) Ensures, the string is NUL terminated. 3) Avoids that strncpy() unnecessary fills the unused part of the buffer with 0 bytes. (Note that realpath() also returns NULL if the file does not exist - that happens always if someone creates a new file with the editor of the shell.)
* shell/main_edit.c: Fix use of wrong constantFrank Kühndel2020-10-151-1/+2
| | | | | realpath() requires a buffer of size PATH_MAX and not of size FILENAME_MAX according to 'man realpath (3)'.
* shell/shell.c: Fix illegal string copyFrank Kühndel2020-10-151-4/+14
| | | | | | | | | | | | | This is an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The copiler warning was: ../../../cpukit/libmisc/shell/shell.c:626:13: warning: 'strcpy' accessing between 1 and 2147483645 bytes at offsets 0 and [1, 2147483647] may overlap up to 2147483644 bytes at offset [1, 2147483644] [-Wrestrict]
* shell/shell.c: Fix an implicit type castFrank Kühndel2020-10-151-1/+3
| | | | | With some compiler warnings enabled, the implicit cast may trigger a compiler warning. The explicit cast avoids this.
* Remove *_Is_null() inline functionsSebastian Huber2020-10-1412-72/+16
| | | | Simply compare the values against NULL.
* rtems: Remove superfluous includeSebastian Huber2020-10-141-2/+0
|
* shell: Remove not functioning fdisk mount/unmountFrank Kühndel2020-10-124-254/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix. The 'fdisk' command itself is not removed. The reasons for removing the sub-commands (instead of fixing the issue) are: 1) The bug has been introduced on 2010-May-31 with commit 29e92b090c8bc35745aa5c89231ce806bcb11e57. Since ten years no one can use this feature, nor has anybody complained about it. 2) Besides of the 'fdisk' 'mount' sub-command, the shell has the usual 'mount' and 'unmount' commands which can serve as substitutes. 3) There are additional minor issues (see further down) which needed to be addressed when the file will be kept. What follows below is the precise bug description. The bug is in function rtems_bdpart_mount() which is only be used by the 'fdisk' shell command to mount all partitions of a disk with a single command: > fdisk DISK_NAME mount > mounts the file system of each partition of the disk > > fdisk DISK_NAME unmount > unmounts the file system of each partition of the disk The whole command does not work because in file cpukit/libblock/src/bdpart-mount.c line 103 specifies the file system type of each partition to be "msdos". Yet, "msdos" does not exist. The name must be "dosfs". Beside of this fundamental problem, there are more issues with the code in bdpart-mount.c: 1) The function returns RTEMS_SUCCESSFUL despite the mount always fails. 2) The reason for errors is not written to the terminal. 3) The directory '/mnt' is created but not deleted later on (failure or not). 3) There is no documentation about this special 'fdisk' feature in the RTEMS Shell Guide ('fdisk' is mentioned but its documentation is a bit short): https://docs.rtems.org/branches/master/shell/ file_and_directory.html#fdisk-format-disk 4) Only "msdos" formatted partitions can be mounted and all partitions are mounted read-only. This is hard coded and cannot be changed by options. Moreover, there is no information about this to the user of the shell (i.e. using 'fdisk' mount requires insider knowledge). How to reproduce: 1) For testing, I use the 'testsuites/samples/fileio.exe' sample with qemu: > cd rtems > env QEMU_AUDIO_DRV="none" qemu-system-arm -net none -nographic \ > -M realview-pbx-a9 -m 256M -kernel \ > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe 2) Type any key to stop the timer and enter the sample tool. Type 's' to enter the shell, login as 'root' with the password shown in the terminal. 3) Type the following shell commands (they create a RAM disk, partition it, register it, format it and try to mount it): > mkrd > fdisk /dev/rda fat32 16 write mbr > fdisk /dev/rda register > mkdos /dev/rda1 > fdisk /dev/rda mount 4) The last line above is the command which fails - without an error message. There exists a '/mnt' directory but no '/mnt/rda1' directory as it should be: > ls -la /mnt 5) If you change line 103 of 'cpukit/libblock/src/bdpart-mount.c' from "msdos" to "dosfs", compile and build the executable and re-run the above test, '/mnt/rda1' exists (but the file system is mounted read-only). Close #4131
* cpukit/libmisc/monitor: Fix an illegal string copyFrank Kühndel2020-10-121-1/+2
| | | | | | | | | | | | This is actually an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The compiler warning was: ../../../cpukit/libmisc/monitor/mon-editor.c:342:15: warning: 'strcpy' accessing 1 byte at offsets [0, 75] and [0, 75] overlaps 1 byte at offset [0, 74] [-Wrestrict]
* libblock: Fix sparse diskSebastian Huber2020-10-121-34/+35
| | | | | | | The qsort() in sparse_disk_get_new_block() may move the appended key which invalidates the pointer. Close #4142.
* rtems: Generate <rtems/io.h>Sebastian Huber2020-10-111-114/+369
| | | | | | | | | | | | | The manager documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. This header file was generated from the items by a script. Change license to BSD-2-Clause according to file histories and documentation re-licensing agreement. Update #3899. Update #3993.
* libblock: Add commentSebastian Huber2020-10-111-0/+2
|
* mghttpd/mongoose: Fix string truncation warningFrank Kühndel2020-10-101-2/+2
| | | | | | | | This fixes the compiler warning below. ../../../cpukit/mghttpd/mongoose.c:1919:45: warning: '.gz' directive output may be truncated writing 3 bytes into a region of size between 1 and 255 [-Wformat-truncation=]
* libblock: Fix string truncation warningFrank Kühndel2020-10-101-1/+1
| | | | | | | | | | | This patch does not only fix the compiler warning below. memcpy() is the better function at this place as the terminating NUL character is never copied here. Instead more characters will be appended to the 'logical_disk_name' later on. ../../../cpukit/libblock/src/bdpart-register.c:41:5: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
* capture: Fix unaligned pointer value warningFrank Kühndel2020-10-101-4/+4
| | | | | | | | | | | | | | rtems_name is a four byte integer. Giving an rtems_name as value instead of a pointer to ctrace_task_name_add() fixes not only the compiler warning but it is also a bit more safe For those who have asked for the warning: ../../../cpukit/libmisc/capture/capture_support.c:352:49: warning: taking address of packed member of 'struct rtems_capture_task_record' may result in an unaligned pointer value [-Waddress-of-packed-member] 352 | ctrace_task_name_add (rec_out->task_id, &task_rec.name); | ^~~~~~~~~~~~~~
* rtems: Improve RTEMS_NO_RETURN attributeSebastian Huber2020-10-1028-87/+47
| | | | | | | | | | | Provide RTEMS_NO_RETURN also in case RTEMS_DEBUG is defined to prevent errors like this: error: no return statement in function returning non-void [-Werror=return-type] Use C11 and C++11 standard means to declare a no-return function. Close #4122.
* librtemscxx: Fix white space to match the coding standardChris Johns2020-10-094-208/+208
|
* librtemscxx: Add join() and detach() to the threadChris Johns2020-10-093-14/+43
| | | | - Do not start threads detached
* doxygen: Add "Generated from ..." commentsSebastian Huber2020-10-081-4/+339
| | | | | | Improve file header comment. Update #3994.
* rtems: Add "Generated from ..." commentsSebastian Huber2020-10-081-4/+13
| | | | | | Improve file header comment. Update #3993.
* cpukit/librcxx: Add a C++ thread interface with attributesChris Johns2020-10-084-0/+1037
|
* rtems: Add RTEMS_PARTITION_ALIGNMENTSebastian Huber2020-10-071-0/+9
| | | | Update #4105.
* score: Add AArch64 portKinsey Moore2020-10-0517-1/+2756
| | | | | This adds a CPU port for AArch64(ARMv8) with support for exceptions and interrupts.
* build: Add testopts.h to configure scriptSebastian Huber2020-10-052-0/+70
| | | | Close #4120.
* Decouple the C Program Heap initializationSebastian Huber2020-10-018-45/+214
| | | | | | | Before this patch RTEMS_Malloc_Initialize() had a fixed dependency on _Workspace_Area. Introduce _Workspace_Malloc_initializer to have this dependency only if CONFIGURE_UNIFIED_WORK_AREAS is defined by the application configuration.
* rtems: Canonicalize name and id checksSebastian Huber2020-10-014-14/+22
| | | | | | Check the name followed by the id check in all create directives. Compare pointers against NULL. Fix formatting.
* rtems: Remove rtems_io_driver_io_error()Sebastian Huber2020-09-291-11/+0
| | | | The implementation was added and removed in 2009.
* Fixing bug in line editing of the shell with CTRL-U.Frank Kühndel2020-09-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes a tiny bug in the command line editing of the RTEMS shell. Typing CTRL-U in the shell should remove all characters left of the cursor. After pressing CTRL-U, the current implementation does wrongly place the cursor at the end of the line instead at its beginning. To reproduce the bug, start the shell and type 'abc123' (no <RETURN>): > ~/src/rtems $ qemu-system-arm -net none -nographic -M realview-pbx-a9 \ -m 256M -kernel build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl10.exe > *** BEGIN OF TEST libdl (RTL) 10 *** > *** TEST VERSION: 6.0.0.d9bdf166644f612dd628fe4951c12c6f8e94ba5f > *** TEST STATE: USER_INPUT > *** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API RTEMS_SMP > *** TEST TOOLS: 10.2.1 20200904 \ (RTEMS 6, RSB 31f936a7b74d60bda609a9960c6e1a705ba54974, Newlib a0d7982) > RTL (libdl) commands: dl, rtl > > RTEMS Shell on /dev/foobar. Use 'help' to list commands. > SHLL [/] # abc123 Then move the cursor onto the '1' by hitting three times the <ARROW-LEFT> key. Next type <CTRL>-U: > SHLL [/] # 123 Note that the cursor is at the end of the line (after '3') instead of correctly at the beginning (on the '1'), now. Continuing typing 'echo ' incorrectly results in the output: > SHLL [/] # 123echo 123 The patch changes this behavior so that the cursor in the second last step will be on the '1' and typing 'echo ' will then correctly reflected as: > SHLL [/] # echo 123 Close #4097.
* doxygen: Fix use of getchark() and rtems_putc()Sebastian Huber2020-09-281-6/+6
|
* rtems: Add rtems_message_queue_construct()Sebastian Huber2020-09-2811-152/+523
| | | | | | | | | | | In contrast to message queues created by rtems_message_queue_create(), the message queues constructed by this directive use a user-provided message buffer storage area. Add RTEMS_MESSAGE_QUEUE_BUFFER() to define a message buffer type for message buffer storage areas. Update #4007.
* rtems: Remove Message_queue_Control::attribute_setSebastian Huber2020-09-284-10/+26
| | | | | | | Add Message_queue_Control::is_global if RTEMS_MULTIPROCESSING is defined. This reduces the Message_queue_Control size in standard RTEMS configurations. Update #4007.
* score: Add <rtems/score/coremsgbuffer.h>Sebastian Huber2020-09-283-38/+98
| | | | | | | | | | Move the CORE_message_queue_Buffer definition to a separate header file to be able to use it independent of the remaining Message Queue Handler API. Change license to BSD-2-Clause according to file history. Update #3053. Update #4007.
* score: Simplify CORE_message_queue_BufferSebastian Huber2020-09-289-74/+71
| | | | | | | | | | Merge CORE_message_queue_Buffer structure into CORE_message_queue_Buffer_control. Use a zero-length array for the actual message buffer. This reduces the structure size on all targets. Update #4007.
* score: Improve _CORE_message_queue_Initialize()Sebastian Huber2020-09-285-34/+45
| | | | | | Return a status code and differentiate between error conditions. Update #4007.
* score: Gather message queue control initializationSebastian Huber2020-09-281-16/+11
| | | | | | | Initialize the structure in a single code block after the error checks and calculations. Update #4007.
* score: Fix allocation size calculationSebastian Huber2020-09-281-51/+23
| | | | | | | | | | The previous multiplication error check is broken on 64-bit machines. Use the recommended check from SEI CERT C Coding Standard, "INT30-C. Ensure that unsigned integer operations do not wrap". Make sure the message size computation does not overflow. Update #4007.
* score: Use RTEMS_ALIGN_UP()Sebastian Huber2020-09-281-3/+4
| | | | Update #4007.
* libtest: Remove superfluous assignmentSebastian Huber2020-09-241-1/+0
| | | | Issue found by Coverity (CID 1437643).
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-07 14:11:53 +0000