summaryrefslogtreecommitdiffstats
path: root/cpukit/libmisc (follow)
Commit message (Collapse)AuthorAgeFilesLines
* stackchk: Fixed 32bit pointersStephen Clark2021-05-051-1/+2
| | | | | | Using 32bit types like uint32_t for pointers creates issues on 64 bit architectures like AArch64. Replaced occurrences of these with uintptr_t, which will work for both 32 and 64 bit architectures.
* rtems-fdt: Fixed 32bit pointersStephen Clark2021-05-051-2/+2
| | | | | | Using 32bit types like uint32_t for pointers creates issues on 64 bit architectures like AArch64. Replaced occurrences of these with uintptr_t, which will work for both 32 and 64 bit architectures.
* main_rtrace.c: Add error return when malloc failsRyan Long2021-04-291-0/+1
| | | | | | | CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save(). Closes #4329
* print-ls.c: Unused value (CID #1255346)Ryan Long2021-04-081-0/+9
| | | | | | CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340
* main_cp.c: Unused value (CID #1255344)Ryan Long2021-04-081-0/+32
| | | | | | CID 1255344: Unused value in copy(). Closes #4339
* cpukit: Remove libnetworkingVijay Kumar Banerjee2021-04-076-2929/+0
| | | | Update #3850
* gen_uuid.c: Revert previous patch (597e4f476568a225d14dfaff02074cf269ad62ac)Joel Sherrill2021-03-241-8/+3
| | | | | | | | | | The patch was: gen_uuid.c: Fix two Unchecked return value from library errors CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Reopen #4280
* rtems-fdt/rtems-fdt.c: Fix bug in loop terminationG S Niteesh Babu2021-03-211-1/+1
| | | | | The while loop, loops infinitely in case of raw FDT data. The loop condition (size) is not modified during iterations.
* main_help.c: Unchecked return value from library (CID #1437650)Ryan Long2021-03-081-1/+2
| | | | | | CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291
* main_chmod.c: Fix Unchecked return value from library (CID #1063856)Ryan Long2021-03-081-2/+5
| | | | | | | CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281
* gen_uuid.c: Fix two Unchecked return value from library errorsRyan Long2021-03-081-3/+8
| | | | | | | CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280
* main_edit.c: Fix Unchecked return value (CID #1255318)Ryan Long2021-03-081-1/+1
| | | | | | CID 1255318: Unchecked return value in display_line(). Updates #4257
* cpuusagetop.c: Fix three Missing break in switch Coverity errorsRyan Long2021-03-051-0/+3
| | | | | | | | CID 1399726: Missing break in switch in task_usage(). CID 1399728: Missing break in switch in task_usage(). CID 1399742: Missing break in switch in task_usage(). Closes #4278
* shell.c: Fix Dereference before null check (CID #1467420)Ryan Long2021-02-181-1/+4
| | | | | | CID 1467420: Dereference before null check in rtems_shell_line_editor(). Closes #4254
* shell: Add i2c and spi commandsChristian Mauderer2020-12-144-0/+533
| | | | | | | | This adds some commands that are usefull for debugging simple serial interfaces. Even if they are a complete re-implementation, the i2c* commands use a simmilar call like the Linux i2c tools.
* shell: Rename "IO" typedef for better DoxygenSebastian Huber2020-12-023-6/+6
| | | | | An automatic link from every place in the documentation which mentions "IO" to this dd command internal "IO" typedef is not really nice.
* rtems-fdt / shell - Fix string truncation warningFrank Kühndel2020-10-201-21/+19
| | | | | | | | | | | | | | The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument 267 | strncpy(path, name, namelen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ It turns out that the `strncpy()` nor the buffer `path` is needed when one uses `strncmp()` instead of `strcmp()`. This needs some change to the algorithm but has the advantage that `name` is never truncated to the size of the buffer `path`.
* Revert "rtems-fdt / shell - Fix string truncation warning"Sebastian Huber2020-10-161-19/+21
| | | | This reverts commit 355bc37ad35a7d67a7209130171febe805c67f62.
* rtems-fdt / shell - Fix string truncation warningFrank Kühndel2020-10-151-21/+19
| | | | | | | | | | | | | | | | | | | | | The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument 267 | strncpy(path, name, namelen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ It turns out that the `strncpy()` nor the buffer `path` is needed when one uses `strncmp()` instead of `strcmp()`. This needs some change to the algorithm but has the advantage that `name` is never truncated to the size of the buffer `path`. Note: rtems-fdt.c, rtems-fdt-shell.c and cpukit/include/rtems/rtems-fdt.h seem to be dead code. They implement a shell command `fdt` but that command is not part of the shell nor of any macro in cpukit/include/rtems/shellconfig.h.
* shell/main_edit.c: Fix string truncation warningFrank Kühndel2020-10-151-5/+7
| | | | | | | | | | | | Using strlcpy() instead of strncpy(): 1) Prevents the compiler warnings 2) Ensures, the string is NUL terminated. 3) Avoids that strncpy() unnecessary fills the unused part of the buffer with 0 bytes. (Note that realpath() also returns NULL if the file does not exist - that happens always if someone creates a new file with the editor of the shell.)
* shell/main_edit.c: Fix use of wrong constantFrank Kühndel2020-10-151-1/+2
| | | | | realpath() requires a buffer of size PATH_MAX and not of size FILENAME_MAX according to 'man realpath (3)'.
* shell/shell.c: Fix illegal string copyFrank Kühndel2020-10-151-4/+14
| | | | | | | | | | | | | This is an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The copiler warning was: ../../../cpukit/libmisc/shell/shell.c:626:13: warning: 'strcpy' accessing between 1 and 2147483645 bytes at offsets 0 and [1, 2147483647] may overlap up to 2147483644 bytes at offset [1, 2147483644] [-Wrestrict]
* shell/shell.c: Fix an implicit type castFrank Kühndel2020-10-151-1/+3
| | | | | With some compiler warnings enabled, the implicit cast may trigger a compiler warning. The explicit cast avoids this.
* shell: Remove not functioning fdisk mount/unmountFrank Kühndel2020-10-121-31/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix. The 'fdisk' command itself is not removed. The reasons for removing the sub-commands (instead of fixing the issue) are: 1) The bug has been introduced on 2010-May-31 with commit 29e92b090c8bc35745aa5c89231ce806bcb11e57. Since ten years no one can use this feature, nor has anybody complained about it. 2) Besides of the 'fdisk' 'mount' sub-command, the shell has the usual 'mount' and 'unmount' commands which can serve as substitutes. 3) There are additional minor issues (see further down) which needed to be addressed when the file will be kept. What follows below is the precise bug description. The bug is in function rtems_bdpart_mount() which is only be used by the 'fdisk' shell command to mount all partitions of a disk with a single command: > fdisk DISK_NAME mount > mounts the file system of each partition of the disk > > fdisk DISK_NAME unmount > unmounts the file system of each partition of the disk The whole command does not work because in file cpukit/libblock/src/bdpart-mount.c line 103 specifies the file system type of each partition to be "msdos". Yet, "msdos" does not exist. The name must be "dosfs". Beside of this fundamental problem, there are more issues with the code in bdpart-mount.c: 1) The function returns RTEMS_SUCCESSFUL despite the mount always fails. 2) The reason for errors is not written to the terminal. 3) The directory '/mnt' is created but not deleted later on (failure or not). 3) There is no documentation about this special 'fdisk' feature in the RTEMS Shell Guide ('fdisk' is mentioned but its documentation is a bit short): https://docs.rtems.org/branches/master/shell/ file_and_directory.html#fdisk-format-disk 4) Only "msdos" formatted partitions can be mounted and all partitions are mounted read-only. This is hard coded and cannot be changed by options. Moreover, there is no information about this to the user of the shell (i.e. using 'fdisk' mount requires insider knowledge). How to reproduce: 1) For testing, I use the 'testsuites/samples/fileio.exe' sample with qemu: > cd rtems > env QEMU_AUDIO_DRV="none" qemu-system-arm -net none -nographic \ > -M realview-pbx-a9 -m 256M -kernel \ > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe 2) Type any key to stop the timer and enter the sample tool. Type 's' to enter the shell, login as 'root' with the password shown in the terminal. 3) Type the following shell commands (they create a RAM disk, partition it, register it, format it and try to mount it): > mkrd > fdisk /dev/rda fat32 16 write mbr > fdisk /dev/rda register > mkdos /dev/rda1 > fdisk /dev/rda mount 4) The last line above is the command which fails - without an error message. There exists a '/mnt' directory but no '/mnt/rda1' directory as it should be: > ls -la /mnt 5) If you change line 103 of 'cpukit/libblock/src/bdpart-mount.c' from "msdos" to "dosfs", compile and build the executable and re-run the above test, '/mnt/rda1' exists (but the file system is mounted read-only). Close #4131
* cpukit/libmisc/monitor: Fix an illegal string copyFrank Kühndel2020-10-121-1/+2
| | | | | | | | | | | | This is actually an illegal use of strcpy() because one is not allowed to use this function with overlapping source and destination buffers; whereas memmove() is explicitly designed to handle such cases. The compiler warning was: ../../../cpukit/libmisc/monitor/mon-editor.c:342:15: warning: 'strcpy' accessing 1 byte at offsets [0, 75] and [0, 75] overlaps 1 byte at offset [0, 74] [-Wrestrict]
* capture: Fix unaligned pointer value warningFrank Kühndel2020-10-101-4/+4
| | | | | | | | | | | | | | rtems_name is a four byte integer. Giving an rtems_name as value instead of a pointer to ctrace_task_name_add() fixes not only the compiler warning but it is also a bit more safe For those who have asked for the warning: ../../../cpukit/libmisc/capture/capture_support.c:352:49: warning: taking address of packed member of 'struct rtems_capture_task_record' may result in an unaligned pointer value [-Waddress-of-packed-member] 352 | ctrace_task_name_add (rec_out->task_id, &task_rec.name); | ^~~~~~~~~~~~~~
* Fixing bug in line editing of the shell with CTRL-U.Frank Kühndel2020-09-281-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes a tiny bug in the command line editing of the RTEMS shell. Typing CTRL-U in the shell should remove all characters left of the cursor. After pressing CTRL-U, the current implementation does wrongly place the cursor at the end of the line instead at its beginning. To reproduce the bug, start the shell and type 'abc123' (no <RETURN>): > ~/src/rtems $ qemu-system-arm -net none -nographic -M realview-pbx-a9 \ -m 256M -kernel build/arm/realview_pbx_a9_qemu/testsuites/libtests/dl10.exe > *** BEGIN OF TEST libdl (RTL) 10 *** > *** TEST VERSION: 6.0.0.d9bdf166644f612dd628fe4951c12c6f8e94ba5f > *** TEST STATE: USER_INPUT > *** TEST BUILD: RTEMS_DEBUG RTEMS_NETWORKING RTEMS_POSIX_API RTEMS_SMP > *** TEST TOOLS: 10.2.1 20200904 \ (RTEMS 6, RSB 31f936a7b74d60bda609a9960c6e1a705ba54974, Newlib a0d7982) > RTL (libdl) commands: dl, rtl > > RTEMS Shell on /dev/foobar. Use 'help' to list commands. > SHLL [/] # abc123 Then move the cursor onto the '1' by hitting three times the <ARROW-LEFT> key. Next type <CTRL>-U: > SHLL [/] # 123 Note that the cursor is at the end of the line (after '3') instead of correctly at the beginning (on the '1'), now. Continuing typing 'echo ' incorrectly results in the output: > SHLL [/] # 123echo 123 The patch changes this behavior so that the cursor in the second last step will be on the '1' and typing 'echo ' will then correctly reflected as: > SHLL [/] # echo 123 Close #4097.
* rtems: Remove Message_queue_Control::attribute_setSebastian Huber2020-09-281-1/+15
| | | | | | | Add Message_queue_Control::is_global if RTEMS_MULTIPROCESSING is defined. This reduces the Message_queue_Control size in standard RTEMS configurations. Update #4007.
* capture: Move default trace dataSebastian Huber2020-09-202-28/+37
| | | | | | | Provide the default trace data in a separate file to avoid issues on targets with a small-data area. Close #3883.
* dd(1): Use a local swapbytes() function.eadler2020-08-201-1/+16
| | | | | | | swab(3) has restrict qualifiers for src and dst. Avoid relying on undefined overlapping swab behavior. Obtained From: OpenBSD
* Fix -Wchar-subscripts warningsAschref Ben Thabet2020-08-201-4/+4
| | | | | | | The argument to the ctype functions must be an int and the value of the character must be representable as an unsigned char or equal to the value of the macro EOF. If the argument has any other value, the behavior is undefined.
* shell: Only clear std handles when the shell task exitsChris Johns2020-08-081-4/+22
| | | | | Clearing the std file handles when the main loop exited crashes telnetd as it reuses its session threads.
* rtems: Add rtems_get_copyright_notice()Sebastian Huber2020-05-061-2/+12
| | | | Update #3973.
* Use rtems_get_version_string()Sebastian Huber2020-05-061-3/+3
| | | | Update #3970.
* doxygen: Switch @brief and @ingroupSebastian Huber2020-04-2829-29/+58
| | | | This order change fixes the Latex documentation build via Doxygen.
* Canonicalize config.h includeSebastian Huber2020-04-1612-20/+20
| | | | | | | | Use the following variant which was already used by most source files: #ifdef HAVE_CONFIG_H #include "config.h" #endif
* libmisc/shell: Fix the handling of joel scripts in telnetChris Johns2020-04-151-101/+268
| | | | | | | | | | | | - Fix the passing of std[in/out] to child threads - Fix deleting of managed memory in the key destructor - Only set the key in the main loop thread - Only allocate a shell env outside of the main loop - Fix memory leak if the task start fails - Remove error level from shell env, it cannot be returned this way. Add exit_code but the API is broken so it cannot be returned. Closes #3859
* score: Fix context switch extensions (SMP)Sebastian Huber2020-02-281-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In uniprocessor and SMP configurations, the context switch extensions were called during _Thread_Do_dispatch(): void _Thread_Do_dispatch( Per_CPU_Control *cpu_self, ISR_Level level ) { Thread_Control *executing; executing = cpu_self->executing; ... do { Thread_Control *heir; heir = _Thread_Get_heir_and_make_it_executing( cpu_self ); ... _User_extensions_Thread_switch( executing, heir ); ... _Context_Switch( &executing->Registers, &heir->Registers ); ... } while ( cpu_self->dispatch_necessary ); ... } In uniprocessor configurations, this is fine and the context switch extensions are called for all thread switches except the very first thread switch to the initialization thread. However, in SMP configurations, the context switch may be invalidated and updated in the low-level _Context_Switch() routine. See: https://docs.rtems.org/branches/master/c-user/symmetric_multiprocessing_services.html#thread-dispatch-details In case such an update happens, a thread will execute on the processor which was not seen in the previous call of the context switch extensions. This can confuse for example event record consumers which use events generated by a context switch extension. Fixing this is not straight forward. The context switch extensions call must move after the low-level context switch. The problem here is that we may end up in _Thread_Handler(). Adding the context switch extensions call to _Thread_Handler() covers now also the thread switch to the initialization thread. We also have to save the last executing thread (ancestor) of the processor. Registers or the stack cannot be used for this purpose. We have to add it to the per-processor information. Existing extensions may be affected, since now context switch extensions use the stack of the heir thread. The stack checker is affected by this. Calling the thread switch extensions in the low-level context switch is difficult since at this point an intermediate stack is used which is only large enough to enable servicing of interrupts. Update #3885.
* config: Add _SMP_Is_enabledSebastian Huber2020-02-251-1/+1
| | | | | | | | | | Move the is SMP enabled configuration constant out of the configuration table. Since this was the last configuration constant in rtems_configuration_table, remove this type. Update #3875.
* config: Simplify initialization task configSebastian Huber2020-02-252-4/+8
| | | | | | | | | | With the removal of the CONFIGURE_HAS_OWN_INIT_TASK_TABLE configuration option at most one Classic API user initialization task can be configured. Provide an RTEMS API configuration table for backward compatibility. Update #3873.
* monitor: Use proper API for all config constantsSebastian Huber2020-02-171-7/+4
|
* stackchk: Add RTEMS_SYSINIT_ISR_STACKSebastian Huber2020-02-041-2/+2
| | | | | | | Use a dedicated system initialization step for the stack checker interrupt stack support. Update #3838.
* libmisc/top: Fix the idle time and priorities on SMPChris Johns2019-12-191-11/+27
| | | | | | | - This patch is based on the patch attached to #3552 submitted by jameszxj. Closes #3552
* config: CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORSSebastian Huber2019-12-191-1/+1
| | | | | | | Rename CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS into CONFIGURE_MAXIMUM_FILE_DESCRIPTORS. Update #3753.
* config: Add _MPCI_ConfigurationSebastian Huber2019-12-133-15/+7
| | | | | | | Replace the user MPCI configuration table with a system provided _MPCI_Configuration. Update #3735.
* rtems: Optimize semaphore control blockSebastian Huber2019-12-111-5/+9
| | | | | | | Move variant, discipline, and global information to flags stored in a node pointer of active semaphores. Update #3833.
* untar: Properly make parent pathSebastian Huber2019-11-261-144/+46
| | | | Close #3823.
* untar: Make path also for symbolic linksSebastian Huber2019-11-251-9/+8
| | | | Close #3823.
* untar: Unify untar supportSebastian Huber2019-11-251-94/+87
| | | | Update #3823.
* Move feature macro before "config.h" includeSebastian Huber2019-11-194-9/+12
| | | | | | | This allows to use header includes in "config.h" to reduce the build configuration checks. Update #3818.
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-27 12:07:03 +0000