summaryrefslogtreecommitdiffstats
path: root/cpukit/libblock (follow)
Commit message (Collapse)AuthorAgeFilesLines
* cpukit: occured -> occurredSebastian Huber2021-07-161-1/+1
|
* libblock: Add rtems_bdbuf_peek()Christian Mauderer2021-03-262-22/+64
| | | | | | | | Adds a peek function that allows (for example) a file system to suggest the next blocks that should be used for read ahead. This can increase the read speed of fragmented files. Update #3689
* shell: Remove not functioning fdisk mount/unmountFrank Kühndel2020-10-121-184/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix. The 'fdisk' command itself is not removed. The reasons for removing the sub-commands (instead of fixing the issue) are: 1) The bug has been introduced on 2010-May-31 with commit 29e92b090c8bc35745aa5c89231ce806bcb11e57. Since ten years no one can use this feature, nor has anybody complained about it. 2) Besides of the 'fdisk' 'mount' sub-command, the shell has the usual 'mount' and 'unmount' commands which can serve as substitutes. 3) There are additional minor issues (see further down) which needed to be addressed when the file will be kept. What follows below is the precise bug description. The bug is in function rtems_bdpart_mount() which is only be used by the 'fdisk' shell command to mount all partitions of a disk with a single command: > fdisk DISK_NAME mount > mounts the file system of each partition of the disk > > fdisk DISK_NAME unmount > unmounts the file system of each partition of the disk The whole command does not work because in file cpukit/libblock/src/bdpart-mount.c line 103 specifies the file system type of each partition to be "msdos". Yet, "msdos" does not exist. The name must be "dosfs". Beside of this fundamental problem, there are more issues with the code in bdpart-mount.c: 1) The function returns RTEMS_SUCCESSFUL despite the mount always fails. 2) The reason for errors is not written to the terminal. 3) The directory '/mnt' is created but not deleted later on (failure or not). 3) There is no documentation about this special 'fdisk' feature in the RTEMS Shell Guide ('fdisk' is mentioned but its documentation is a bit short): https://docs.rtems.org/branches/master/shell/ file_and_directory.html#fdisk-format-disk 4) Only "msdos" formatted partitions can be mounted and all partitions are mounted read-only. This is hard coded and cannot be changed by options. Moreover, there is no information about this to the user of the shell (i.e. using 'fdisk' mount requires insider knowledge). How to reproduce: 1) For testing, I use the 'testsuites/samples/fileio.exe' sample with qemu: > cd rtems > env QEMU_AUDIO_DRV="none" qemu-system-arm -net none -nographic \ > -M realview-pbx-a9 -m 256M -kernel \ > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe 2) Type any key to stop the timer and enter the sample tool. Type 's' to enter the shell, login as 'root' with the password shown in the terminal. 3) Type the following shell commands (they create a RAM disk, partition it, register it, format it and try to mount it): > mkrd > fdisk /dev/rda fat32 16 write mbr > fdisk /dev/rda register > mkdos /dev/rda1 > fdisk /dev/rda mount 4) The last line above is the command which fails - without an error message. There exists a '/mnt' directory but no '/mnt/rda1' directory as it should be: > ls -la /mnt 5) If you change line 103 of 'cpukit/libblock/src/bdpart-mount.c' from "msdos" to "dosfs", compile and build the executable and re-run the above test, '/mnt/rda1' exists (but the file system is mounted read-only). Close #4131
* libblock: Fix sparse diskSebastian Huber2020-10-121-34/+35
| | | | | | | The qsort() in sparse_disk_get_new_block() may move the appended key which invalidates the pointer. Close #4142.
* libblock: Add commentSebastian Huber2020-10-111-0/+2
|
* libblock: Fix string truncation warningFrank Kühndel2020-10-101-1/+1
| | | | | | | | | | | This patch does not only fix the compiler warning below. memcpy() is the better function at this place as the terminating NUL character is never copied here. Instead more characters will be appended to the 'logical_disk_name' later on. ../../../cpukit/libblock/src/bdpart-register.c:41:5: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
* dosfs: Fix memory leak on failed mounts.Christian Mauderer2020-08-041-0/+1
| | | | | | | | | | | | | | | | | | | | Currently if mount fails, a converter isn't destroyed. We have to take care of two cases: 1. The user doesn't provide a converter. In this case mounting a dosfs creates a default converter. This patch makes sure that the converter is destroyed again if mount failes for this case. 2. The user provides a converter. In this case it's not sure that the dosfs specific routines are reached because mount can fail before that. Therefore the user has to destroy the converter himself again. This patch adds a documentation for that and implements it in the media server. Closes #4042.
* media-server: Add ability for retry.Christian Mauderer2020-07-171-13/+17
| | | | | | This adds the possibility to request a retry in the media-listener if an operation failed. Usefull for example if you want to automatically reformat a disk if it wasn't possible to mount it.
* doxygen: Switch @brief and @ingroupSebastian Huber2020-04-2818-18/+36
| | | | This order change fixes the Latex documentation build via Doxygen.
* Canonicalize config.h includeSebastian Huber2020-04-1616-21/+21
| | | | | | | | Use the following variant which was already used by most source files: #ifdef HAVE_CONFIG_H #include "config.h" #endif
* build: Merge libblock/Makefile.amSebastian Huber2018-10-091-40/+0
|
* Use rtems_task_exit()Sebastian Huber2018-10-021-3/+3
| | | | | Update #3530. Update #3533.
* libblock: Add RTEMS_DEPRECATEDSebastian Huber2018-08-074-4/+15
| | | | Close #3358.
* libblock: Use rtems_blkdev_create_partition()Sebastian Huber2018-08-071-14/+2
| | | | Update #3358.
* flashdisk: Use rtems_blkdev_create()Sebastian Huber2018-08-071-47/+22
| | | | Update #3358.
* nvdisk: Use rtems_blkdev_create()Sebastian Huber2018-08-071-51/+19
| | | | Update #3358.
* ramdisk: Use rtems_blkdev_create()Sebastian Huber2018-08-072-34/+7
| | | | Update #3358.
* libblock: Init deps in rtems_blkdev_create()Sebastian Huber2018-05-181-4/+10
| | | | Update #3358.
* libblock: Use self-contained mutex for mediaSebastian Huber2018-02-071-68/+35
| | | | Update #2843.
* libblock: Use self-contained mutex for sparse diskSebastian Huber2018-02-071-28/+4
| | | | Update #2843.
* libblock: Use self-contained mutex for flashdiskSebastian Huber2018-02-071-74/+57
| | | | Update #2843.
* libblock: Use self-contained mutex for nvdiskSebastian Huber2018-02-071-53/+39
| | | | Update #2843.
* libblock: Use self-contained mutex and cond varSebastian Huber2018-02-021-282/+42
| | | | Update #2843.
* libblock: Use self-contained mutex for disk lockSebastian Huber2018-02-021-71/+30
| | | | Update #2843.
* Remove make preinstallChris Johns2018-01-2511-3863/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A speciality of the RTEMS build system was the make preinstall step. It copied header files from arbitrary locations into the build tree. The header files were included via the -Bsome/build/tree/path GCC command line option. This has at least seven problems: * The make preinstall step itself needs time and disk space. * Errors in header files show up in the build tree copy. This makes it hard for editors to open the right file to fix the error. * There is no clear relationship between source and build tree header files. This makes an audit of the build process difficult. * The visibility of all header files in the build tree makes it difficult to enforce API barriers. For example it is discouraged to use BSP-specifics in the cpukit. * An introduction of a new build system is difficult. * Include paths specified by the -B option are system headers. This may suppress warnings. * The parallel build had sporadic failures on some hosts. This patch removes the make preinstall step. All installed header files are moved to dedicated include directories in the source tree. Let @RTEMS_CPU@ be the target architecture, e.g. arm, powerpc, sparc, etc. Let @RTEMS_BSP_FAMILIY@ be a BSP family base directory, e.g. erc32, imx, qoriq, etc. The new cpukit include directories are: * cpukit/include * cpukit/score/cpu/@RTEMS_CPU@/include * cpukit/libnetworking The new BSP include directories are: * bsps/include * bsps/@RTEMS_CPU@/include * bsps/@RTEMS_CPU@/@RTEMS_BSP_FAMILIY@/include There are build tree include directories for generated files. The include directory order favours the most general header file, e.g. it is not possible to override general header files via the include path order. The "bootstrap -p" option was removed. The new "bootstrap -H" option should be used to regenerate the "headers.am" files. Update #3254.
* posix: Implement self-contained POSIX mutexSebastian Huber2017-10-051-2/+4
| | | | | | | | POSIX mutexes are now available in all configurations and no longer depend on --enable-posix. Update #2514. Update #3112.
* Fix IO control request typeSebastian Huber2017-07-281-1/+1
|
* posix/mmap: Add support for file handler and MAP_ANONKevin Kirspel2017-07-141-0/+1
| | | | | | | | | | | Added a mmap file handler to struct _rtems_filesystem_file_handlers_r. Updated each file handler object to support the default mmap handler. Updated mmap() to call the mmap handler for MAP_SHARED. Added a mmap file handler for shm Added support for MAP_ANON in mmap(). Updates #2859
* libblock: FreeBSD kernel-space compatibilitySebastian Huber2017-06-081-1/+1
| | | | Update #2833.
* Use <sys/endian.h>Sebastian Huber2017-01-241-13/+5
| | | | Update #2803.
* libblock: Fix for RTEMS_DEBUGSebastian Huber2016-12-121-0/+1
|
* libblock: Fix for RTEMS_DEBUGSebastian Huber2016-11-241-0/+2
|
* libblock: Use proper semaphore attr for mutexSebastian Huber2016-06-061-2/+1
| | | | Close #1452.
* cpukit, testsuite: Add rtems_printf and rtems_printer support.Chris Johns2016-05-253-17/+14
| | | | | | | | | | | | | | | | | | | This change adds rtems_printf and related functions and wraps the RTEMS print plugin support into a user API. All references to the plugin are removed and replaced with the rtems_printer interface. Printk and related functions are made to return a valid number of characters formatted and output. The function attribute to check printf functions has been added to rtems_printf and printk. No changes to remove warrnings are part of this patch set. The testsuite has been moved over to the rtems_printer. The testsuite has a mix of rtems_printer access and direct print control via the tmacros.h header file. The support for begink/endk has been removed as it served no purpose and only confused the code base. The testsuite has not been refactored to use rtems_printf. This is future work.
* libblock: Drop superfluous <stdlib.h> includeSebastian Huber2016-04-073-1/+2
| | | | | | Drop superfluous <stdlib.h> include from <rtems/diskdevs.h> since this leads to conflicts with the latest Newlib in case this header file is used in the FreeBSD kernel space, e.g. for USB mass storage support.
* libblock: Fix ramdisk::free_at_delete_request initSebastian Huber2016-01-151-1/+1
| | | | | Avoid uninitialized ramdisk::free_at_delete_request. The error was visible in sporadic libtests/block01 failures.
* libblock: Print block sizes and countSebastian Huber2015-11-023-0/+22
|
* libblock: Avoid NULL pointer accessSebastian Huber2015-11-021-1/+3
|
* basdefs.h: Add and use RTEMS_UNUSEDSebastian Huber2015-10-269-27/+27
|
* basdefs.h: Add and use RTEMS_DEPRECATEDSebastian Huber2015-10-261-3/+3
|
* libblock: Fix warningSebastian Huber2015-03-051-2/+1
|
* IMFS: Replace node union with individual structSebastian Huber2015-01-271-11/+10
| | | | | | This reduces the average node size. Add and use IMFS_GENERIC_INITIALIZER().
* bdbuf: Fix race condition with sync active flagSebastian Huber2014-11-281-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug report by Oleg Kravtsov: In rtems_bdbuf_swapout_processing() function there is the following lines: if (bdbuf_cache.sync_active && !transfered_buffers) { rtems_id sync_requester; rtems_bdbuf_lock_cache (); ... } Here access to bdbuf_cache.sync_active is not protected with anything. Imagine the following test case: 1. Task1 releases buffer(s) with bdbuf_release_modified() calls; 2. After a while swapout task starts and flushes all buffers; 3. In the end of that swapout flush we are before that part of code, and assume there is task switching (just before "if (bdbuf_cache.sync_active && !transfered_buffers)"); 4. Some other task (with higher priority) does bdbuf_release_modified and rtems_bdbuf_syncdev(). This task successfully gets both locks sync and pool (in rtems_bdbuf_syncdev() function), sets sync_active to true and starts waiting for RTEMS_BDBUF_TRANSFER_SYNC event with only sync lock got. 5. Task switching happens again and we are again before "if (bdbuf_cache.sync_active && !transfered_buffers)". As the result we check sync_active and we come inside that "if" statement. 6. The result is that we send RTEMS_BDBUF_TRANSFER_SYNC event! Though ALL modified messages of that task are not flushed yet! close #1485
* bdbuf: Use rtems_cache_aligned_malloc()Sebastian Huber2014-11-251-9/+6
|
* bdbuf: Use rtems_cache_get_data_line_size()Sebastian Huber2014-11-201-9/+1
|
* Add and use RTEMS_CONTAINER_OF()Sebastian Huber2014-08-051-2/+2
|
* libblock: Avoid recursive mutexSebastian Huber2014-06-031-9/+10
|
* libblock: Add RTEMS_BDBUF_USE_PTHREADRalf Kirchner2014-06-022-62/+190
| | | | | | Use the PTHREAD mutexes and condition variables if available. This helps on SMP configurations to avoid the home grown condition variables via disabled preemption.
* libblock: Use pthread_once() for initializationRalf Kirchner2014-06-021-29/+25
| | | | | | Enabling and disabling preemption as done for single core will not work for SMP. In the bdbuf initialization preemption handling can be avoided in general by using pthread_once().
* score: Add and use RTEMS_ZERO_LENGTH_ARRAYSebastian Huber2014-04-152-2/+2
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-27 17:38:39 +0000