diff options
author | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2019-04-12 11:13:32 +0200 |
---|---|---|
committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2019-04-12 11:15:40 +0200 |
commit | ef9d20f691cd8bd2135a6d513bf0e2372ba6c93b (patch) | |
tree | 29987a4572519f3d9b94e0e9309fdcfc78613396 /testsuites/smptests | |
parent | bsp/imx: CLOCK_DRIVER_USE_ONLY_BOOT_PROCESSOR (diff) | |
download | rtems-ef9d20f691cd8bd2135a6d513bf0e2372ba6c93b.tar.bz2 |
score: More robust _SMP_Multicast_action()
If the caller already disabled interrupts, then do not disable thread
dispatching. Calling _SMP_Multicast_action() with interrupts disabled
is a questionable use case.
Diffstat (limited to '')
-rw-r--r-- | testsuites/smptests/smpcache01/init.c | 5 | ||||
-rw-r--r-- | testsuites/smptests/smpmulticast01/init.c | 3 |
2 files changed, 1 insertions, 7 deletions
diff --git a/testsuites/smptests/smpcache01/init.c b/testsuites/smptests/smpcache01/init.c index e9cee1eec5..878a015bf1 100644 --- a/testsuites/smptests/smpcache01/init.c +++ b/testsuites/smptests/smpcache01/init.c @@ -126,15 +126,12 @@ static void call_tests_isr_disabled( SMP_barrier_State *bs ) broadcast_test_init(); for (i = 0; i < RTEMS_ARRAY_SIZE( test_cases ); ++i) { - Per_CPU_Control *cpu_self; - ISR_Level isr_level; + ISR_Level isr_level; - cpu_self = _Thread_Dispatch_disable(); _ISR_Local_disable( isr_level ); barrier( bs ); ( *test_cases[ i ] )(); _ISR_Local_enable( isr_level ); - _Thread_Dispatch_enable( cpu_self ); barrier( bs ); } diff --git a/testsuites/smptests/smpmulticast01/init.c b/testsuites/smptests/smpmulticast01/init.c index 3f3f7dc3fc..f8e74e22cc 100644 --- a/testsuites/smptests/smpmulticast01/init.c +++ b/testsuites/smptests/smpmulticast01/init.c @@ -59,14 +59,11 @@ static void multicast_action_irq_disabled( void *arg ) { - Per_CPU_Control *cpu_self; rtems_interrupt_level level; - cpu_self = _Thread_Dispatch_disable(); rtems_interrupt_local_disable(level); _SMP_Multicast_action(targets, handler, arg); rtems_interrupt_local_enable(level); - _Thread_Dispatch_enable(cpu_self); } static void multicast_action_dispatch_disabled( |