diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2017-02-24 10:51:05 +1100 |
|---|---|---|
| committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2018-07-19 07:01:10 +0200 |
| commit | 6dbbd277d900c2d8fc1be7b0c60e82843c554418 (patch) | |
| tree | 7bd19bdf100994c919eb9c20371bc01369d82de2 /cpukit | |
| parent | libfdt: add missing errors to fdt_strerror() (diff) | |
| download | rtems-6dbbd277d900c2d8fc1be7b0c60e82843c554418.tar.bz2 | |
libfdt: Remove undefined behaviour setting empty properties
The standard way of setting an empty property using libfdt is:
fdt_setprop(fdt, nodeoffset, propname, NULL, 0);
However, the implementation of this includes an unconditional:
memcpy(prop->data, NULL, 0);
Which although it will be a no-op (which is what we want) on many platforms
is technically undefined behaviour. Correct this, so that when passing
a 0 length, passing a NULL pointer as the value to fdt_setprop() is
definitely safe. This should quiet static checkers which complain about
this.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'cpukit')
| -rw-r--r-- | cpukit/dtc/libfdt/fdt_rw.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c index 2eed4f5838..3fd5847377 100644 --- a/cpukit/dtc/libfdt/fdt_rw.c +++ b/cpukit/dtc/libfdt/fdt_rw.c @@ -283,7 +283,8 @@ int fdt_setprop(void *fdt, int nodeoffset, const char *name, if (err) return err; - memcpy(prop->data, val, len); + if (len) + memcpy(prop->data, val, len); return 0; } |