score: Remove fatal is internal indicator

The fatal is internal indicator is redundant since the fatal source and
error code uniquely identify a fatal error.  Keep the fatal user
extension is internal parameter for backward compatibility and set it to
false always.

Update #2825.

4 files changed, 5 insertions, 12 deletions

diff --git a/cpukit/score/include/rtems/score/interr.h b/cpukit/score/include/rtems/score/interr.h
index 0bd1eec831..b030a228ab 100644
--- a/cpukit/score/include/rtems/score/interr.h
+++ b/cpukit/score/include/rtems/score/interr.h
@@ -182,8 +182,6 @@ typedef CPU_Uint32ptr Internal_errors_t;
 typedef struct {
   /** This is the source of the error. */
   Internal_errors_Source  the_source;
-  /** This indicates if the error is internal of external. */
-  bool                    is_internal;
   /** This is the error code. */
   Internal_errors_t       the_error;
 } Internal_errors_Information;
@@ -225,16 +223,13 @@ extern Internal_errors_Information _Internal_errors_What_happened;
  *
  * @param[in] the_source The fatal source indicating the subsystem the fatal
  * condition originated in.
- * @param[in] is_internal Indicates if the fatal condition was generated
- * internally to the executive.
  * @param[in] the_error The fatal error code.  This value must be interpreted
  * with respect to the source.
  *
- * @see rtems_fatal_error_occurred() and rtems_fatal().
+ * @see rtems_fatal() and _Internal_error().
  */
 void _Terminate(
   Internal_errors_Source  the_source,
-  bool                    is_internal,
   Internal_errors_t       the_error
 ) RTEMS_NO_RETURN;
 
diff --git a/cpukit/score/include/rtems/score/smpimpl.h b/cpukit/score/include/rtems/score/smpimpl.h
index 7f2de5ff70..1651a5ecc6 100644
--- a/cpukit/score/include/rtems/score/smpimpl.h
+++ b/cpukit/score/include/rtems/score/smpimpl.h
@@ -84,7 +84,7 @@ typedef enum {
 
 static inline void _SMP_Fatal( SMP_Fatal_code code )
 {
-  _Terminate( RTEMS_FATAL_SOURCE_SMP, false, code );
+  _Terminate( RTEMS_FATAL_SOURCE_SMP, code );
 }
 
 /**
diff --git a/cpukit/score/include/rtems/score/userext.h b/cpukit/score/include/rtems/score/userext.h
index e626f2f97a..61de992f23 100644
--- a/cpukit/score/include/rtems/score/userext.h
+++ b/cpukit/score/include/rtems/score/userext.h
@@ -195,8 +195,8 @@ typedef void( *User_extensions_thread_exitted_extension )(
  *
  * @param[in] source The fatal source indicating the subsystem the fatal
  * condition originated in.
- * @param[in] is_internal Indicates if the fatal condition was generated
- * internally to the executive.
+ * @param[in] is_internal This parameter is always false and provide only for
+ * backward compatibility reasons.
  * @param[in] code The fatal error code.  This value must be interpreted with
  * respect to the source.
  */
diff --git a/cpukit/score/include/rtems/score/userextimpl.h b/cpukit/score/include/rtems/score/userextimpl.h
index e6692c8749..6684c4a264 100644
--- a/cpukit/score/include/rtems/score/userextimpl.h
+++ b/cpukit/score/include/rtems/score/userextimpl.h
@@ -166,7 +166,6 @@ void _User_extensions_Thread_exitted_visitor(
 
 typedef struct {
   Internal_errors_Source source;
-  bool                   is_internal;
   Internal_errors_t      error;
 } User_extensions_Fatal_context;
 
@@ -300,11 +299,10 @@ static inline void _User_extensions_Thread_exitted( Thread_Control *executing )
 
 static inline void _User_extensions_Fatal(
   Internal_errors_Source source,
-  bool                   is_internal,
   Internal_errors_t      error
 )
 {
-  User_extensions_Fatal_context ctx = { source, is_internal, error };
+  User_extensions_Fatal_context ctx = { source, error };
 
   _User_extensions_Iterate(
     &ctx,