diff options
| author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-19 16:55:04 -0500 |
|---|---|---|
| committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2022-06-20 13:25:32 +0200 |
| commit | e1a5720264babaadabdbe956310acd845f2100e1 (patch) | |
| tree | 5a735f777df69b0c1708dbddfca52b578c328aaa /cpukit/libfs/src/jffs2/src/scan.c | |
| parent | jffs2: Remove jffs2_gc_fetch_page and jffs2_gc_release_page (diff) | |
| download | rtems-e1a5720264babaadabdbe956310acd845f2100e1.tar.bz2 | |
jffs2: Fix memory leak in jffs2_scan_eraseblock() error path
In jffs2_scan_eraseblock(), 'sumptr' is allocated through kmalloc() if
'sumlen' is larger than 'buf_size'. However, it is not deallocated in the
following execution if jffs2_fill_scan_buf() fails, leading to a memory
leak bug. To fix this issue, free 'sumptr' before returning the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to '')
| -rw-r--r-- | cpukit/libfs/src/jffs2/src/scan.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/cpukit/libfs/src/jffs2/src/scan.c b/cpukit/libfs/src/jffs2/src/scan.c index 177a0cdd3f..d5441448b0 100644 --- a/cpukit/libfs/src/jffs2/src/scan.c +++ b/cpukit/libfs/src/jffs2/src/scan.c @@ -530,8 +530,11 @@ static int jffs2_scan_eraseblock (struct jffs2_sb_info *c, struct jffs2_eraseblo err = jffs2_fill_scan_buf(c, sumptr, jeb->offset + c->sector_size - sumlen, sumlen - buf_len); - if (err) + if (err) { + if (sumlen > buf_size) + kfree(sumptr); return err; + } } } |