diff options
| author | Andre Przywara <andre.przywara@arm.com> | 2020-09-21 17:52:56 +0100 |
|---|---|---|
| committer | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2021-12-14 16:00:44 +0100 |
| commit | 28f7e7635d7f2c32c56ddb87e6da76512a5b520a (patch) | |
| tree | 74227aad423a9ee31f9afa7acb06e78ff3e81181 /cpukit/dtc/libfdt/fdt_rw.c | |
| parent | libfdt: fdt_get_string(): Fix comparison warnings (diff) | |
| download | rtems-28f7e7635d7f2c32c56ddb87e6da76512a5b520a.tar.bz2 | |
libfdt: fdt_splice_(): Fix comparison warning
With -Wsign-compare, compilers warn about a mismatching signedness
in a comparison in fdt_splice_().
Since we just established that oldlen is not negative, we can safely
cast it to an unsigned type.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Message-Id: <20200921165303.9115-8-andre.przywara@arm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to '')
| -rw-r--r-- | cpukit/dtc/libfdt/fdt_rw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c index 93e4a2b563..68887b969a 100644 --- a/cpukit/dtc/libfdt/fdt_rw.c +++ b/cpukit/dtc/libfdt/fdt_rw.c @@ -59,7 +59,7 @@ static int fdt_splice_(void *fdt, void *splicepoint, int oldlen, int newlen) if ((oldlen < 0) || (soff + oldlen < soff) || (soff + oldlen > dsize)) return -FDT_ERR_BADOFFSET; - if ((p < (char *)fdt) || (dsize + newlen < oldlen)) + if ((p < (char *)fdt) || (dsize + newlen < (unsigned)oldlen)) return -FDT_ERR_BADOFFSET; if (dsize - oldlen + newlen > fdt_totalsize(fdt)) return -FDT_ERR_NOSPACE; |