* So many patches have been posted recently on the mailing list and

	because we were unable to find correct solution to compile on various
	linux distros (due to rpcgen incompatibilities), and because the coding
	style of rdbg was rather inconsistant among various pieces of code, I
	decided to:
	    1) make some cleaning regarding global coding style (using
	       indent + manual edits),
	    2) incorporate/review the paches send by various people
	       (S. Holford, T. Strauman),
	    3) Fix the bug due to varying rpcgen code generation
	       in remdeb_svc.c,
	    4) Remove some dead code,
	    5) Apply a patches enabling to call enterRdbg imediately
	       after rdbg initialization is done,

	NB : the paches is huge but it is mainly due to coding styke chnages.
	Only few lines of codes have been really changed and they do not impact
	rdbg functionnality (AFAIKT).

	* include/rdbg/servrpc.h, include/rdbg/i386/rdbg_f.h,
	include/rdbg/m68k/rdbg_f.h, include/rdbg/powerpc/rdbg_f.h,
	src/_servtgt.c, src/awk.svc, src/excep.c, src/ptrace.c, src/rdbg.c,
	src/remdeb.x, src/servbkpt.c, src/servcon.c, src/servrpc.c,
	src/servtgt.c, src/servtsp.c, src/servutil.c, src/i386/excep_f.c,
	src/i386/rdbg_f.c, src/i386/any/Makefile.am, src/i386/any/remdeb.h,
	src/i386/any/remdeb_svc.c, src/i386/any/remdeb_xdr.c,
	src/m68k/excep_f.c, src/m68k/rdbg_f.c, src/m68k/any/Makefile.am,
	src/m68k/any/remdeb.h, src/m68k/any/remdeb_svc.c,
	src/m68k/any/remdeb_xdr.c, src/powerpc/excep_f.c, src/powerpc/rdbg_f.c,
	src/powerpc/new_exception_processing/Makefile.am,
	src/powerpc/new_exception_processing/remdeb.h,
	src/powerpc/new_exception_processing/remdeb_svc.c,
	src/powerpc/new_exception_processing/remdeb_xdr.c: Modified.

1 files changed, 77 insertions, 86 deletions

diff --git a/c/src/librdbg/src/i386/excep_f.c b/c/src/librdbg/src/i386/excep_f.c
index 100b0d79d6..d994e4f7e5 100644
--- a/c/src/librdbg/src/i386/excep_f.c
+++ b/c/src/librdbg/src/i386/excep_f.c
@@ -22,43 +22,41 @@
    It is identical to the one used by the PM and the AM.
    ----------------------------------------------------------------- */
 
-    int
-ExcepToSig (Exception_context *ctx)
+  int
+ExcepToSig (Exception_context * ctx)
 {
-    int excep = getExcNum (ctx);
-  
-
-    switch (excep) {
-      
-    case I386_EXCEPTION_MATH_COPROC_UNAVAIL: 
-    case I386_EXCEPTION_I386_COPROC_SEG_ERR: 
-    case I386_EXCEPTION_FLOAT_ERROR: 
-    case I386_EXCEPTION_BOUND: 
-	return SIGFPE;
-
-    case I386_EXCEPTION_DEBUG: 
-    case I386_EXCEPTION_BREAKPOINT: 
-    case I386_EXCEPTION_ENTER_RDBG: 
-	return SIGTRAP;
-
-    case I386_EXCEPTION_OVERFLOW: 
-    case I386_EXCEPTION_DIVIDE_BY_ZERO:
-    case I386_EXCEPTION_ILLEGAL_INSTR:  
-	return SIGILL;
-
-    case I386_EXCEPTION_SEGMENT_NOT_PRESENT:
-    case I386_EXCEPTION_STACK_SEGMENT_FAULT:
-    case I386_EXCEPTION_GENERAL_PROT_ERR: 
-    case I386_EXCEPTION_PAGE_FAULT: 
-	return SIGSEGV;
+  int excep = getExcNum (ctx);
 
-    default:
-	break;
-    }
-    return SIGKILL;
+  switch (excep) {
+
+  case I386_EXCEPTION_MATH_COPROC_UNAVAIL:
+  case I386_EXCEPTION_I386_COPROC_SEG_ERR:
+  case I386_EXCEPTION_FLOAT_ERROR:
+  case I386_EXCEPTION_BOUND:
+    return SIGFPE;
+
+  case I386_EXCEPTION_DEBUG:
+  case I386_EXCEPTION_BREAKPOINT:
+  case I386_EXCEPTION_ENTER_RDBG:
+    return SIGTRAP;
+
+  case I386_EXCEPTION_OVERFLOW:
+  case I386_EXCEPTION_DIVIDE_BY_ZERO:
+  case I386_EXCEPTION_ILLEGAL_INSTR:
+    return SIGILL;
+
+  case I386_EXCEPTION_SEGMENT_NOT_PRESENT:
+  case I386_EXCEPTION_STACK_SEGMENT_FAULT:
+  case I386_EXCEPTION_GENERAL_PROT_ERR:
+  case I386_EXCEPTION_PAGE_FAULT:
+    return SIGSEGV;
+
+  default:
+    break;
+  }
+  return SIGKILL;
 }
 
-  
 /*----- Breakpoint Exception management -----*/
 
     /*
@@ -66,88 +64,81 @@ ExcepToSig (Exception_context *ctx)
      *  software breakpoints.
      */
 
-void
-BreakPointExcHdl(CPU_Exception_frame *ctx) 
+  void
+BreakPointExcHdl (CPU_Exception_frame * ctx)
 {
   rtems_status_code status;
   rtems_id continueSemId;
 
-  if ( (justSaveContext) && (ctx->idtIndex == I386_EXCEPTION_ENTER_RDBG) ) {
+  if ((justSaveContext) && (ctx->idtIndex == I386_EXCEPTION_ENTER_RDBG)) {
     PushSavedExceptCtx (_Thread_Executing->Object.id, ctx);
     justSaveContext = 0;
-  }
-  else {
-    if (ctx->idtIndex != I386_EXCEPTION_DEBUG){
+  } else {
+    if (ctx->idtIndex != I386_EXCEPTION_DEBUG) {
       NbSerializedCtx++;
-      rtems_semaphore_obtain(serializeSemId, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
+      rtems_semaphore_obtain (serializeSemId, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
       NbSerializedCtx--;
     }
-      
+
     currentTargetThread = _Thread_Executing->Object.id;
 
 #ifdef DDEBUG
-    printk("----------------------------------------------------------\n");
-    printk("Exception %d caught at PC %x by thread %d\n",
-	   ctx->idtIndex,
-	   ctx->eip,
-	   _Thread_Executing->Object.id);
-    printk("----------------------------------------------------------\n");
-    printk("Processor execution context at time of the fault was  :\n");
-    printk("----------------------------------------------------------\n");
-    printk(" EAX = %x	EBX = %x	ECX = %x	EDX = %x\n",
-	   ctx->eax, ctx->ebx, ctx->ecx, ctx->edx);
-    printk(" ESI = %x	EDI = %x	EBP = %x	ESP = %x\n",
-	   ctx->esi, ctx->edi, ctx->ebp, ctx->esp0);
-    printk("----------------------------------------------------------\n");
-    printk("Error code pushed by processor itself (if not 0) = %x\n",
-	   ctx->faultCode);
-    printk("----------------------------------------------------------\n\n");
+    printk ("----------------------------------------------------------\n");
+    printk ("Exception %d caught at PC %x by thread %d\n",
+            ctx->idtIndex, ctx->eip, _Thread_Executing->Object.id);
+    printk ("----------------------------------------------------------\n");
+    printk ("Processor execution context at time of the fault was  :\n");
+    printk ("----------------------------------------------------------\n");
+    printk (" EAX = %x	EBX = %x	ECX = %x	EDX = %x\n",
+            ctx->eax, ctx->ebx, ctx->ecx, ctx->edx);
+    printk (" ESI = %x	EDI = %x	EBP = %x	ESP = %x\n",
+            ctx->esi, ctx->edi, ctx->ebp, ctx->esp0);
+    printk ("----------------------------------------------------------\n");
+    printk ("Error code pushed by processor itself (if not 0) = %x\n",
+            ctx->faultCode);
+    printk ("----------------------------------------------------------\n\n");
 #endif
 
-    status = rtems_semaphore_create (rtems_build_name('D', 'B', 'G', 'c'),
-				     0,
-				     RTEMS_FIFO |
-				     RTEMS_COUNTING_SEMAPHORE |
-				     RTEMS_NO_INHERIT_PRIORITY |
-				     RTEMS_NO_PRIORITY_CEILING |
-				     RTEMS_LOCAL,
-				     0,
-				     &continueSemId);
+    status = rtems_semaphore_create (rtems_build_name ('D', 'B', 'G', 'c'),
+                                     0,
+                                     RTEMS_FIFO |
+                                     RTEMS_COUNTING_SEMAPHORE |
+                                     RTEMS_NO_INHERIT_PRIORITY |
+                                     RTEMS_NO_PRIORITY_CEILING |
+                                     RTEMS_LOCAL, 0, &continueSemId);
     if (status != RTEMS_SUCCESSFUL)
-      rtems_panic ("Can't create continue semaphore: `%s'\n",rtems_status_text(status));
+      rtems_panic ("Can't create continue semaphore: `%s'\n",
+                   rtems_status_text (status));
 
     PushExceptCtx (_Thread_Executing->Object.id, continueSemId, ctx);
-  
-    switch (ctx->idtIndex){
+
+    switch (ctx->idtIndex) {
     case I386_EXCEPTION_DEBUG:
-      DPRINTF((" DEBUG EXCEPTION !!!\n"));
+      DPRINTF ((" DEBUG EXCEPTION !!!\n"));
       ctx->eflags &= ~EFLAGS_TF;
-      ExitForSingleStep-- ;
-      rtems_semaphore_release( wakeupEventSemId );
-    break;
+      ExitForSingleStep--;
+      rtems_semaphore_release (wakeupEventSemId);
+      break;
 
     case I386_EXCEPTION_BREAKPOINT:
-      DPRINTF((" BREAKPOINT EXCEPTION !!!\n"));
-      rtems_semaphore_release( wakeupEventSemId );
-    break;
+      DPRINTF ((" BREAKPOINT EXCEPTION !!!\n"));
+      rtems_semaphore_release (wakeupEventSemId);
+      break;
 
     case I386_EXCEPTION_ENTER_RDBG:
-      DPRINTF((" ENTER RDBG !!!\n"));
-      rtems_semaphore_release( wakeupEventSemId );
+      DPRINTF ((" ENTER RDBG !!!\n"));
+      rtems_semaphore_release (wakeupEventSemId);
       break;
 
     default:
-      DPRINTF((" OTHER EXCEPTION !!!\n"));
-      rtems_semaphore_release( wakeupEventSemId );
+      DPRINTF ((" OTHER EXCEPTION !!!\n"));
+      rtems_semaphore_release (wakeupEventSemId);
       break;
     }
 
-    rtems_semaphore_obtain(continueSemId, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
-    
+    rtems_semaphore_obtain (continueSemId, RTEMS_WAIT, RTEMS_NO_TIMEOUT);
+
     PopExceptCtx (_Thread_Executing->Object.id);
-    rtems_semaphore_delete(continueSemId);
+    rtems_semaphore_delete (continueSemId);
   }
 }
-
-
-