summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRyan Long <ryan.long@oarcorp.com>2021-03-10 10:05:21 -0500
committerJoel Sherrill <joel@rtems.org>2021-04-29 09:48:00 -0500
commitcdf66529fd2dcbedc27f0ac9ac2f3e4737ea4d0b (patch)
tree922076e47dcc911dc6e50f15779ee74800ecad80
parenta70d60aff70b55a883a855c7f5c964124d9368f8 (diff)
downloadrtems-cdf66529fd2dcbedc27f0ac9ac2f3e4737ea4d0b.tar.bz2
objectextendinformation.c: Ensure information->object_blocks is not NULL
CID 26033: Dereference after null check in _Objects_Extend_information(). Closes #4326
-rw-r--r--cpukit/score/src/objectextendinformation.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/cpukit/score/src/objectextendinformation.c b/cpukit/score/src/objectextendinformation.c
index 9796eb9e56..c6693016d4 100644
--- a/cpukit/score/src/objectextendinformation.c
+++ b/cpukit/score/src/objectextendinformation.c
@@ -171,6 +171,17 @@ Objects_Maximum _Objects_Extend_information(
if ( old_maximum > extend_count ) {
/*
+ * Coverity thinks there is a way for this to be NULL (CID #26033).
+ * After much time spent analyzing this, no one has identified the
+ * conditions where this can actually occur. Adding this _Assert ensures
+ * that it is never NULL. If this assert is triggered, condition
+ * generating this case will have been identified and it can be revisted.
+ * This is being done out of an abundance of caution since we could have
+ * easily flagged this as a false positive and ignored it completely.
+ */
+ _Assert(information->object_blocks != NULL);
+
+ /*
* Copy each section of the table over. This has to be performed as
* separate parts as size of each block has changed.
*/