diff options
| author | Joel Sherrill <joel.sherrill@OARcorp.com> | 2011-04-04 16:45:01 +0000 |
|---|---|---|
| committer | Joel Sherrill <joel.sherrill@OARcorp.com> | 2011-04-04 16:45:01 +0000 |
| commit | 2fe013a1452befd2b2f5e8da073346550ca686b0 (patch) | |
| tree | b8ce64349368b161bfac9880e417dc38741c6c55 | |
| parent | 2011-03-22 Joel Sherrill <joel.sherrilL@OARcorp.com> (diff) | |
| download | rtems-2fe013a1452befd2b2f5e8da073346550ca686b0.tar.bz2 | |
2011-04-04 Joel Sherrill <joel.sherrilL@OARcorp.com>
PR 1768/bsps
* shared/irq/irq_asm.S: The nbench benchmark highlighted the fact that
we do not perform a cld before calling C code in the ISR. This was
historically not a problem but gcc 4.3 changed the behavior. From
http://gcc.gnu.org/gcc-4.3/changes.html
| -rw-r--r-- | c/src/lib/libbsp/i386/ChangeLog | 8 | ||||
| -rw-r--r-- | c/src/lib/libbsp/i386/shared/irq/irq_asm.S | 7 |
2 files changed, 15 insertions, 0 deletions
diff --git a/c/src/lib/libbsp/i386/ChangeLog b/c/src/lib/libbsp/i386/ChangeLog index a0a02e8407..9848f8002b 100644 --- a/c/src/lib/libbsp/i386/ChangeLog +++ b/c/src/lib/libbsp/i386/ChangeLog @@ -1,3 +1,11 @@ +2011-04-04 Joel Sherrill <joel.sherrilL@OARcorp.com> + + PR 1768/bsps + * shared/irq/irq_asm.S: The nbench benchmark highlighted the fact that + we do not perform a cld before calling C code in the ISR. This was + historically not a problem but gcc 4.3 changed the behavior. From + http://gcc.gnu.org/gcc-4.3/changes.html + 2009-05-18 Joel Sherrill <joel.sherrill@OARcorp.com> * shared/irq/irq.c, shared/irq/irq.h, shared/irq/irq_asm.S: Add shared diff --git a/c/src/lib/libbsp/i386/shared/irq/irq_asm.S b/c/src/lib/libbsp/i386/shared/irq/irq_asm.S index c8f3df3b5e..fc53b54fdd 100644 --- a/c/src/lib/libbsp/i386/shared/irq/irq_asm.S +++ b/c/src/lib/libbsp/i386/shared/irq/irq_asm.S @@ -121,6 +121,13 @@ nested: movl ebp, esp popl ebp + /* + * GCC versions starting with 4.3 no longer place the cld + * instruction before string operations. We need to ensure + * it is set correctly for ISR handlers. + */ + cld + /* * restore the original i8259 masks */ |