From 724505095ae634b485d1b1b8888b147e3a130ea0 Mon Sep 17 00:00:00 2001 From: Ryan Long Date: Thu, 12 Aug 2021 14:59:50 -0400 Subject: ReportsBase.cc: Add assert for member variables The uncoveredRanges and uncoveredBranch member variables are allocated as a pair. They are both either NULL or not NULL. Coverity does not know this though, so this assert is added to ensure they are not NULL before being dereferenced. CID 1503710: Dereference after null check Closes #4428 --- tester/covoar/ReportsBase.cc | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'tester/covoar') diff --git a/tester/covoar/ReportsBase.cc b/tester/covoar/ReportsBase.cc index bc05037..219e5af 100644 --- a/tester/covoar/ReportsBase.cc +++ b/tester/covoar/ReportsBase.cc @@ -3,6 +3,7 @@ #include #include #include +#include #include #include @@ -231,6 +232,10 @@ void ReportsBase::WriteAnnotatedReport( const std::string& fileName ) continue; } + // uncoveredRanges and uncoveredBranches are always allocated as a pair + // so both are NULL or both are not NULL. + assert( info.uncoveredRanges != NULL && info.uncoveredBranches != NULL ); + // If uncoveredRanges and uncoveredBranches are empty, then everything // must have been covered for this symbol. Just skip it. if ( -- cgit v1.2.3