From 2e711f2b4b59398a18d21ea34bdb064c459fdd45 Mon Sep 17 00:00:00 2001 From: Martin Erik Werner Date: Tue, 3 Sep 2019 01:48:28 +0200 Subject: Address several issues from compiling examples Compiling the code from examples "code-block:: c" along with public includes and a bsp exposed a few issues amongst a lot of false positives. Address some of these: * Terminate struct declarations with ';'. Mainly for pedantic correctness. * Show ptrdiff_t instead of size_t for the sbrk() prototype, matching the current argument type in rtems. * Replace some occurrences of unsigned16 with uint16_t. * Fix odd type declaration, "uint8_t char*" -> "char*". * Use appropriate helper to get chain head instead of invalid access to nonexistent struct member. * Remove several excess '\' escapes. * Use RTEMS_SELF instead of undefined SELF. * Use rtems_task instead of void for task functions. * Add missing stack size parameter in task creation. * Use rtems_interrupt_level instead of undefined rtems_interrupt. * Correct return value format for rtems_object_id_get_api() rtems_object_id_get_index() (enum and uint16_t) and also fix corresponding print formatting. * Correct return value documentation for rtems_object_id_get_class(), rtems_object_id_get_node() and rtems_object_id_get_index() int -> uint32_t. * Use RTEMS_SUCCESSFUL instead of undefined RTEMS_STATUS_SUCCESSFUL and fix return value variable name in rate monotonic examples. * Use RTEMS_TIMEOUT instead of undefined TIMEOUT and RTEMS_PERIOD_STATUS instead of undefined STATUS. * Add missing fields to ftpd configuration. * Correct parameter types in ftpd hook prototype, unsigned char * -> void *. * Fix various code-block:: attributes, c -> makefile and c -> shell. * Add missing parenthesis in socket buffer memory calculation example. * Remove typedef in declaration of mq_attr since it is defiend without typedef in reality. * Update siginfo_t declaration to match current reality. * Update shell user command definition example to include mode, uid and gid. --- c-user/fatal_error.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'c-user/fatal_error.rst') diff --git a/c-user/fatal_error.rst b/c-user/fatal_error.rst index 82fd82a..f785647 100644 --- a/c-user/fatal_error.rst +++ b/c-user/fatal_error.rst @@ -158,7 +158,7 @@ INTERNAL_ERROR_THREAD_EXITTED (5) .. code-block:: c - void task( rtems_arg arg ) + rtems_task task( rtems_task_argument arg ) { /* Classic API tasks must not return */ } @@ -171,6 +171,7 @@ INTERNAL_ERROR_THREAD_EXITTED (5) sc = rtems_task_create( rtems_build_name('T', 'A', 'S', 'K'), 1, + RTEMS_MINIMUM_STACK_SIZE, RTEMS_DEFAULT_MODES, RTEMS_DEFAULT_ATTRIBUTES, &task_id @@ -258,7 +259,7 @@ INTERNAL_ERROR_THREAD_QUEUE_ENQUEUE_STICKY_FROM_BAD_STATE (29) .. code-block:: c - void bad( rtems_id timer_id, void *arg ) + rtems_timer_service_routine bad( rtems_id timer_id, void *arg ) { rtems_id *sem_id; @@ -268,7 +269,7 @@ INTERNAL_ERROR_THREAD_QUEUE_ENQUEUE_STICKY_FROM_BAD_STATE (29) assert( 0 ); } - void fire_bad_timer( rtems_task_argument arg ) + rtems_task fire_bad_timer( rtems_task_argument arg ) { rtems_status_code sc; rtems_id sem_id; -- cgit v1.2.3