summaryrefslogtreecommitdiffstats
path: root/bsd_eth_drivers/libbsdport/rtems_callout.c
diff options
context:
space:
mode:
authorTill Straumann <strauman@slac.stanford.edu>2009-08-06 19:41:57 +0000
committerTill Straumann <strauman@slac.stanford.edu>2009-08-06 19:41:57 +0000
commitd8b6f64e29c55a857ca346bd2247cd5aeddaab9e (patch)
tree161588d8f836ace7d7ccef74c8c616cf2319efe3 /bsd_eth_drivers/libbsdport/rtems_callout.c
parent370f3c5469cbc626113a3a53dde09bb86d50d788 (diff)
downloadlibbsdport-d8b6f64e29c55a857ca346bd2247cd5aeddaab9e.tar.bz2
2009-08-06 Till Straumann <Till.Straumann@TU-Berlin.de>
* libbsdport/rtems_callout.c: fixed possible race condition. callout_stop() must check again from critical/protected section of code if callout is still on the list/active. Otherwise, the callout-task could have executed and removed the callout between callout_stop() checking the p_prev pointer and entering the critical section.
Diffstat (limited to 'bsd_eth_drivers/libbsdport/rtems_callout.c')
-rw-r--r--bsd_eth_drivers/libbsdport/rtems_callout.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/bsd_eth_drivers/libbsdport/rtems_callout.c b/bsd_eth_drivers/libbsdport/rtems_callout.c
index de1df83..c041c5b 100644
--- a/bsd_eth_drivers/libbsdport/rtems_callout.c
+++ b/bsd_eth_drivers/libbsdport/rtems_callout.c
@@ -186,6 +186,11 @@ LIST_KEY_DECL(k);
return 0; /* not currently on a list */
LIST_LOCK(k);
+ /* have to check again */
+ if ( ! c->c_pprev ) {
+ LIST_UNLOCK(k);
+ return 0;
+ }
/* remove from list */
c_deq(c);
rtems_interrupt_disable(l);