From 152ad7d1cc9d26eed0186cbb4a40b3b84bf1fee8 Mon Sep 17 00:00:00 2001 From: Sebastian Huber Date: Tue, 24 Jun 2014 09:31:14 +0200 Subject: score: Fix _Thread_Start_multitasking() on SMP The _CPU_Context_Restart_self() implementations usually assume that self context is executing. FIXME: We have a race condition in _Thread_Start_multitasking() in case another thread already performed scheduler operations and moved the heir thread to another processor. The time frame for this is likely too small to be practically relevant. --- cpukit/score/src/threadstartmultitasking.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/cpukit/score/src/threadstartmultitasking.c b/cpukit/score/src/threadstartmultitasking.c index c1c8725eae..4467937c58 100644 --- a/cpukit/score/src/threadstartmultitasking.c +++ b/cpukit/score/src/threadstartmultitasking.c @@ -61,6 +61,19 @@ void _Thread_Start_multitasking( void ) _Profiling_Thread_dispatch_disable( cpu_self, 0 ); +#if defined(RTEMS_SMP) + /* + * The _CPU_Context_Restart_self() implementations usually assume that self + * context is executing. + * + * FIXME: We have a race condition here in case another thread already + * performed scheduler operations and moved our heir thread to another + * processor. The time frame for this is likely too small to be practically + * relevant. + */ + _CPU_Context_Set_is_executing( &heir->Registers, true ); +#endif + #if defined(_CPU_Start_multitasking) _CPU_Start_multitasking( &heir->Registers ); #else -- cgit v1.2.3