diff options
| author | Josh Oguin <josh.oguin@oarcorp.com> | 2014-11-19 14:44:54 -0600 |
|---|---|---|
| committer | Joel Sherrill <joel.sherrill@oarcorp.com> | 2014-11-26 07:51:59 -0600 |
| commit | e106aa73802c95ee2c6b72bcec8830f4b29d6e9b (patch) | |
| tree | ca179c752184b56a652f815721340a78f07cb142 | |
| parent | monitor/mon-editor.c: Use puts() and snprintf() not fprintf() or sprintf() (diff) | |
| download | rtems-e106aa73802c95ee2c6b72bcec8830f4b29d6e9b.tar.bz2 | |
cpukit/posix/src/timertsr.c: Add _Assert()
CodeSonar flagged this as an empty if body. Upon analysis, it turned
out to be an error that we think should never occur but if it did,
there is nothing we could do about it. It would likely just indicate
the thread was deleted before we got here. Adding the _Assert() at least
will flag this if it ever occurs during a debug build and we can discuss
what happened.
| -rw-r--r-- | cpukit/posix/src/timertsr.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/cpukit/posix/src/timertsr.c b/cpukit/posix/src/timertsr.c index fbbdf59394..85554633e9 100644 --- a/cpukit/posix/src/timertsr.c +++ b/cpukit/posix/src/timertsr.c @@ -73,7 +73,14 @@ void _POSIX_Timer_TSR( */ if ( pthread_kill ( ptimer->thread_id, ptimer->inf.sigev_signo ) ) { - /* XXX error handling */ + _Assert( FALSE ); + /* + * TODO: What if an error happens at run-time? This should never + * occur because the timer should be canceled if the thread + * is deleted. This method is being invoked from the Clock + * Tick ISR so even if we decide to take action on an error, + * we don't have many options. We shouldn't shut the system down. + */ } /* After the signal handler returns, the count of expirations of the |