From 92f7f67297b9053e6846760e6c8059be0fa1c86c Mon Sep 17 00:00:00 2001 From: Alex White Date: Fri, 9 Apr 2021 16:52:44 -0500 Subject: rtemstoolkit: Filter mail options from log output This filters mail-related options out before logging the command line options. This is needed to prevent leaking potentially sensitive information via logs and emails. Updates #4384 --- rtemstoolkit/options.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/rtemstoolkit/options.py b/rtemstoolkit/options.py index 32a7016..5ebe3bc 100644 --- a/rtemstoolkit/options.py +++ b/rtemstoolkit/options.py @@ -508,7 +508,22 @@ class command_line(object): return None def log_info(self): - log.output(log.info(self.argv)) + # Filter potentially sensitive mail options out. + filtered_args = [ + arg for arg in self.argv + if all( + smtp_opt not in arg + for smtp_opt in [ + '--smtp-host', + '--mail-to', + '--mail-from', + '--smtp-user', + '--smtp-password', + '--smtp-port' + ] + ) + ] + log.output(log.info(filtered_args)) def load(opts): """ -- cgit v1.2.3